[INFO] crate vobsub 0.2.3 is already in cache [INFO] extracting crate vobsub 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/vobsub/0.2.3 [INFO] extracting crate vobsub 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vobsub/0.2.3 [INFO] validating manifest of vobsub-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vobsub-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vobsub-0.2.3 [INFO] finished frobbing vobsub-0.2.3 [INFO] frobbed toml for vobsub-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/vobsub/0.2.3/Cargo.toml [INFO] started frobbing vobsub-0.2.3 [INFO] finished frobbing vobsub-0.2.3 [INFO] frobbed toml for vobsub-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vobsub/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vobsub-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vobsub/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 631a4c284e78de67b3113e468f305a31e8a9af8f8d59bcb2defbad09e74a768a [INFO] running `"docker" "start" "-a" "631a4c284e78de67b3113e468f305a31e8a9af8f8d59bcb2defbad09e74a768a"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking memchr v2.1.3 [INFO] [stderr] Checking backtrace-sys v0.1.28 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking vobsub v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idx.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | sub_data: sub_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | coordinates: coordinates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:491:9 [INFO] [stderr] | [INFO] [stderr] 491 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/idx.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | sub_data: sub_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:488:9 [INFO] [stderr] | [INFO] [stderr] 488 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | coordinates: coordinates, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:491:9 [INFO] [stderr] | [INFO] [stderr] 491 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sub.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mpeg2/clock.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn with_ext(&self, ext: u16) -> Clock { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mpeg2/clock.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_seconds(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mpeg2/clock.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | s = s % 3600.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s %= 3600.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mpeg2/clock.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | s = s % 60.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s %= 60.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:391:53 [INFO] [stderr] | [INFO] [stderr] 391 | start_time = start_time.or(Some(time)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(time))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:394:49 [INFO] [stderr] | [INFO] [stderr] 394 | end_time = end_time.or(Some(time)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(time))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:397:47 [INFO] [stderr] | [INFO] [stderr] 397 | palette = palette.or(Some(p)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:400:43 [INFO] [stderr] | [INFO] [stderr] 400 | alpha = alpha.or(Some(a)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:412:55 [INFO] [stderr] | [INFO] [stderr] 412 | coordinates = coordinates.or(Some(c.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(c.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/mpeg2/clock.rs:80:42 [INFO] [stderr] | [INFO] [stderr] 80 | Clock::base(0b_000_000000001011000_001000001000000))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0_0000_0000_0010_1100_0001_0000_0100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/mpeg2/clock.rs:83:42 [INFO] [stderr] | [INFO] [stderr] 83 | Clock::base(0b_000_000000001011000_001000001000000) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0_0000_0000_0010_1100_0001_0000_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mpeg2/clock.rs:84:44 [INFO] [stderr] | [INFO] [stderr] 84 | .with_ext(0b001010100))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0101_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mpeg2/pes.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | pts: Clock::base(2815200), [INFO] [stderr] | ^^^^^^^ help: consider: `2_815_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mpeg2/pes.rs:207:55 [INFO] [stderr] | [INFO] [stderr] 207 | pts: Clock::base(2815200), [INFO] [stderr] | ^^^^^^^ help: consider: `2_815_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mpeg2/pes.rs:316:34 [INFO] [stderr] | [INFO] [stderr] 316 | pts: Clock::base(2815200), [INFO] [stderr] | ^^^^^^^ help: consider: `2_815_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mpeg2/clock.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn with_ext(&self, ext: u16) -> Clock { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mpeg2/clock.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_seconds(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mpeg2/clock.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | s = s % 3600.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `s %= 3600.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mpeg2/clock.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | s = s % 60.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `s %= 60.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:391:53 [INFO] [stderr] | [INFO] [stderr] 391 | start_time = start_time.or(Some(time)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(time))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:394:49 [INFO] [stderr] | [INFO] [stderr] 394 | end_time = end_time.or(Some(time)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(time))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:397:47 [INFO] [stderr] | [INFO] [stderr] 397 | palette = palette.or(Some(p)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(p))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:400:43 [INFO] [stderr] | [INFO] [stderr] 400 | alpha = alpha.or(Some(a)); [INFO] [stderr] | ^^^^^^^^^^^ help: try this: `or_else(|| Some(a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/sub.rs:412:55 [INFO] [stderr] | [INFO] [stderr] 412 | coordinates = coordinates.or(Some(c.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(c.clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.29s [INFO] running `"docker" "inspect" "631a4c284e78de67b3113e468f305a31e8a9af8f8d59bcb2defbad09e74a768a"` [INFO] running `"docker" "rm" "-f" "631a4c284e78de67b3113e468f305a31e8a9af8f8d59bcb2defbad09e74a768a"` [INFO] [stdout] 631a4c284e78de67b3113e468f305a31e8a9af8f8d59bcb2defbad09e74a768a