[INFO] crate vndb 0.6.3 is already in cache [INFO] extracting crate vndb 0.6.3 into work/ex/clippy-test-run/sources/stable/reg/vndb/0.6.3 [INFO] extracting crate vndb 0.6.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vndb/0.6.3 [INFO] validating manifest of vndb-0.6.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vndb-0.6.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vndb-0.6.3 [INFO] removed 0 missing tests [INFO] finished frobbing vndb-0.6.3 [INFO] frobbed toml for vndb-0.6.3 written to work/ex/clippy-test-run/sources/stable/reg/vndb/0.6.3/Cargo.toml [INFO] started frobbing vndb-0.6.3 [INFO] removed 0 missing tests [INFO] finished frobbing vndb-0.6.3 [INFO] frobbed toml for vndb-0.6.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vndb/0.6.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vndb-0.6.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vndb/0.6.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69da9b85af213ca0f1e07f508a72e8ee0ea482fe567f8520502b3991e574e963 [INFO] running `"docker" "start" "-a" "69da9b85af213ca0f1e07f508a72e8ee0ea482fe567f8520502b3991e574e963"` [INFO] [stderr] Checking vndb v0.6.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/mod.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const API_HOST: &'static str = "api.vndb.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/mod.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | pub const API_HOST: &'static str = "api.vndb.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `protocol::message::request::get::Flags` [INFO] [stderr] --> src/protocol/message/request.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Self { [INFO] [stderr] 78 | | Self { [INFO] [stderr] 79 | | inner: vec![] [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] 72 | pub struct Flags { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `protocol::message::request::get::Flags` [INFO] [stderr] --> src/protocol/message/request.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Self { [INFO] [stderr] 78 | | Self { [INFO] [stderr] 79 | | inner: vec![] [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | #[derive(Default)] [INFO] [stderr] 72 | pub struct Flags { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/protocol/message/request.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn short<'a>(&'a self) -> &'a str { [INFO] [stderr] 158 | | &self.inner[..1] [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `protocol::message::request::get::Filters` [INFO] [stderr] --> src/protocol/message/request.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> Self { [INFO] [stderr] 208 | | Self { [INFO] [stderr] 209 | | inner: vec![] [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | #[derive(Default)] [INFO] [stderr] 202 | pub struct Filters { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/protocol/message/request.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn short<'a>(&'a self) -> &'a str { [INFO] [stderr] 158 | | &self.inner[..1] [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `protocol::message::request::get::Filters` [INFO] [stderr] --> src/protocol/message/request.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> Self { [INFO] [stderr] 208 | | Self { [INFO] [stderr] 209 | | inner: vec![] [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | #[derive(Default)] [INFO] [stderr] 202 | pub struct Filters { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/response/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn from_str(error: &str) -> serde_json::Result { [INFO] [stderr] 28 | | serde_json::from_str(error) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/response/mod.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn from_str(results: &str) -> serde_json::Result { [INFO] [stderr] 121 | | Ok(Self { [INFO] [stderr] 122 | | inner: serde_json::from_str(results)? [INFO] [stderr] 123 | | }) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/protocol/message/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &Request::Login(ref login) => write!(f, "{}\x04", login), [INFO] [stderr] 47 | | &Request::Get(ref get) => write!(f, "{}\x04", get), [INFO] [stderr] 48 | | &Request::DBstats => write!(f, "dbstats\x04") [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | Request::Login(ref login) => write!(f, "{}\x04", login), [INFO] [stderr] 47 | Request::Get(ref get) => write!(f, "{}\x04", get), [INFO] [stderr] 48 | Request::DBstats => write!(f, "dbstats\x04") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/mod.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn from_str(msg: &str) -> io::Result { [INFO] [stderr] 98 | | let mut split_msg = msg.splitn(2, ' '); [INFO] [stderr] 99 | | [INFO] [stderr] 100 | | let command = extract_field!(split_msg.next(), "VNDB sent empty response."); [INFO] [stderr] ... | [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/protocol/mod.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_str<'a>(msg: &'a [u8]) -> io::Result<&'a str> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/response/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn from_str(error: &str) -> serde_json::Result { [INFO] [stderr] 28 | | serde_json::from_str(error) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/protocol/mod.rs:55:51 [INFO] [stderr] | [INFO] [stderr] 55 | message::Response::from_str(line).map(|result| Some(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/response/mod.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn from_str(results: &str) -> serde_json::Result { [INFO] [stderr] 121 | | Ok(Self { [INFO] [stderr] 122 | | inner: serde_json::from_str(results)? [INFO] [stderr] 123 | | }) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/protocol/message/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &Request::Login(ref login) => write!(f, "{}\x04", login), [INFO] [stderr] 47 | | &Request::Get(ref get) => write!(f, "{}\x04", get), [INFO] [stderr] 48 | | &Request::DBstats => write!(f, "dbstats\x04") [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | Request::Login(ref login) => write!(f, "{}\x04", login), [INFO] [stderr] 47 | Request::Get(ref get) => write!(f, "{}\x04", get), [INFO] [stderr] 48 | Request::DBstats => write!(f, "dbstats\x04") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/protocol/message/mod.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn from_str(msg: &str) -> io::Result { [INFO] [stderr] 98 | | let mut split_msg = msg.splitn(2, ' '); [INFO] [stderr] 99 | | [INFO] [stderr] 100 | | let command = extract_field!(split_msg.next(), "VNDB sent empty response."); [INFO] [stderr] ... | [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/protocol/mod.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_str<'a>(msg: &'a [u8]) -> io::Result<&'a str> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/protocol/mod.rs:55:51 [INFO] [stderr] | [INFO] [stderr] 55 | message::Response::from_str(line).map(|result| Some(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.51s [INFO] running `"docker" "inspect" "69da9b85af213ca0f1e07f508a72e8ee0ea482fe567f8520502b3991e574e963"` [INFO] running `"docker" "rm" "-f" "69da9b85af213ca0f1e07f508a72e8ee0ea482fe567f8520502b3991e574e963"` [INFO] [stdout] 69da9b85af213ca0f1e07f508a72e8ee0ea482fe567f8520502b3991e574e963