[INFO] crate vm-info 0.1.0 is already in cache [INFO] extracting crate vm-info 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/vm-info/0.1.0 [INFO] extracting crate vm-info 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vm-info/0.1.0 [INFO] validating manifest of vm-info-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vm-info-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vm-info-0.1.0 [INFO] finished frobbing vm-info-0.1.0 [INFO] frobbed toml for vm-info-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/vm-info/0.1.0/Cargo.toml [INFO] started frobbing vm-info-0.1.0 [INFO] finished frobbing vm-info-0.1.0 [INFO] frobbed toml for vm-info-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vm-info/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vm-info-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vm-info/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c32643a6e68db15a6efafaf757d19a16c14d7271c385d59004cb35cd45e2bdb9 [INFO] running `"docker" "start" "-a" "c32643a6e68db15a6efafaf757d19a16c14d7271c385d59004cb35cd45e2bdb9"` [INFO] [stderr] Checking vm-info v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(94858956906496, first.start_address); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `94_858_956_906_496` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:204:20 [INFO] [stderr] | [INFO] [stderr] 204 | assert_eq!(94858957352960, first.end_address); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `94_858_957_352_960` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:213:25 [INFO] [stderr] | [INFO] [stderr] 213 | assert_eq!(Some(58219319), first.inode); [INFO] [stderr] | ^^^^^^^^ help: consider: `58_219_319` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | assert_eq!(106496, libpthread.offset); [INFO] [stderr] | ^^^^^^ help: consider: `106_496` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:243:25 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(Some(55705632), gconv.inode); [INFO] [stderr] | ^^^^^^^^ help: consider: `55_705_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | assert_eq!(18446744073699065856, last.start_address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_699_065_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mapped_region.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | assert_eq!(18446744073699069952, last.end_address); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_699_069_952` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/page_map.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self.is_swapped() { [INFO] [stderr] 35 | | true => Some(swap_type), [INFO] [stderr] 36 | | false => None, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_swapped() { Some(swap_type) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/page_map.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.is_swapped() { [INFO] [stderr] 45 | | true => Some(swap_offset), [INFO] [stderr] 46 | | false => None, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_swapped() { Some(swap_offset) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/mapped_region.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | / fn sample_maps_file() { [INFO] [stderr] 193 | | let path = path::Path::new("src/test-data/obexd-map.txt"); [INFO] [stderr] 194 | | [INFO] [stderr] 195 | | let mappings = iter_mapping_path(path) [INFO] [stderr] ... | [INFO] [stderr] 257 | | assert_eq!("[vsyscall]", last.pathname.as_ref().unwrap()); [INFO] [stderr] 258 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/page_map.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self.is_swapped() { [INFO] [stderr] 35 | | true => Some(swap_type), [INFO] [stderr] 36 | | false => None, [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_swapped() { Some(swap_type) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/page_map.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self.is_swapped() { [INFO] [stderr] 45 | | true => Some(swap_offset), [INFO] [stderr] 46 | | false => None, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_swapped() { Some(swap_offset) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/show-all.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | let pid = env::args() [INFO] [stderr] | _______________^ [INFO] [stderr] 11 | | .skip(1) [INFO] [stderr] 12 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/show-all.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | .unwrap_or(String::from("")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> examples/show-all.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | .map(|p| format!("{}", p)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `p.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/show-all.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | .unwrap_or(String::from("None")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("None"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `"docker" "inspect" "c32643a6e68db15a6efafaf757d19a16c14d7271c385d59004cb35cd45e2bdb9"` [INFO] running `"docker" "rm" "-f" "c32643a6e68db15a6efafaf757d19a16c14d7271c385d59004cb35cd45e2bdb9"` [INFO] [stdout] c32643a6e68db15a6efafaf757d19a16c14d7271c385d59004cb35cd45e2bdb9