[INFO] crate vivid 0.4.0 is already in cache [INFO] extracting crate vivid 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/vivid/0.4.0 [INFO] extracting crate vivid 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vivid/0.4.0 [INFO] validating manifest of vivid-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vivid-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vivid-0.4.0 [INFO] finished frobbing vivid-0.4.0 [INFO] frobbed toml for vivid-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/vivid/0.4.0/Cargo.toml [INFO] started frobbing vivid-0.4.0 [INFO] finished frobbing vivid-0.4.0 [INFO] frobbed toml for vivid-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vivid/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vivid-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vivid/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de957d3ad7a8e6193572f5f4989060fe927ab3a31690d688cebcd5d5394114e7 [INFO] running `"docker" "start" "-a" "de957d3ad7a8e6193572f5f4989060fe927ab3a31690d688cebcd5d5394114e7"` [INFO] [stderr] Compiling ansi_colours v1.0.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking vivid v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/theme.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 86 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 87 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stderr] 88 | | { [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 86 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 87 | || map.contains_key(&Yaml::String("font-style".into()))) && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stderr] 88 | // We can not specialize further [INFO] [stderr] 89 | break; [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/theme.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 86 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 87 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stderr] 88 | | { [INFO] [stderr] ... | [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 86 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 87 | || map.contains_key(&Yaml::String("font-style".into()))) && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stderr] 88 | // We can not specialize further [INFO] [stderr] 89 | break; [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filetypes.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_mapping(value: &Yaml, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 59 | let mut child_category = category.clone(); [INFO] [stderr] | ---------------- help: change `category.clone()` to: `category.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | paths.iter().find(|p| Path::exists(*p)).map(|p| *p) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `paths.iter().find(|p| Path::exists(*p)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filetypes.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_mapping(value: &Yaml, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 59 | let mut child_category = category.clone(); [INFO] [stderr] | ---------------- help: change `category.clone()` to: `category.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/util.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | paths.iter().find(|p| Path::exists(*p)).map(|p| *p) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `paths.iter().find(|p| Path::exists(*p)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.52s [INFO] running `"docker" "inspect" "de957d3ad7a8e6193572f5f4989060fe927ab3a31690d688cebcd5d5394114e7"` [INFO] running `"docker" "rm" "-f" "de957d3ad7a8e6193572f5f4989060fe927ab3a31690d688cebcd5d5394114e7"` [INFO] [stdout] de957d3ad7a8e6193572f5f4989060fe927ab3a31690d688cebcd5d5394114e7