[INFO] crate vgmdb 0.3.1 is already in cache
[INFO] extracting crate vgmdb 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/vgmdb/0.3.1
[INFO] extracting crate vgmdb 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vgmdb/0.3.1
[INFO] validating manifest of vgmdb-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vgmdb-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vgmdb-0.3.1
[INFO] finished frobbing vgmdb-0.3.1
[INFO] frobbed toml for vgmdb-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/vgmdb/0.3.1/Cargo.toml
[INFO] started frobbing vgmdb-0.3.1
[INFO] finished frobbing vgmdb-0.3.1
[INFO] frobbed toml for vgmdb-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vgmdb/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vgmdb-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vgmdb/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d2c1a0c19ab945ad54133ba8111b0729cfcc820d433a344fbffad248293e0bdf
[INFO] running `"docker" "start" "-a" "d2c1a0c19ab945ad54133ba8111b0729cfcc820d433a344fbffad248293e0bdf"`
[INFO] [stderr]     Checking simple_parallel v0.2.1
[INFO] [stderr]     Checking id3 v0.1.12
[INFO] [stderr]     Checking vgmdb v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vgmdb/io.rs:56:40
[INFO] [stderr]    |
[INFO] [stderr] 56 |     Track{name:a, track_length:length, index:index }
[INFO] [stderr]    |                                        ^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |     let meta = AlbumMeta{ comment:comment
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^ help: replace it with: `comment`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:156:27
[INFO] [stderr]     |
[INFO] [stderr] 156 |                         , name: name
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vgmdb/io.rs:56:40
[INFO] [stderr]    |
[INFO] [stderr] 56 |     Track{name:a, track_length:length, index:index }
[INFO] [stderr]    |                                        ^^^^^^^^^^^ help: replace it with: `index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |     let meta = AlbumMeta{ comment:comment
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^ help: replace it with: `comment`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:156:27
[INFO] [stderr]     |
[INFO] [stderr] 156 |                         , name: name
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         return Album{ release_date : self.release_date
[INFO] [stderr] 21 | |                     , discs:  new_discs
[INFO] [stderr] 22 | |                     , catalog : self.catalog
[INFO] [stderr] 23 | |                     , category : self.category
[INFO] [stderr] 24 | |                     , classification : self.classification
[INFO] [stderr] 25 | |                     , name: self.name
[INFO] [stderr] 26 | |                     };
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Album{ release_date : self.release_date
[INFO] [stderr] 21 |                     , discs:  new_discs
[INFO] [stderr] 22 |                     , catalog : self.catalog
[INFO] [stderr] 23 |                     , category : self.category
[INFO] [stderr] 24 |                     , classification : self.classification
[INFO] [stderr] 25 |                     , name: self.name
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return Ok(res);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]   --> src/vgmdb/io.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |        , tracks: d.tracks.into_iter().zip((1..)).map(|(t,i)|  convert_track(t, i) ).collect()
[INFO] [stderr]    |                                           ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/vgmdb/io.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |        , tracks: d.tracks.into_iter().zip((1..)).map(|(t,i)|  convert_track(t, i) ).collect()
[INFO] [stderr]    |                                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return length;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/data.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return v;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]   --> src/vgmdb/data.rs:55:44
[INFO] [stderr]    |
[INFO] [stderr] 55 |         for (d,i) in self.discs.iter().zip((1..)) {
[INFO] [stderr]    |                                            ^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/vgmdb/data.rs:55:44
[INFO] [stderr]    |
[INFO] [stderr] 55 |         for (d,i) in self.discs.iter().zip((1..)) {
[INFO] [stderr]    |                                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return options
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         return Album{ release_date : self.release_date
[INFO] [stderr] 21 | |                     , discs:  new_discs
[INFO] [stderr] 22 | |                     , catalog : self.catalog
[INFO] [stderr] 23 | |                     , category : self.category
[INFO] [stderr] 24 | |                     , classification : self.classification
[INFO] [stderr] 25 | |                     , name: self.name
[INFO] [stderr] 26 | |                     };
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 20 |         Album{ release_date : self.release_date
[INFO] [stderr] 21 |                     , discs:  new_discs
[INFO] [stderr] 22 |                     , catalog : self.catalog
[INFO] [stderr] 23 |                     , category : self.category
[INFO] [stderr] 24 |                     , classification : self.classification
[INFO] [stderr] 25 |                     , name: self.name
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     return Ok(res);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]   --> src/vgmdb/io.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |        , tracks: d.tracks.into_iter().zip((1..)).map(|(t,i)|  convert_track(t, i) ).collect()
[INFO] [stderr]    |                                           ^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/vgmdb/io.rs:46:43
[INFO] [stderr]    |
[INFO] [stderr] 46 |        , tracks: d.tracks.into_iter().zip((1..)).map(|(t,i)|  convert_track(t, i) ).collect()
[INFO] [stderr]    |                                           ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/io.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return length;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/vgmdb/data.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return v;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around method argument
[INFO] [stderr]   --> src/vgmdb/data.rs:55:44
[INFO] [stderr]    |
[INFO] [stderr] 55 |         for (d,i) in self.discs.iter().zip((1..)) {
[INFO] [stderr]    |                                            ^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/vgmdb/data.rs:55:44
[INFO] [stderr]    |
[INFO] [stderr] 55 |         for (d,i) in self.discs.iter().zip((1..)) {
[INFO] [stderr]    |                                            ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return options
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/vgmdb/io.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |     for part in time.rsplit(":") {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 | /     match options.to_json.is_empty() {
[INFO] [stderr] 79 | |        true  => process_files(options),
[INFO] [stderr] 80 | |        false => only_write_json(options),
[INFO] [stderr] 81 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if options.to_json.is_empty() { process_files(options) } else { only_write_json(options) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:137:42
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:146:34
[INFO] [stderr]     |
[INFO] [stderr] 146 |          , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:165:45
[INFO] [stderr]     |
[INFO] [stderr] 165 | fn do_per_album_meta(options:Options, paths:&Vec<std::fs::DirEntry>, album:vgmdb::data::Album){
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[std::fs::DirEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:179:46
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:188:38
[INFO] [stderr]     |
[INFO] [stderr] 188 |              , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:228:40
[INFO] [stderr]     |
[INFO] [stderr] 228 | fn do_per_track(options:Options, paths:&Vec<std::fs::DirEntry>, album:vgmdb::data::Album){
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[std::fs::DirEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:242:46
[INFO] [stderr]     |
[INFO] [stderr] 242 |         let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:251:38
[INFO] [stderr]     |
[INFO] [stderr] 251 |              , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:307:30
[INFO] [stderr]     |
[INFO] [stderr] 307 |     t.add_text_frame("TDRL", format!("{}", date));
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `date.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/vgmdb/io.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |     for part in time.rsplit(":") {
[INFO] [stderr]    |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 | /     match options.to_json.is_empty() {
[INFO] [stderr] 79 | |        true  => process_files(options),
[INFO] [stderr] 80 | |        false => only_write_json(options),
[INFO] [stderr] 81 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if options.to_json.is_empty() { process_files(options) } else { only_write_json(options) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:137:42
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:146:34
[INFO] [stderr]     |
[INFO] [stderr] 146 |          , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:165:45
[INFO] [stderr]     |
[INFO] [stderr] 165 | fn do_per_album_meta(options:Options, paths:&Vec<std::fs::DirEntry>, album:vgmdb::data::Album){
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[std::fs::DirEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:179:46
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:188:38
[INFO] [stderr]     |
[INFO] [stderr] 188 |              , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:228:40
[INFO] [stderr]     |
[INFO] [stderr] 228 | fn do_per_track(options:Options, paths:&Vec<std::fs::DirEntry>, album:vgmdb::data::Album){
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[std::fs::DirEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:242:46
[INFO] [stderr]     |
[INFO] [stderr] 242 |         let mut buf = album.category.clone().unwrap_or("".to_string());
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:251:38
[INFO] [stderr]     |
[INFO] [stderr] 251 |              , album.catalog.clone().unwrap_or("".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:307:30
[INFO] [stderr]     |
[INFO] [stderr] 307 |     t.add_text_frame("TDRL", format!("{}", date));
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `date.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.59s
[INFO] running `"docker" "inspect" "d2c1a0c19ab945ad54133ba8111b0729cfcc820d433a344fbffad248293e0bdf"`
[INFO] running `"docker" "rm" "-f" "d2c1a0c19ab945ad54133ba8111b0729cfcc820d433a344fbffad248293e0bdf"`
[INFO] [stdout] d2c1a0c19ab945ad54133ba8111b0729cfcc820d433a344fbffad248293e0bdf