[INFO] crate vfsops 0.1.0 is already in cache [INFO] extracting crate vfsops 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/vfsops/0.1.0 [INFO] extracting crate vfsops 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vfsops/0.1.0 [INFO] validating manifest of vfsops-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vfsops-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vfsops-0.1.0 [INFO] finished frobbing vfsops-0.1.0 [INFO] frobbed toml for vfsops-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/vfsops/0.1.0/Cargo.toml [INFO] started frobbing vfsops-0.1.0 [INFO] finished frobbing vfsops-0.1.0 [INFO] frobbed toml for vfsops-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vfsops/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vfsops-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vfsops/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e5c5731067645aca3b81f42998b16a94be3a6d72663af4ea0c8d6878a53e3db [INFO] running `"docker" "start" "-a" "8e5c5731067645aca3b81f42998b16a94be3a6d72663af4ea0c8d6878a53e3db"` [INFO] [stderr] Checking kstat v0.1.0 [INFO] [stderr] Checking vfsops v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if zone.is_some() { [INFO] [stderr] 79 | | if zone.as_ref().unwrap() != *zonename { [INFO] [stderr] 80 | | continue; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if zone.is_some() && zone.as_ref().unwrap() != *zonename { [INFO] [stderr] 79 | continue; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / if !all { [INFO] [stderr] 106 | | if ten_ms == 0 && one_hundred_ms == 0 && one_second == 0 && ten_second == 0 { [INFO] [stderr] 107 | | continue; [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | if !all && ten_ms == 0 && one_hundred_ms == 0 && one_second == 0 && ten_second == 0 { [INFO] [stderr] 106 | continue; [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | / if count.is_some() { [INFO] [stderr] 186 | | if nloops >= *count.as_ref().unwrap() { [INFO] [stderr] 187 | | break; [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | if count.is_some() && nloops >= *count.as_ref().unwrap() { [INFO] [stderr] 186 | break; [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if zone.is_some() { [INFO] [stderr] 79 | | if zone.as_ref().unwrap() != *zonename { [INFO] [stderr] 80 | | continue; [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if zone.is_some() && zone.as_ref().unwrap() != *zonename { [INFO] [stderr] 79 | continue; [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / if !all { [INFO] [stderr] 106 | | if ten_ms == 0 && one_hundred_ms == 0 && one_second == 0 && ten_second == 0 { [INFO] [stderr] 107 | | continue; [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | if !all && ten_ms == 0 && one_hundred_ms == 0 && one_second == 0 && ten_second == 0 { [INFO] [stderr] 106 | continue; [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | / if count.is_some() { [INFO] [stderr] 186 | | if nloops >= *count.as_ref().unwrap() { [INFO] [stderr] 187 | | break; [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 185 | if count.is_some() && nloops >= *count.as_ref().unwrap() { [INFO] [stderr] 186 | break; [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:71:85 [INFO] [stderr] | [INFO] [stderr] 71 | fn print_stats(curr: &ZoneHash, old: &Option, zone: &Option, all: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | let zonename = &read_string(stat.data.get("zonename").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stat.data["zonename"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | let zonename = &read_string(stat.data.get("zonename").unwrap())[0..len]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stat.data["zonename"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:71:85 [INFO] [stderr] | [INFO] [stderr] 71 | fn print_stats(curr: &ZoneHash, old: &Option, zone: &Option, all: &bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | let zonename = &read_string(stat.data.get("zonename").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stat.data["zonename"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | let zonename = &read_string(stat.data.get("zonename").unwrap())[0..len]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stat.data["zonename"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.13s [INFO] running `"docker" "inspect" "8e5c5731067645aca3b81f42998b16a94be3a6d72663af4ea0c8d6878a53e3db"` [INFO] running `"docker" "rm" "-f" "8e5c5731067645aca3b81f42998b16a94be3a6d72663af4ea0c8d6878a53e3db"` [INFO] [stdout] 8e5c5731067645aca3b81f42998b16a94be3a6d72663af4ea0c8d6878a53e3db