[INFO] crate version-lp 0.2.0 is already in cache [INFO] extracting crate version-lp 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/version-lp/0.2.0 [INFO] extracting crate version-lp 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version-lp/0.2.0 [INFO] validating manifest of version-lp-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of version-lp-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing version-lp-0.2.0 [INFO] finished frobbing version-lp-0.2.0 [INFO] frobbed toml for version-lp-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/version-lp/0.2.0/Cargo.toml [INFO] started frobbing version-lp-0.2.0 [INFO] finished frobbing version-lp-0.2.0 [INFO] frobbed toml for version-lp-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version-lp/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting version-lp-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/version-lp/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b23708ced258ac22c695bbb6244849d33135b38448a012361e6b0ad75572ca1d [INFO] running `"docker" "start" "-a" "b23708ced258ac22c695bbb6244849d33135b38448a012361e6b0ad75572ca1d"` [INFO] [stderr] Checking serde_test v1.0.85 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking version-lp v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:103:19 [INFO] [stderr] | [INFO] [stderr] 103 | Version { parts : parts } [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | parts : parts [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | parts : parts [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:103:19 [INFO] [stderr] | [INFO] [stderr] 103 | Version { parts : parts } [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:127:25 [INFO] [stderr] | [INFO] [stderr] 127 | parts : parts [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/version.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | parts : parts [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | &VersionPart::Number(_) => { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | &VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | &VersionPart::Number(_) => { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:22:38 [INFO] [stderr] | [INFO] [stderr] 22 | &VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return v1.parts.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v1.parts.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | return v2.parts.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v2.parts.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/version.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | / if list[i].is_compatible_with(&self) { [INFO] [stderr] 195 | | if &list[latest] < &list[i] { [INFO] [stderr] 196 | | latest = i; [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | if list[i].is_compatible_with(&self) && &list[latest] < &list[i] { [INFO] [stderr] 195 | latest = i; [INFO] [stderr] 196 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return rendered_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rendered_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return rendered_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rendered_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | &VersionPart::Number(_) => { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | &VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | &VersionPart::Number(_) => { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/versionpart.rs:22:38 [INFO] [stderr] | [INFO] [stderr] 22 | &VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | return v1.parts.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v1.parts.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | return v2.parts.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v2.parts.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/version.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | / if list[i].is_compatible_with(&self) { [INFO] [stderr] 195 | | if &list[latest] < &list[i] { [INFO] [stderr] 196 | | latest = i; [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 194 | if list[i].is_compatible_with(&self) && &list[latest] < &list[i] { [INFO] [stderr] 195 | latest = i; [INFO] [stderr] 196 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return rendered_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rendered_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/version.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return rendered_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rendered_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/versionpart.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Hash,Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/versionpart.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27| / impl PartialEq for VersionPart { [INFO] [stderr] 28| | fn eq(&self, other: &VersionPart) -> bool { [INFO] [stderr] 29| | //! equals is only for numbers, not pattern matching [INFO] [stderr] 30| | [INFO] [stderr] ... | [INFO] [stderr] 38| | } [INFO] [stderr] 39| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &VersionPart::Number(_) => { return true; } [INFO] [stderr] 16 | | &VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | VersionPart::Number(_) => { return true; } [INFO] [stderr] 16 | VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &VersionPart::Number(_) => { return false; } [INFO] [stderr] 22 | | &VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | VersionPart::Number(_) => { return false; } [INFO] [stderr] 22 | VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / if let &VersionPart::Number(a) = self { [INFO] [stderr] 32 | | if let &VersionPart::Number(b) = other { [INFO] [stderr] 33 | | return a == b; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | if let VersionPart::Number(a) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / if let &VersionPart::Number(b) = other { [INFO] [stderr] 33 | | return a == b; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | if let VersionPart::Number(b) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / if let &VersionPart::Number(ref s) = self { [INFO] [stderr] 52 | | if let &VersionPart::Number(ref o) = other { [INFO] [stderr] 53 | | return s.cmp(o); [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | if let VersionPart::Number(ref s) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &VersionPart::Number(ref o) = other { [INFO] [stderr] 53 | | return s.cmp(o); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | if let VersionPart::Number(ref o) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &VersionPart::Number(ref num) => { write!(f,"{}",num) } [INFO] [stderr] 71 | | &VersionPart::Wildcard(ref string) => { write!(f,"{}",string) } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | VersionPart::Number(ref num) => { write!(f,"{}",num) } [INFO] [stderr] 71 | VersionPart::Wildcard(ref string) => { write!(f,"{}",string) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/version.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/version.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / impl PartialEq for Version { [INFO] [stderr] 21 | | fn eq(&self, other: &Version) -> bool { [INFO] [stderr] 22 | | //! in order for a version to be equal all the parts need to be equal. [INFO] [stderr] 23 | | //! and all parts need to be numbers `==` comparisons will always yield [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `numbers`. [INFO] [stderr] --> src/version.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | for i in 0 .. numbers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 99 | for in &numbers { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / pub fn from_str(version : &str) -> Option { [INFO] [stderr] 113 | | //! creates a version from a string [INFO] [stderr] 114 | | [INFO] [stderr] 115 | | let re = Regex::new(VERSION_REGEX_STRING).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | if parts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / pub fn clone(&self) -> Version { [INFO] [stderr] 147 | | //! creates a disconnected copy [INFO] [stderr] 148 | | Version::from_str(&self.to_string()).unwrap() [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | pub fn from_latest_vec(list : &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/version.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if list_of_versions.len() <= 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using list_of_versions.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn latest_compatible<'a>(&self,list : &'a Vec) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if list.len() > 0 { Some(&list[latest]) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:191:55 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn latest_compatible_version<'a>(&self,list : &'a Vec) -> Option<&'a Version> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | if list.len() > 0 { Some(&list[latest]) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `version-lp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/versionpart.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Hash,Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/versionpart.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27| / impl PartialEq for VersionPart { [INFO] [stderr] 28| | fn eq(&self, other: &VersionPart) -> bool { [INFO] [stderr] 29| | //! equals is only for numbers, not pattern matching [INFO] [stderr] 30| | [INFO] [stderr] ... | [INFO] [stderr] 38| | } [INFO] [stderr] 39| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &VersionPart::Number(_) => { return true; } [INFO] [stderr] 16 | | &VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | VersionPart::Number(_) => { return true; } [INFO] [stderr] 16 | VersionPart::Wildcard(_) => { return false; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match self { [INFO] [stderr] 21 | | &VersionPart::Number(_) => { return false; } [INFO] [stderr] 22 | | &VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | VersionPart::Number(_) => { return false; } [INFO] [stderr] 22 | VersionPart::Wildcard(_) => { return true; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / if let &VersionPart::Number(a) = self { [INFO] [stderr] 32 | | if let &VersionPart::Number(b) = other { [INFO] [stderr] 33 | | return a == b; [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | if let VersionPart::Number(a) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:32:7 [INFO] [stderr] | [INFO] [stderr] 32 | / if let &VersionPart::Number(b) = other { [INFO] [stderr] 33 | | return a == b; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | if let VersionPart::Number(b) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / if let &VersionPart::Number(ref s) = self { [INFO] [stderr] 52 | | if let &VersionPart::Number(ref o) = other { [INFO] [stderr] 53 | | return s.cmp(o); [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | if let VersionPart::Number(ref s) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | / if let &VersionPart::Number(ref o) = other { [INFO] [stderr] 53 | | return s.cmp(o); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | if let VersionPart::Number(ref o) = *other { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/versionpart.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &VersionPart::Number(ref num) => { write!(f,"{}",num) } [INFO] [stderr] 71 | | &VersionPart::Wildcard(ref string) => { write!(f,"{}",string) } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | VersionPart::Number(ref num) => { write!(f,"{}",num) } [INFO] [stderr] 71 | VersionPart::Wildcard(ref string) => { write!(f,"{}",string) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/version.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/version.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / impl PartialEq for Version { [INFO] [stderr] 21 | | fn eq(&self, other: &Version) -> bool { [INFO] [stderr] 22 | | //! in order for a version to be equal all the parts need to be equal. [INFO] [stderr] 23 | | //! and all parts need to be numbers `==` comparisons will always yield [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `numbers`. [INFO] [stderr] --> src/version.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | for i in 0 .. numbers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 99 | for in &numbers { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | / pub fn from_str(version : &str) -> Option { [INFO] [stderr] 113 | | //! creates a version from a string [INFO] [stderr] 114 | | [INFO] [stderr] 115 | | let re = Regex::new(VERSION_REGEX_STRING).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | if parts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name [INFO] [stderr] --> src/version.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / pub fn clone(&self) -> Version { [INFO] [stderr] 147 | | //! creates a disconnected copy [INFO] [stderr] 148 | | Version::from_str(&self.to_string()).unwrap() [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | pub fn from_latest_vec(list : &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/version.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if list_of_versions.len() <= 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using list_of_versions.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn latest_compatible<'a>(&self,list : &'a Vec) -> Option<&'a str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if list.len() > 0 { Some(&list[latest]) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/version.rs:191:55 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn latest_compatible_version<'a>(&self,list : &'a Vec) -> Option<&'a Version> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Version]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/version.rs:201:12 [INFO] [stderr] | [INFO] [stderr] 201 | if list.len() > 0 { Some(&list[latest]) } else { None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `version-lp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b23708ced258ac22c695bbb6244849d33135b38448a012361e6b0ad75572ca1d"` [INFO] running `"docker" "rm" "-f" "b23708ced258ac22c695bbb6244849d33135b38448a012361e6b0ad75572ca1d"` [INFO] [stdout] b23708ced258ac22c695bbb6244849d33135b38448a012361e6b0ad75572ca1d