[INFO] crate version 3.0.0 is already in cache [INFO] extracting crate version 3.0.0 into work/ex/clippy-test-run/sources/stable/reg/version/3.0.0 [INFO] extracting crate version 3.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version/3.0.0 [INFO] validating manifest of version-3.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of version-3.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing version-3.0.0 [INFO] finished frobbing version-3.0.0 [INFO] frobbed toml for version-3.0.0 written to work/ex/clippy-test-run/sources/stable/reg/version/3.0.0/Cargo.toml [INFO] started frobbing version-3.0.0 [INFO] finished frobbing version-3.0.0 [INFO] frobbed toml for version-3.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/version/3.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting version-3.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/version/3.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c88216120ecc99e2b6738ea264ae3059c5330607910ab99d3983d85ddbbf8137 [INFO] running `"docker" "start" "-a" "c88216120ecc99e2b6738ea264ae3059c5330607910ab99d3983d85ddbbf8137"` [INFO] [stderr] Checking version v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match part { [INFO] [stderr] 36 | | &Err( err ) => [INFO] [stderr] 37 | | return [INFO] [stderr] 38 | | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 39 | | , err ) ), [INFO] [stderr] 40 | | _ => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let &Err( err ) = part { return [INFO] [stderr] 36 | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 37 | , err ) ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match part { [INFO] [stderr] 36 | | &Err( err ) => [INFO] [stderr] 37 | | return [INFO] [stderr] 38 | | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 39 | | , err ) ), [INFO] [stderr] 40 | | _ => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *part { [INFO] [stderr] 36 | Err( err ) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match part { [INFO] [stderr] 36 | | &Err( err ) => [INFO] [stderr] 37 | | return [INFO] [stderr] 38 | | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 39 | | , err ) ), [INFO] [stderr] 40 | | _ => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let &Err( err ) = part { return [INFO] [stderr] 36 | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 37 | , err ) ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:35:7 [INFO] [stderr] | [INFO] [stderr] 35 | / match part { [INFO] [stderr] 36 | | &Err( err ) => [INFO] [stderr] 37 | | return [INFO] [stderr] 38 | | Err( format!( "Invalid version format: expected integer, got '{}'." [INFO] [stderr] 39 | | , err ) ), [INFO] [stderr] 40 | | _ => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *part { [INFO] [stderr] 36 | Err( err ) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "c88216120ecc99e2b6738ea264ae3059c5330607910ab99d3983d85ddbbf8137"` [INFO] running `"docker" "rm" "-f" "c88216120ecc99e2b6738ea264ae3059c5330607910ab99d3983d85ddbbf8137"` [INFO] [stdout] c88216120ecc99e2b6738ea264ae3059c5330607910ab99d3983d85ddbbf8137