[INFO] crate verbal_expressions 0.1.0 is already in cache [INFO] extracting crate verbal_expressions 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/verbal_expressions/0.1.0 [INFO] extracting crate verbal_expressions 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/verbal_expressions/0.1.0 [INFO] validating manifest of verbal_expressions-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of verbal_expressions-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing verbal_expressions-0.1.0 [INFO] finished frobbing verbal_expressions-0.1.0 [INFO] frobbed toml for verbal_expressions-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/verbal_expressions/0.1.0/Cargo.toml [INFO] started frobbing verbal_expressions-0.1.0 [INFO] finished frobbing verbal_expressions-0.1.0 [INFO] frobbed toml for verbal_expressions-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/verbal_expressions/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting verbal_expressions-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/verbal_expressions/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b780bf4036aa62d208d297d5cfe724d078b1feadcd7bca79028f4b51fa370154 [INFO] running `"docker" "start" "-a" "b780bf4036aa62d208d297d5cfe724d078b1feadcd7bca79028f4b51fa370154"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/verbal_expressions.rs` was erroneously implicitly accepted for library `verbal_expressions`, [INFO] [stderr] please rename the file to `src/lib.rs` or set lib.path in Cargo.toml [INFO] [stderr] Checking verbal_expressions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/verbal_expressions.rs:17:45 [INFO] [stderr] | [INFO] [stderr] 17 | Verex { prefix: prefix, source: source, suffix: suffix } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Verex` [INFO] [stderr] --> src/verbal_expressions.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Verex { [INFO] [stderr] 21 | | Verex::from(String::new(), String::new(), String::new()) [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/verbal_expressions.rs:172:37 [INFO] [stderr] | [INFO] [stderr] 172 | let p = if self.prefix.contains("(") { "" } else { "(" }; [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/verbal_expressions.rs:173:37 [INFO] [stderr] | [INFO] [stderr] 173 | let s = if self.suffix.contains(")") { "" } else { ")" }; [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:189:19 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn is_match(self, text: &str) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn as_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn as_regex(self) -> Regex { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Verex` [INFO] [stderr] --> src/verbal_expressions.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Verex { [INFO] [stderr] 21 | | Verex::from(String::new(), String::new(), String::new()) [INFO] [stderr] 22 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/verbal_expressions.rs:172:37 [INFO] [stderr] | [INFO] [stderr] 172 | let p = if self.prefix.contains("(") { "" } else { "(" }; [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/verbal_expressions.rs:173:37 [INFO] [stderr] | [INFO] [stderr] 173 | let s = if self.suffix.contains(")") { "" } else { ")" }; [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:189:19 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn is_match(self, text: &str) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn as_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/verbal_expressions.rs:212:19 [INFO] [stderr] | [INFO] [stderr] 212 | pub fn as_regex(self) -> Regex { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.56s [INFO] running `"docker" "inspect" "b780bf4036aa62d208d297d5cfe724d078b1feadcd7bca79028f4b51fa370154"` [INFO] running `"docker" "rm" "-f" "b780bf4036aa62d208d297d5cfe724d078b1feadcd7bca79028f4b51fa370154"` [INFO] [stdout] b780bf4036aa62d208d297d5cfe724d078b1feadcd7bca79028f4b51fa370154