[INFO] crate vent 0.1.0 is already in cache [INFO] extracting crate vent 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/vent/0.1.0 [INFO] extracting crate vent 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vent/0.1.0 [INFO] validating manifest of vent-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vent-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vent-0.1.0 [INFO] finished frobbing vent-0.1.0 [INFO] frobbed toml for vent-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/vent/0.1.0/Cargo.toml [INFO] started frobbing vent-0.1.0 [INFO] finished frobbing vent-0.1.0 [INFO] frobbed toml for vent-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vent/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vent-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vent/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80f904fbee36c7509183e01a2675b38e037070190d741fdd8c16395cdb349d4b [INFO] running `"docker" "start" "-a" "80f904fbee36c7509183e01a2675b38e037070190d741fdd8c16395cdb349d4b"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking vent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kvm/machine/mod.rs:28:56 [INFO] [stderr] | [INFO] [stderr] 28 | let mut clock = sys::ClockData { clock: 0, flags: flags, _pad: [0; 9] }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kvm/machine/mod.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | let clock = sys::ClockData { clock: clock, flags: 0, _pad: [0; 9] }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `clock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kvm/machine/mod.rs:28:56 [INFO] [stderr] | [INFO] [stderr] 28 | let mut clock = sys::ClockData { clock: 0, flags: flags, _pad: [0; 9] }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kvm/machine/mod.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | let clock = sys::ClockData { clock: clock, flags: 0, _pad: [0; 9] }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `clock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate serde_derive; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/kvm/sys/structs.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | pub const KVM_MEM_LOG_DIRTY_PAGES: u32 = 1u32 << 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kvm/system/mod.rs:22:52 [INFO] [stderr] | [INFO] [stderr] 22 | unsafe { sys::kvm_create_vm(self.0, 0).map(|v| Machine(v)) } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/kvm/system/mod.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | let blist: *mut sys::MsrList = transmute(raw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `raw as *mut kvm::sys::structs::MsrList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kvm/machine/mod.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | unsafe { sys::kvm_create_vcpu(self.0, id).map(|v| Core(v)) } [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1u32` [INFO] [stderr] --> src/kvm/sys/structs.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | pub const KVM_MEM_LOG_DIRTY_PAGES: u32 = 1u32 << 0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kvm/system/mod.rs:22:52 [INFO] [stderr] | [INFO] [stderr] 22 | unsafe { sys::kvm_create_vm(self.0, 0).map(|v| Machine(v)) } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/kvm/system/mod.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | let blist: *mut sys::MsrList = transmute(raw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `raw as *mut kvm::sys::structs::MsrList` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kvm/machine/mod.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | unsafe { sys::kvm_create_vcpu(self.0, id).map(|v| Core(v)) } [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.23s [INFO] running `"docker" "inspect" "80f904fbee36c7509183e01a2675b38e037070190d741fdd8c16395cdb349d4b"` [INFO] running `"docker" "rm" "-f" "80f904fbee36c7509183e01a2675b38e037070190d741fdd8c16395cdb349d4b"` [INFO] [stdout] 80f904fbee36c7509183e01a2675b38e037070190d741fdd8c16395cdb349d4b