[INFO] crate vegas-rs 0.1.0 is already in cache [INFO] extracting crate vegas-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/vegas-rs/0.1.0 [INFO] extracting crate vegas-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vegas-rs/0.1.0 [INFO] validating manifest of vegas-rs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vegas-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vegas-rs-0.1.0 [INFO] finished frobbing vegas-rs-0.1.0 [INFO] frobbed toml for vegas-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/vegas-rs/0.1.0/Cargo.toml [INFO] started frobbing vegas-rs-0.1.0 [INFO] finished frobbing vegas-rs-0.1.0 [INFO] frobbed toml for vegas-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vegas-rs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vegas-rs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vegas-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fc7c48d0e7aaab91cbe329666e1f28df826e758bb1e0222691ade3993fa6d28 [INFO] running `"docker" "start" "-a" "0fc7c48d0e7aaab91cbe329666e1f28df826e758bb1e0222691ade3993fa6d28"` [INFO] [stderr] Checking vegas-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/lattice.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | Adjacency { lims: lims, nbhs: nbhs, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/lattice.rs:353:33 [INFO] [stderr] | [INFO] [stderr] 353 | Adjacency { lims: lims, nbhs: nbhs, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `nbhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/energy.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | ExchangeComponent { adjacency: adjacency } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/integrator.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | MetropolisIntegrator { temp: temp } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/lattice.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | Adjacency { lims: lims, nbhs: nbhs, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `lims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/lattice.rs:353:33 [INFO] [stderr] | [INFO] [stderr] 353 | Adjacency { lims: lims, nbhs: nbhs, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `nbhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/energy.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | ExchangeComponent { adjacency: adjacency } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vegas/integrator.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | MetropolisIntegrator { temp: temp } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `state::StateConstructors` [INFO] [stderr] --> src/vegas/integrator.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use state::StateConstructors; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Locator` [INFO] [stderr] --> src/vegas/lattice.rs:367:1 [INFO] [stderr] | [INFO] [stderr] 367 | struct Locator { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `locate` [INFO] [stderr] --> src/vegas/lattice.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | fn locate(&self, site: &Site) -> Option<(f64, f64, f64)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `for_cubic` [INFO] [stderr] --> src/vegas/lattice.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn for_cubic(a: f64) -> Locator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vegas/lattice.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if !(site.atom < self.natoms) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `site.atom >= self.natoms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | self.shape.0 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | self.shape.1 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.shape.2 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lattice::LatticeBuilder` [INFO] [stderr] --> src/vegas/lattice.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn new() -> LatticeBuilder { [INFO] [stderr] 122 | | LatticeBuilder { [INFO] [stderr] 123 | | pbc: (true, true, true), [INFO] [stderr] 124 | | shape: (10u32, 10u32, 10u32), [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vegas/lattice.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | self.cur_at = self.cur_at + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur_at += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:34 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:44 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vegas/lattice.rs:349:24 [INFO] [stderr] | [INFO] [stderr] 349 | let last = lims.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lims.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vegas/lattice.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> { [INFO] [stderr] 357 | | if item >= self.lims.len() - 1 { [INFO] [stderr] 358 | | return None [INFO] [stderr] 359 | | } [INFO] [stderr] ... | [INFO] [stderr] 362 | | Some(&self.nbhs[low..hi]) [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/energy.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | fn energy(&self, state: &State, index: usize) -> f64; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/energy.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | fn total_energy(&self, state: &State) -> f64 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/integrator.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | fn step(&self, energy: &T, state: &State) -> State; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `state::StateConstructors` [INFO] [stderr] --> src/vegas/integrator.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use state::StateConstructors; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Locator` [INFO] [stderr] --> src/vegas/lattice.rs:367:1 [INFO] [stderr] | [INFO] [stderr] 367 | struct Locator { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `locate` [INFO] [stderr] --> src/vegas/lattice.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | fn locate(&self, site: &Site) -> Option<(f64, f64, f64)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `for_cubic` [INFO] [stderr] --> src/vegas/lattice.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | pub fn for_cubic(a: f64) -> Locator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vegas/lattice.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if !(site.atom < self.natoms) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `site.atom >= self.natoms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | self.shape.0 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | self.shape.1 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | self.shape.2 as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.shape.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `lattice::LatticeBuilder` [INFO] [stderr] --> src/vegas/lattice.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn new() -> LatticeBuilder { [INFO] [stderr] 122 | | LatticeBuilder { [INFO] [stderr] 123 | | pbc: (true, true, true), [INFO] [stderr] 124 | | shape: (10u32, 10u32, 10u32), [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vegas/lattice.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | self.cur_at = self.cur_at + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur_at += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:34 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/vegas/lattice.rs:234:44 [INFO] [stderr] | [INFO] [stderr] 234 | cell: (x as i64, y as i64, z as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/vegas/lattice.rs:349:24 [INFO] [stderr] | [INFO] [stderr] 349 | let last = lims.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lims.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/vegas/lattice.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> { [INFO] [stderr] 357 | | if item >= self.lims.len() - 1 { [INFO] [stderr] 358 | | return None [INFO] [stderr] 359 | | } [INFO] [stderr] ... | [INFO] [stderr] 362 | | Some(&self.nbhs[low..hi]) [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/energy.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | fn energy(&self, state: &State, index: usize) -> f64; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/energy.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | fn total_energy(&self, state: &State) -> f64 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vegas/integrator.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | fn step(&self, energy: &T, state: &State) -> State; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "0fc7c48d0e7aaab91cbe329666e1f28df826e758bb1e0222691ade3993fa6d28"` [INFO] running `"docker" "rm" "-f" "0fc7c48d0e7aaab91cbe329666e1f28df826e758bb1e0222691ade3993fa6d28"` [INFO] [stdout] 0fc7c48d0e7aaab91cbe329666e1f28df826e758bb1e0222691ade3993fa6d28