[INFO] crate vegas-lattice 0.3.0 is already in cache
[INFO] extracting crate vegas-lattice 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/vegas-lattice/0.3.0
[INFO] extracting crate vegas-lattice 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vegas-lattice/0.3.0
[INFO] validating manifest of vegas-lattice-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vegas-lattice-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vegas-lattice-0.3.0
[INFO] finished frobbing vegas-lattice-0.3.0
[INFO] frobbed toml for vegas-lattice-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/vegas-lattice/0.3.0/Cargo.toml
[INFO] started frobbing vegas-lattice-0.3.0
[INFO] finished frobbing vegas-lattice-0.3.0
[INFO] frobbed toml for vegas-lattice-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vegas-lattice/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vegas-lattice-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vegas-lattice/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d99e86dc95b958a827c3b44517da84550070a5c1b98b07a72ecad26b8e36dc1a
[INFO] running `"docker" "start" "-a" "d99e86dc95b958a827c3b44517da84550070a5c1b98b07a72ecad26b8e36dc1a"`
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking vegas-lattice v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/io.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             max_indent: max_indent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_indent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mask.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |                ppu: ppu,
[INFO] [stderr]    |                ^^^^^^^^ help: replace it with: `ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/alloy.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 weight: weight,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/alloy.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |         Self { items: items, }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/io.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             max_indent: max_indent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_indent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mask.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |                ppu: ppu,
[INFO] [stderr]    |                ^^^^^^^^ help: replace it with: `ppu`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/alloy.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 weight: weight,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `weight`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/alloy.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |         Self { items: items, }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/error.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 | /         match self {
[INFO] [stderr] 37 | |             &LatticeError::JsonParseError(ref err) => Some(err),
[INFO] [stderr] 38 | |             _ => None,
[INFO] [stderr] 39 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 36 |         match *self {
[INFO] [stderr] 37 |             LatticeError::JsonParseError(ref err) => Some(err),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/util.rs:13:16
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn map<'a>(prefix: Option<String>) -> Vec<(String, Axis)> {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lattice.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     pub fn sites<'a> (&'a self) -> &'a [Site] {
[INFO] [stderr] 32 | |         &self.sites
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lattice.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn vertices<'a> (&'a self) -> &'a [Vertex] {
[INFO] [stderr] 36 | |         &self.vertices
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lattice.rs:141:22
[INFO] [stderr]     |
[INFO] [stderr] 141 |             .map_err(|err| LatticeError::JsonParseError(err))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LatticeError::JsonParseError`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/mask.rs:37:20
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let prob = alpha as f64 / 255.0;
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: try: `f64::from(alpha)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/error.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 | /         match self {
[INFO] [stderr] 37 | |             &LatticeError::JsonParseError(ref err) => Some(err),
[INFO] [stderr] 38 | |             _ => None,
[INFO] [stderr] 39 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 36 |         match *self {
[INFO] [stderr] 37 |             LatticeError::JsonParseError(ref err) => Some(err),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/util.rs:13:16
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn map<'a>(prefix: Option<String>) -> Vec<(String, Axis)> {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/vertex.rs:101:37
[INFO] [stderr]     |
[INFO] [stderr] 101 |         let vertex = vertex.reindex(&vec![1, 0]);
[INFO] [stderr]     |                                     ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lattice.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     pub fn sites<'a> (&'a self) -> &'a [Site] {
[INFO] [stderr] 32 | |         &self.sites
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lattice.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn vertices<'a> (&'a self) -> &'a [Vertex] {
[INFO] [stderr] 36 | |         &self.vertices
[INFO] [stderr] 37 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lattice.rs:141:22
[INFO] [stderr]     |
[INFO] [stderr] 141 |             .map_err(|err| LatticeError::JsonParseError(err))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LatticeError::JsonParseError`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lattice.rs:197:17
[INFO] [stderr]     |
[INFO] [stderr] 197 |         assert!(lattice.vertices.len() == 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lattice.vertices.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/mask.rs:37:20
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let prob = alpha as f64 / 255.0;
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: try: `f64::from(alpha)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:14:15
[INFO] [stderr]    |
[INFO] [stderr] 14 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     match res {
[INFO] [stderr] 60 | |         Err(e) => {
[INFO] [stderr] 61 | |             eprintln!("Error: {}", e.description());
[INFO] [stderr] 62 | |             match e.cause() {
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |         _ => {},
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if let Err(e) = res {
[INFO] [stderr] 60 |     eprintln!("Error: {}", e.description());
[INFO] [stderr] 61 |     match e.cause() {
[INFO] [stderr] 62 |         Some(cause) => eprintln!("Cause: {}", cause),
[INFO] [stderr] 63 |         _ => ()
[INFO] [stderr] 64 |     };
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match e.cause() {
[INFO] [stderr] 63 | |                 Some(cause) => eprintln!("Cause: {}", cause),
[INFO] [stderr] 64 | |                 _ => ()
[INFO] [stderr] 65 | |             };
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(cause) = e.cause() { eprintln!("Cause: {}", cause) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     match res {
[INFO] [stderr] 60 | |         Err(e) => {
[INFO] [stderr] 61 | |             eprintln!("Error: {}", e.description());
[INFO] [stderr] 62 | |             match e.cause() {
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |         _ => {},
[INFO] [stderr] 69 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if let Err(e) = res {
[INFO] [stderr] 60 |     eprintln!("Error: {}", e.description());
[INFO] [stderr] 61 |     match e.cause() {
[INFO] [stderr] 62 |         Some(cause) => eprintln!("Cause: {}", cause),
[INFO] [stderr] 63 |         _ => ()
[INFO] [stderr] 64 |     };
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 | /             match e.cause() {
[INFO] [stderr] 63 | |                 Some(cause) => eprintln!("Cause: {}", cause),
[INFO] [stderr] 64 | |                 _ => ()
[INFO] [stderr] 65 | |             };
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(cause) = e.cause() { eprintln!("Cause: {}", cause) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.13s
[INFO] running `"docker" "inspect" "d99e86dc95b958a827c3b44517da84550070a5c1b98b07a72ecad26b8e36dc1a"`
[INFO] running `"docker" "rm" "-f" "d99e86dc95b958a827c3b44517da84550070a5c1b98b07a72ecad26b8e36dc1a"`
[INFO] [stdout] d99e86dc95b958a827c3b44517da84550070a5c1b98b07a72ecad26b8e36dc1a