[INFO] crate vectors 0.3.0 is already in cache
[INFO] extracting crate vectors 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/vectors/0.3.0
[INFO] extracting crate vectors 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vectors/0.3.0
[INFO] validating manifest of vectors-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vectors-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vectors-0.3.0
[INFO] finished frobbing vectors-0.3.0
[INFO] frobbed toml for vectors-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/vectors/0.3.0/Cargo.toml
[INFO] started frobbing vectors-0.3.0
[INFO] finished frobbing vectors-0.3.0
[INFO] frobbed toml for vectors-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vectors/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vectors-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vectors/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 002594d8f23362a30fee2b0741100c778e033e37c0a506a020019dc8ff0a7296
[INFO] running `"docker" "start" "-a" "002594d8f23362a30fee2b0741100c778e033e37c0a506a020019dc8ff0a7296"`
[INFO] [stderr]    Compiling arrayvec v0.4.10
[INFO] [stderr]     Checking bit-set v0.5.0
[INFO] [stderr]     Checking expectest v0.9.2
[INFO] [stderr]     Checking ordered_iter v0.1.1
[INFO] [stderr]     Checking vectors v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/dense/iter.rs:80:38
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Iter { index: 0, inner: iter.into_iter() }
[INFO] [stderr]    |                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/dense/stack/mod.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 55 | |         Iter::new(&self.components[..])
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/dense/heap/mod.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 49 | |         Iter::new(&self.components[..])
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/sparse/iter.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 |         Iter { inner: iter.into_iter() }
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/sparse/iter.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         self.inner.next().map(|pair| *pair)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inner.next().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/sparse/stack/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 56 | |         Iter::new(&self.components[..])
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/sparse/heap/mod.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 50 | |         Iter::new(&self.components[..])
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/dense/iter.rs:80:38
[INFO] [stderr]    |
[INFO] [stderr] 80 |         Iter { index: 0, inner: iter.into_iter() }
[INFO] [stderr]    |                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/dense/stack/iter.rs:70:41
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let subject = DenseVector::from(values.clone());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^ help: try removing the `clone` call: `values`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/dense/stack/mod.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 55 | |         Iter::new(&self.components[..])
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/dense/stack/mod.rs:132:41
[INFO] [stderr]     |
[INFO] [stderr] 132 |         let subject = DenseVector::from(VALUES.clone());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^ help: try removing the `clone` call: `VALUES`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/dense/heap/mod.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 49 | |         Iter::new(&self.components[..])
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/sparse/iter.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 |         Iter { inner: iter.into_iter() }
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/sparse/iter.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         self.inner.next().map(|pair| *pair)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inner.next().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/sparse/stack/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 56 | |         Iter::new(&self.components[..])
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/sparse/stack/mod.rs:123:42
[INFO] [stderr]     |
[INFO] [stderr] 123 |         let subject = SparseVector::from(VALUES.clone());
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: try removing the `clone` call: `VALUES`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/sparse/heap/mod.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 50 | |         Iter::new(&self.components[..])
[INFO] [stderr] 51 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.53s
[INFO] running `"docker" "inspect" "002594d8f23362a30fee2b0741100c778e033e37c0a506a020019dc8ff0a7296"`
[INFO] running `"docker" "rm" "-f" "002594d8f23362a30fee2b0741100c778e033e37c0a506a020019dc8ff0a7296"`
[INFO] [stdout] 002594d8f23362a30fee2b0741100c778e033e37c0a506a020019dc8ff0a7296