[INFO] crate veclist 0.1.2 is already in cache [INFO] extracting crate veclist 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/veclist/0.1.2 [INFO] extracting crate veclist 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/veclist/0.1.2 [INFO] validating manifest of veclist-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of veclist-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing veclist-0.1.2 [INFO] finished frobbing veclist-0.1.2 [INFO] frobbed toml for veclist-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/veclist/0.1.2/Cargo.toml [INFO] started frobbing veclist-0.1.2 [INFO] finished frobbing veclist-0.1.2 [INFO] frobbed toml for veclist-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/veclist/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting veclist-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/veclist/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc863f7f5e1ba6045019a139a600676d10431b49dbdf3522b470e6f4ee1eb606 [INFO] running `"docker" "start" "-a" "cc863f7f5e1ba6045019a139a600676d10431b49dbdf3522b470e6f4ee1eb606"` [INFO] [stderr] Checking veclist v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match *self { [INFO] [stderr] 28 | | Node::Vacant(_) => return None, [INFO] [stderr] 29 | | _ => {} [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Node::Vacant(_) = *self { return None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match *self { [INFO] [stderr] 28 | | Node::Vacant(_) => return None, [INFO] [stderr] 29 | | _ => {} [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Node::Vacant(_) = *self { return None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `veclist` [INFO] [stderr] --> src/lib.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 6..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 163 | for (i, ) in veclist.iter().enumerate().take(10).skip(6) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `veclist` [INFO] [stderr] --> src/lib.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 184 | for (i, ) in veclist.iter().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "cc863f7f5e1ba6045019a139a600676d10431b49dbdf3522b470e6f4ee1eb606"` [INFO] running `"docker" "rm" "-f" "cc863f7f5e1ba6045019a139a600676d10431b49dbdf3522b470e6f4ee1eb606"` [INFO] [stdout] cc863f7f5e1ba6045019a139a600676d10431b49dbdf3522b470e6f4ee1eb606