[INFO] crate vec_2d 0.1.2 is already in cache
[INFO] extracting crate vec_2d 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/vec_2d/0.1.2
[INFO] extracting crate vec_2d 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec_2d/0.1.2
[INFO] validating manifest of vec_2d-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vec_2d-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vec_2d-0.1.2
[INFO] finished frobbing vec_2d-0.1.2
[INFO] frobbed toml for vec_2d-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/vec_2d/0.1.2/Cargo.toml
[INFO] started frobbing vec_2d-0.1.2
[INFO] finished frobbing vec_2d-0.1.2
[INFO] frobbed toml for vec_2d-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec_2d/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vec_2d-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vec_2d/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9c92a479d03e4d445e2308fb64db2938e31d8a82936c60cd6862e34338e5a0a3
[INFO] running `"docker" "start" "-a" "9c92a479d03e4d445e2308fb64db2938e31d8a82936c60cd6862e34338e5a0a3"`
[INFO] [stderr]     Checking vec_2d v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:12:4
[INFO] [stderr]    |
[INFO] [stderr] 12 |             x_len: x_len,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `x_len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:13:4
[INFO] [stderr]    |
[INFO] [stderr] 13 |             y_len: y_len,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `y_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:12:4
[INFO] [stderr]    |
[INFO] [stderr] 12 |             x_len: x_len,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `x_len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:13:4
[INFO] [stderr]    |
[INFO] [stderr] 13 |             y_len: y_len,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `y_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:24:3
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.x_len;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.y_len;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 return self.items.index(index);                
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.index(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:55:11
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 return self.items.index_mut(index);                
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.index_mut(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:18:3
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let result;
[INFO] [stderr]    |  _________^
[INFO] [stderr] 19 | |         if (x_index < self.x_len) && (y_index < self.y_len) {
[INFO] [stderr] 20 | |             result = Some(y_index * self.x_len + x_index);                
[INFO] [stderr] 21 | |         } else {
[INFO] [stderr] 22 | |             result = None;
[INFO] [stderr] 23 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let result = if (x_index < self.x_len) && (y_index < self.y_len) { Some(y_index * self.x_len + x_index) } else { None };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:24:3
[INFO] [stderr]    |
[INFO] [stderr] 24 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         return self.x_len;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return self.y_len;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y_len`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:40:11
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 return self.items.index(index);                
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.index(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:55:11
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 return self.items.index_mut(index);                
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items.index_mut(index)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:18:3
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let result;
[INFO] [stderr]    |  _________^
[INFO] [stderr] 19 | |         if (x_index < self.x_len) && (y_index < self.y_len) {
[INFO] [stderr] 20 | |             result = Some(y_index * self.x_len + x_index);                
[INFO] [stderr] 21 | |         } else {
[INFO] [stderr] 22 | |             result = None;
[INFO] [stderr] 23 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let result = if (x_index < self.x_len) && (y_index < self.y_len) { Some(y_index * self.x_len + x_index) } else { None };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.66s
[INFO] running `"docker" "inspect" "9c92a479d03e4d445e2308fb64db2938e31d8a82936c60cd6862e34338e5a0a3"`
[INFO] running `"docker" "rm" "-f" "9c92a479d03e4d445e2308fb64db2938e31d8a82936c60cd6862e34338e5a0a3"`
[INFO] [stdout] 9c92a479d03e4d445e2308fb64db2938e31d8a82936c60cd6862e34338e5a0a3