[INFO] crate vec2 0.2.1 is already in cache [INFO] extracting crate vec2 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/vec2/0.2.1 [INFO] extracting crate vec2 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec2/0.2.1 [INFO] validating manifest of vec2-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vec2-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vec2-0.2.1 [INFO] finished frobbing vec2-0.2.1 [INFO] frobbed toml for vec2-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/vec2/0.2.1/Cargo.toml [INFO] started frobbing vec2-0.2.1 [INFO] finished frobbing vec2-0.2.1 [INFO] frobbed toml for vec2-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec2/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vec2-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vec2/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e0c9c018adaeb1ec05f7d1cc8a6db6a87fa0b2ddc8c219c04370a333a533782 [INFO] running `"docker" "start" "-a" "5e0c9c018adaeb1ec05f7d1cc8a6db6a87fa0b2ddc8c219c04370a333a533782"` [INFO] [stderr] Checking cast_trait v0.1.2 [INFO] [stderr] Checking vec3 v0.2.1 [INFO] [stderr] Checking vec2 v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/inv.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn inv_mut<'out, T>(out: &'out mut [T; 2]) -> &'out mut [T; 2] [INFO] [stderr] 28 | | where [INFO] [stderr] 29 | | T: One + Neg, [INFO] [stderr] 30 | | for<'a> T: MulAssign<&'a T>, [INFO] [stderr] 31 | | { [INFO] [stderr] 32 | | smul_mut(out, &-T::one()) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/norm.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - &v[1] * &s; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = v[0] * c - &v[1] * &s; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - &v[1] * &s; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - v[1] * s; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + &v[1] * &c; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = v[0] * s + &v[1] * &c; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + &v[1] * &c; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + v[1] * c; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/inv.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn inv_mut<'out, T>(out: &'out mut [T; 2]) -> &'out mut [T; 2] [INFO] [stderr] 28 | | where [INFO] [stderr] 29 | | T: One + Neg, [INFO] [stderr] 30 | | for<'a> T: MulAssign<&'a T>, [INFO] [stderr] 31 | | { [INFO] [stderr] 32 | | smul_mut(out, &-T::one()) [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/norm.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - &v[1] * &s; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = v[0] * c - &v[1] * &s; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - &v[1] * &s; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 24 | out[0] = &v[0] * &c - v[1] * s; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:25:14 [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + &v[1] * &c; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = v[0] * s + &v[1] * &c; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + &v[1] * &c; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 25 | out[1] = &v[0] * &s + v[1] * c; [INFO] [stderr] | ^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.21s [INFO] running `"docker" "inspect" "5e0c9c018adaeb1ec05f7d1cc8a6db6a87fa0b2ddc8c219c04370a333a533782"` [INFO] running `"docker" "rm" "-f" "5e0c9c018adaeb1ec05f7d1cc8a6db6a87fa0b2ddc8c219c04370a333a533782"` [INFO] [stdout] 5e0c9c018adaeb1ec05f7d1cc8a6db6a87fa0b2ddc8c219c04370a333a533782