[INFO] crate vec-vp-tree 0.2.0-alpha.1 is already in cache [INFO] extracting crate vec-vp-tree 0.2.0-alpha.1 into work/ex/clippy-test-run/sources/stable/reg/vec-vp-tree/0.2.0-alpha.1 [INFO] extracting crate vec-vp-tree 0.2.0-alpha.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec-vp-tree/0.2.0-alpha.1 [INFO] validating manifest of vec-vp-tree-0.2.0-alpha.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vec-vp-tree-0.2.0-alpha.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vec-vp-tree-0.2.0-alpha.1 [INFO] finished frobbing vec-vp-tree-0.2.0-alpha.1 [INFO] frobbed toml for vec-vp-tree-0.2.0-alpha.1 written to work/ex/clippy-test-run/sources/stable/reg/vec-vp-tree/0.2.0-alpha.1/Cargo.toml [INFO] started frobbing vec-vp-tree-0.2.0-alpha.1 [INFO] finished frobbing vec-vp-tree-0.2.0-alpha.1 [INFO] frobbed toml for vec-vp-tree-0.2.0-alpha.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec-vp-tree/0.2.0-alpha.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vec-vp-tree-0.2.0-alpha.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vec-vp-tree/0.2.0-alpha.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c12f59db89973d1ea32da6340ba5eddbd676a52dfd49b1068d4eb6e255ca356 [INFO] running `"docker" "start" "-a" "8c12f59db89973d1ea32da6340ba5eddbd676a52dfd49b1068d4eb6e255ca356"` [INFO] [stderr] Checking order-stat v0.1.3 [INFO] [stderr] Checking vec-vp-tree v0.2.0-alpha.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/print.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | dist_fn: dist_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dist_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | dist_fn: dist_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dist_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | visit_kind: visit_kind, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `visit_kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/print.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | dist_fn: dist_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dist_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | dist_fn: dist_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dist_fn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | threshold: threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | visit_kind: visit_kind, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `visit_kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:476:23 [INFO] [stderr] | [INFO] [stderr] 476 | const NEIGHBORS: &'static [i32] = &[2, 3, 4, 5, 6]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/lib.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | pub fn within_radius<'t, O: Borrow>(&'t self, origin: O, radius: u64) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:286:12 [INFO] [stderr] | [INFO] [stderr] 286 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:370:46 [INFO] [stderr] | [INFO] [stderr] 370 | if self.visit_kind.should_visit() && self.tree.nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tree.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dist/num.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | dist as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(dist)` [INFO] [stderr] ... [INFO] [stderr] 65 | impl_unsigned_dist! { u8, u16, u32, u64, usize } [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:286:12 [INFO] [stderr] | [INFO] [stderr] 286 | if self.nodes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:370:46 [INFO] [stderr] | [INFO] [stderr] 370 | if self.visit_kind.should_visit() && self.tree.nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tree.nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "8c12f59db89973d1ea32da6340ba5eddbd676a52dfd49b1068d4eb6e255ca356"` [INFO] running `"docker" "rm" "-f" "8c12f59db89973d1ea32da6340ba5eddbd676a52dfd49b1068d4eb6e255ca356"` [INFO] [stdout] 8c12f59db89973d1ea32da6340ba5eddbd676a52dfd49b1068d4eb6e255ca356