[INFO] crate vec-drain-where 1.0.0 is already in cache [INFO] extracting crate vec-drain-where 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/vec-drain-where/1.0.0 [INFO] extracting crate vec-drain-where 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec-drain-where/1.0.0 [INFO] validating manifest of vec-drain-where-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vec-drain-where-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vec-drain-where-1.0.0 [INFO] finished frobbing vec-drain-where-1.0.0 [INFO] frobbed toml for vec-drain-where-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/vec-drain-where/1.0.0/Cargo.toml [INFO] started frobbing vec-drain-where-1.0.0 [INFO] finished frobbing vec-drain-where-1.0.0 [INFO] frobbed toml for vec-drain-where-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vec-drain-where/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vec-drain-where-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vec-drain-where/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb698585188e91ac585d906c7217735dbf6fad1b6b609c62b05195080f4bd1d8 [INFO] running `"docker" "start" "-a" "fb698585188e91ac585d906c7217735dbf6fad1b6b609c62b05195080f4bd1d8"` [INFO] [stderr] Checking vec-drain-where v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | let nptr = 0 as *mut _; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | let end = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:299:20 [INFO] [stderr] | [INFO] [stderr] 299 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 300 | | if res.is_err() { [INFO] [stderr] 301 | | return TestResult::error(format!( [INFO] [stderr] 302 | | "unexpectedly error? exp {}, len {}, ({:?})", [INFO] [stderr] ... | [INFO] [stderr] 305 | | } [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 299 | } else if res.is_err() { [INFO] [stderr] 300 | return TestResult::error(format!( [INFO] [stderr] 301 | "unexpectedly error? exp {}, len {}, ({:?})", [INFO] [stderr] 302 | expected_len, mask.len(), mask [INFO] [stderr] 303 | )) [INFO] [stderr] 304 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | let nptr = 0 as *mut _; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | let end = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.90s [INFO] running `"docker" "inspect" "fb698585188e91ac585d906c7217735dbf6fad1b6b609c62b05195080f4bd1d8"` [INFO] running `"docker" "rm" "-f" "fb698585188e91ac585d906c7217735dbf6fad1b6b609c62b05195080f4bd1d8"` [INFO] [stdout] fb698585188e91ac585d906c7217735dbf6fad1b6b609c62b05195080f4bd1d8