[INFO] crate veb-rs 0.1.1 is already in cache [INFO] extracting crate veb-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/veb-rs/0.1.1 [INFO] extracting crate veb-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/veb-rs/0.1.1 [INFO] validating manifest of veb-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of veb-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing veb-rs-0.1.1 [INFO] finished frobbing veb-rs-0.1.1 [INFO] frobbed toml for veb-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/veb-rs/0.1.1/Cargo.toml [INFO] started frobbing veb-rs-0.1.1 [INFO] finished frobbing veb-rs-0.1.1 [INFO] frobbed toml for veb-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/veb-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting veb-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/veb-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ede7b33817ec9300e1367185cacf4db23b45bb9688c35ba36610d3e29e92cc2 [INFO] running `"docker" "start" "-a" "6ede7b33817ec9300e1367185cacf4db23b45bb9688c35ba36610d3e29e92cc2"` [INFO] [stderr] Checking veb-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | sqrt_universe: sqrt_universe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sqrt_universe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | sqrt_universe: sqrt_universe, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sqrt_universe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:254:21 [INFO] [stderr] | [INFO] [stderr] 254 | let mut subtree = &mut self.children[idx as usize]; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / summary!(self).find_next(self.high(x)).map_or(None, |next_index| { [INFO] [stderr] 146 | | Some(self.index(next_index, subtree!(self, next_index as usize).unwrap().min)) [INFO] [stderr] 147 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 145 | summary!(self).find_next(self.high(x)).and_then(|next_index| { [INFO] [stderr] 146 | Some(self.index(next_index, subtree!(self, next_index as usize).unwrap().min)) [INFO] [stderr] 147 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:254:21 [INFO] [stderr] | [INFO] [stderr] 254 | let mut subtree = &mut self.children[idx as usize]; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / summary!(self).find_next(self.high(x)).map_or(None, |next_index| { [INFO] [stderr] 146 | | Some(self.index(next_index, subtree!(self, next_index as usize).unwrap().min)) [INFO] [stderr] 147 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 145 | summary!(self).find_next(self.high(x)).and_then(|next_index| { [INFO] [stderr] 146 | Some(self.index(next_index, subtree!(self, next_index as usize).unwrap().min)) [INFO] [stderr] 147 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "6ede7b33817ec9300e1367185cacf4db23b45bb9688c35ba36610d3e29e92cc2"` [INFO] running `"docker" "rm" "-f" "6ede7b33817ec9300e1367185cacf4db23b45bb9688c35ba36610d3e29e92cc2"` [INFO] [stdout] 6ede7b33817ec9300e1367185cacf4db23b45bb9688c35ba36610d3e29e92cc2