[INFO] crate vcstatus 0.1.0 is already in cache [INFO] extracting crate vcstatus 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/vcstatus/0.1.0 [INFO] extracting crate vcstatus 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vcstatus/0.1.0 [INFO] validating manifest of vcstatus-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vcstatus-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vcstatus-0.1.0 [INFO] finished frobbing vcstatus-0.1.0 [INFO] frobbed toml for vcstatus-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/vcstatus/0.1.0/Cargo.toml [INFO] started frobbing vcstatus-0.1.0 [INFO] finished frobbing vcstatus-0.1.0 [INFO] frobbed toml for vcstatus-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vcstatus/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vcstatus-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vcstatus/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d9cebc4ee0d0a13818bcb4b13354e54bb1b52721a4ef72e26040119ca8ae5a7 [INFO] running `"docker" "start" "-a" "6d9cebc4ee0d0a13818bcb4b13354e54bb1b52721a4ef72e26040119ca8ae5a7"` [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking vcstatus v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/git.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new(path: &Path) -> Option> { [INFO] [stderr] 31 | | if path.join(".git").exists() { [INFO] [stderr] 32 | | Some(Box::new(Git {root: path.to_path_buf()})) [INFO] [stderr] 33 | | } else { [INFO] [stderr] 34 | | None [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/git.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new(path: &Path) -> Option> { [INFO] [stderr] 31 | | if path.join(".git").exists() { [INFO] [stderr] 32 | | Some(Box::new(Git {root: path.to_path_buf()})) [INFO] [stderr] 33 | | } else { [INFO] [stderr] 34 | | None [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/vcs/git.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or( [INFO] [stderr] | ______________^ [INFO] [stderr] 94 | | Box::new(io::Error::new(io::ErrorKind::InvalidData, format!( [INFO] [stderr] 95 | | "Can't parse .git/HEAD: '{}' doesn't match '{}'.", [INFO] [stderr] 96 | | head.trim(), RE_BRANCH.as_str() [INFO] [stderr] 97 | | )))) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or_else(|| Box::new(io::Error::new(io::ErrorKind::InvalidData, format!( [INFO] [stderr] 94 | "Can't parse .git/HEAD: '{}' doesn't match '{}'.", [INFO] [stderr] 95 | head.trim(), RE_BRANCH.as_str() [INFO] [stderr] 96 | )))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/hg.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new(path: &Path) -> Option> { [INFO] [stderr] 28 | | if path.join(".hg").exists() { [INFO] [stderr] 29 | | Some(Box::new(Hg {root: path.to_path_buf()})) [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | None [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/vcs/git.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or( [INFO] [stderr] | ______________^ [INFO] [stderr] 94 | | Box::new(io::Error::new(io::ErrorKind::InvalidData, format!( [INFO] [stderr] 95 | | "Can't parse .git/HEAD: '{}' doesn't match '{}'.", [INFO] [stderr] 96 | | head.trim(), RE_BRANCH.as_str() [INFO] [stderr] 97 | | )))) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or_else(|| Box::new(io::Error::new(io::ErrorKind::InvalidData, format!( [INFO] [stderr] 94 | "Can't parse .git/HEAD: '{}' doesn't match '{}'.", [INFO] [stderr] 95 | head.trim(), RE_BRANCH.as_str() [INFO] [stderr] 96 | )))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/vcs/mod.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | static SUPPORTED_VCS: [fn (&Path) -> Option>; 2] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/vcs/hg.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new(path: &Path) -> Option> { [INFO] [stderr] 28 | | if path.join(".hg").exists() { [INFO] [stderr] 29 | | Some(Box::new(Hg {root: path.to_path_buf()})) [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | None [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/vcs/mod.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | static SUPPORTED_VCS: [fn (&Path) -> Option>; 2] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.79s [INFO] running `"docker" "inspect" "6d9cebc4ee0d0a13818bcb4b13354e54bb1b52721a4ef72e26040119ca8ae5a7"` [INFO] running `"docker" "rm" "-f" "6d9cebc4ee0d0a13818bcb4b13354e54bb1b52721a4ef72e26040119ca8ae5a7"` [INFO] [stdout] 6d9cebc4ee0d0a13818bcb4b13354e54bb1b52721a4ef72e26040119ca8ae5a7