[INFO] crate varsun 0.1.1 is already in cache
[INFO] extracting crate varsun 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/varsun/0.1.1
[INFO] extracting crate varsun 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varsun/0.1.1
[INFO] validating manifest of varsun-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of varsun-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing varsun-0.1.1
[INFO] finished frobbing varsun-0.1.1
[INFO] frobbed toml for varsun-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/varsun/0.1.1/Cargo.toml
[INFO] started frobbing varsun-0.1.1
[INFO] finished frobbing varsun-0.1.1
[INFO] frobbed toml for varsun-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varsun/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting varsun-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/varsun/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] af1497aa2042682a2dc607754c8266a208b27b6bb9881be4636e53d6a326528f
[INFO] running `"docker" "start" "-a" "af1497aa2042682a2dc607754c8266a208b27b6bb9881be4636e53d6a326528f"`
[INFO] [stderr]     Checking varsun v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/posix.rs:130:5
[INFO] [stderr]     |
[INFO] [stderr] 130 |     return dst;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/posix.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return self::substitute(src, super::envar);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, super::envar)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mswin.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return dst;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/mswin.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 61 | |             if started {
[INFO] [stderr] 62 | |                 // Part of varname.
[INFO] [stderr] 63 | |                 varname.push(ch);
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |             }
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 60 |         } else if started {
[INFO] [stderr] 61 |     // Part of varname.
[INFO] [stderr] 62 |     varname.push(ch);
[INFO] [stderr] 63 | } else {
[INFO] [stderr] 64 |     // Part of text.
[INFO] [stderr] 65 |     dst.push(ch);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mswin.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return self::substitute(src, super::envar);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, super::envar)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return self::mswin::substitute(src, mapfn);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::mswin::substitute(src, mapfn)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return self::posix::substitute(src, mapfn);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::posix::substitute(src, mapfn)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return self::substitute(src, self::envar);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, self::envar)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/posix.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |     while let Some(ch) = chs.next() {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: try: `for ch in chs { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/posix.rs:69:75
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   } else if !varname.is_empty() && (ch >= '0' && ch <= '9') {
[INFO] [stderr]    |  ___________________________________________________________________________^
[INFO] [stderr] 70 | |                     // ch is not first, allow numbers.
[INFO] [stderr] 71 | |                     varname.push(ch);
[INFO] [stderr] 72 | |                     continue;
[INFO] [stderr] 73 | |                 } else {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/posix.rs:65:88
[INFO] [stderr]    |
[INFO] [stderr] 65 |                   if (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z') || (ch == '_') {
[INFO] [stderr]    |  ________________________________________________________________________________________^
[INFO] [stderr] 66 | |                     // Alphabets or Underbar.
[INFO] [stderr] 67 | |                     varname.push(ch);
[INFO] [stderr] 68 | |                     continue;
[INFO] [stderr] 69 | |                 } else if !varname.is_empty() && (ch >= '0' && ch <= '9') {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/mswin.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |     while let Some(ch) = chs.next() {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: try: `for ch in chs { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `varsun`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/posix.rs:130:5
[INFO] [stderr]     |
[INFO] [stderr] 130 |     return dst;
[INFO] [stderr]     |     ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/posix.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return self::substitute(src, super::envar);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, super::envar)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mswin.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 |     return dst;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/mswin.rs:60:16
[INFO] [stderr]    |
[INFO] [stderr] 60 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 61 | |             if started {
[INFO] [stderr] 62 | |                 // Part of varname.
[INFO] [stderr] 63 | |                 varname.push(ch);
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |             }
[INFO] [stderr] 68 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 60 |         } else if started {
[INFO] [stderr] 61 |     // Part of varname.
[INFO] [stderr] 62 |     varname.push(ch);
[INFO] [stderr] 63 | } else {
[INFO] [stderr] 64 |     // Part of text.
[INFO] [stderr] 65 |     dst.push(ch);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mswin.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |     return self::substitute(src, super::envar);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, super::envar)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return self::mswin::substitute(src, mapfn);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::mswin::substitute(src, mapfn)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return self::posix::substitute(src, mapfn);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::posix::substitute(src, mapfn)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return self::substitute(src, self::envar);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self::substitute(src, self::envar)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/posix.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |     while let Some(ch) = chs.next() {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: try: `for ch in chs { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/posix.rs:69:75
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   } else if !varname.is_empty() && (ch >= '0' && ch <= '9') {
[INFO] [stderr]    |  ___________________________________________________________________________^
[INFO] [stderr] 70 | |                     // ch is not first, allow numbers.
[INFO] [stderr] 71 | |                     varname.push(ch);
[INFO] [stderr] 72 | |                     continue;
[INFO] [stderr] 73 | |                 } else {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/posix.rs:65:88
[INFO] [stderr]    |
[INFO] [stderr] 65 |                   if (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z') || (ch == '_') {
[INFO] [stderr]    |  ________________________________________________________________________________________^
[INFO] [stderr] 66 | |                     // Alphabets or Underbar.
[INFO] [stderr] 67 | |                     varname.push(ch);
[INFO] [stderr] 68 | |                     continue;
[INFO] [stderr] 69 | |                 } else if !varname.is_empty() && (ch >= '0' && ch <= '9') {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/mswin.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |     while let Some(ch) = chs.next() {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: try: `for ch in chs { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `varsun`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "af1497aa2042682a2dc607754c8266a208b27b6bb9881be4636e53d6a326528f"`
[INFO] running `"docker" "rm" "-f" "af1497aa2042682a2dc607754c8266a208b27b6bb9881be4636e53d6a326528f"`
[INFO] [stdout] af1497aa2042682a2dc607754c8266a208b27b6bb9881be4636e53d6a326528f