[INFO] crate varlink-cli 3.0.1 is already in cache [INFO] extracting crate varlink-cli 3.0.1 into work/ex/clippy-test-run/sources/stable/reg/varlink-cli/3.0.1 [INFO] extracting crate varlink-cli 3.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varlink-cli/3.0.1 [INFO] validating manifest of varlink-cli-3.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of varlink-cli-3.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing varlink-cli-3.0.1 [INFO] finished frobbing varlink-cli-3.0.1 [INFO] frobbed toml for varlink-cli-3.0.1 written to work/ex/clippy-test-run/sources/stable/reg/varlink-cli/3.0.1/Cargo.toml [INFO] started frobbing varlink-cli-3.0.1 [INFO] finished frobbing varlink-cli-3.0.1 [INFO] frobbed toml for varlink-cli-3.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varlink-cli/3.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting varlink-cli-3.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/varlink-cli/3.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd45807288e64065c00f638e4e5738b423ce8d857fa246984a537aa0338d53e9 [INFO] running `"docker" "start" "-a" "fd45807288e64065c00f638e4e5738b423ce8d857fa246984a537aa0338d53e9"` [INFO] [stderr] Compiling rustc-demangle v0.1.13 [INFO] [stderr] Compiling varlink_parser v2.2.2 [INFO] [stderr] Compiling itertools v0.8.0 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling iovec v0.1.2 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking colored_json v0.5.0 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Compiling bytes v0.4.11 [INFO] [stderr] Checking varlink v5.3.0 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Compiling varlink_generator v6.0.0 [INFO] [stderr] Compiling varlink_stdinterfaces v5.0.4 [INFO] [stderr] Checking varlink-cli v3.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:240:19 [INFO] [stderr] | [INFO] [stderr] 240 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match should_colorize { [INFO] [stderr] 43 | | true => println!( [INFO] [stderr] 44 | | "{}", [INFO] [stderr] 45 | | v.interface [INFO] [stderr] ... | [INFO] [stderr] 52 | | ), [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if should_colorize { println!( [INFO] [stderr] 43 | "{}", [INFO] [stderr] 44 | v.interface [INFO] [stderr] 45 | .get_multiline_colored(0, line_len.unwrap_or("80").parse::().unwrap_or(80)) [INFO] [stderr] 46 | ) } else { println!( [INFO] [stderr] 47 | "{}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | } => match should_colorize { [INFO] [stderr] | ______________^ [INFO] [stderr] 154 | | true => println!( [INFO] [stderr] 155 | | "{}", [INFO] [stderr] 156 | | Varlink::from_string(&desc)? [INFO] [stderr] ... | [INFO] [stderr] 168 | | ), [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 153 | } => if should_colorize { println!( [INFO] [stderr] 154 | "{}", [INFO] [stderr] 155 | Varlink::from_string(&desc)? [INFO] [stderr] 156 | .interface [INFO] [stderr] 157 | .get_multiline_colored( [INFO] [stderr] 158 | 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:251:22 [INFO] [stderr] | [INFO] [stderr] 251 | let color_mode = match should_colorize { [INFO] [stderr] | ______________________^ [INFO] [stderr] 252 | | true => ColorMode::On, [INFO] [stderr] 253 | | false => ColorMode::Off, [INFO] [stderr] 254 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if should_colorize { ColorMode::On } else { ColorMode::Off }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/main.rs:268:15 [INFO] [stderr] | [INFO] [stderr] 268 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:460:16 [INFO] [stderr] | [INFO] [stderr] 460 | if address.is_none() & &activate.is_none() & &bridge.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bridge.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:460:16 [INFO] [stderr] | [INFO] [stderr] 460 | if address.is_none() & &activate.is_none() & &bridge.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `activate.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:135:19 [INFO] [stderr] | [INFO] [stderr] 135 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/proxy.rs:240:19 [INFO] [stderr] | [INFO] [stderr] 240 | r.unwrap_or(Err(io::Error::from(io::ErrorKind::ConnectionAborted)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Err(io::Error::from(io::ErrorKind::ConnectionAborted)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match should_colorize { [INFO] [stderr] 43 | | true => println!( [INFO] [stderr] 44 | | "{}", [INFO] [stderr] 45 | | v.interface [INFO] [stderr] ... | [INFO] [stderr] 52 | | ), [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if should_colorize { println!( [INFO] [stderr] 43 | "{}", [INFO] [stderr] 44 | v.interface [INFO] [stderr] 45 | .get_multiline_colored(0, line_len.unwrap_or("80").parse::().unwrap_or(80)) [INFO] [stderr] 46 | ) } else { println!( [INFO] [stderr] 47 | "{}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:153:14 [INFO] [stderr] | [INFO] [stderr] 153 | } => match should_colorize { [INFO] [stderr] | ______________^ [INFO] [stderr] 154 | | true => println!( [INFO] [stderr] 155 | | "{}", [INFO] [stderr] 156 | | Varlink::from_string(&desc)? [INFO] [stderr] ... | [INFO] [stderr] 168 | | ), [INFO] [stderr] 169 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 153 | } => if should_colorize { println!( [INFO] [stderr] 154 | "{}", [INFO] [stderr] 155 | Varlink::from_string(&desc)? [INFO] [stderr] 156 | .interface [INFO] [stderr] 157 | .get_multiline_colored( [INFO] [stderr] 158 | 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:251:22 [INFO] [stderr] | [INFO] [stderr] 251 | let color_mode = match should_colorize { [INFO] [stderr] | ______________________^ [INFO] [stderr] 252 | | true => ColorMode::On, [INFO] [stderr] 253 | | false => ColorMode::Off, [INFO] [stderr] 254 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if should_colorize { ColorMode::On } else { ColorMode::Off }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/main.rs:268:15 [INFO] [stderr] | [INFO] [stderr] 268 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:460:16 [INFO] [stderr] | [INFO] [stderr] 460 | if address.is_none() & &activate.is_none() & &bridge.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `bridge.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:460:16 [INFO] [stderr] | [INFO] [stderr] 460 | if address.is_none() & &activate.is_none() & &bridge.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `activate.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.58s [INFO] running `"docker" "inspect" "fd45807288e64065c00f638e4e5738b423ce8d857fa246984a537aa0338d53e9"` [INFO] running `"docker" "rm" "-f" "fd45807288e64065c00f638e4e5738b423ce8d857fa246984a537aa0338d53e9"` [INFO] [stdout] fd45807288e64065c00f638e4e5738b423ce8d857fa246984a537aa0338d53e9