[INFO] crate varint 0.9.0 is already in cache
[INFO] extracting crate varint 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/varint/0.9.0
[INFO] extracting crate varint 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varint/0.9.0
[INFO] validating manifest of varint-0.9.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of varint-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing varint-0.9.0
[INFO] finished frobbing varint-0.9.0
[INFO] frobbed toml for varint-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/varint/0.9.0/Cargo.toml
[INFO] started frobbing varint-0.9.0
[INFO] finished frobbing varint-0.9.0
[INFO] frobbed toml for varint-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/varint/0.9.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting varint-0.9.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/varint/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 28e4dd6658d747871d0558304bc62ce45ebcc590398ee61ed048c7f82362134b
[INFO] running `"docker" "start" "-a" "28e4dd6658d747871d0558304bc62ce45ebcc590398ee61ed048c7f82362134b"`
[INFO] [stderr]     Checking bit_utils v0.1.1
[INFO] [stderr]     Checking varint v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 return Ok(value.zigzag());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.zigzag())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |                 return Err(error);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:56:44
[INFO] [stderr]    |
[INFO] [stderr] 56 |             decoded_value |= ((next_byte & 0b01111111) as u32) << shift_amount;
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:92:13
[INFO] [stderr]    |
[INFO] [stderr] 92 |             return self.write_all(raw_buffer);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write_all(raw_buffer)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rawio.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |             return self.write_all(raw_buffer);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write_all(raw_buffer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:95:29
[INFO] [stderr]    |
[INFO] [stderr] 95 |             while _value >= 0b10000000 {
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:97:48
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let next_byte: u8 = ((_value & 0b01111111) as u8) | 0b10000000;
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:97:69
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let next_byte: u8 = ((_value & 0b01111111) as u8) | 0b10000000;
[INFO] [stderr]    |                                                                     ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:114:45
[INFO] [stderr]     |
[INFO] [stderr] 114 |             let raw_buffer = vec![(_value & 0b01111111) as u8];
[INFO] [stderr]     |                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `next_byte` is never read
[INFO] [stderr]   --> src/rawio.rs:37:17
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let mut next_byte: u8 = 0;
[INFO] [stderr]    |                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/rawio.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |             decoded_value |= ((next_byte & 0b01111111) as u32) << shift_amount;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte & 0b01111111)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/rawio.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 _value = _value >> 7;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `_value >>= 7`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:17:17
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 return Ok(value.zigzag());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.zigzag())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |                 return Err(error);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:56:44
[INFO] [stderr]    |
[INFO] [stderr] 56 |             decoded_value |= ((next_byte & 0b01111111) as u32) << shift_amount;
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/rawio.rs:92:13
[INFO] [stderr]    |
[INFO] [stderr] 92 |             return self.write_all(raw_buffer);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write_all(raw_buffer)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/rawio.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |             return self.write_all(raw_buffer);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write_all(raw_buffer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:95:29
[INFO] [stderr]    |
[INFO] [stderr] 95 |             while _value >= 0b10000000 {
[INFO] [stderr]    |                             ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:97:48
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let next_byte: u8 = ((_value & 0b01111111) as u8) | 0b10000000;
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/rawio.rs:97:69
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 let next_byte: u8 = ((_value & 0b01111111) as u8) | 0b10000000;
[INFO] [stderr]    |                                                                     ^^^^^^^^^^ help: consider: `0b1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:114:45
[INFO] [stderr]     |
[INFO] [stderr] 114 |             let raw_buffer = vec![(_value & 0b01111111) as u8];
[INFO] [stderr]     |                                             ^^^^^^^^^^ help: consider: `0b0111_1111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:146:49
[INFO] [stderr]     |
[INFO] [stderr] 146 |         assert!(vector.write_unsigned_varint_32(2111111111).is_ok());
[INFO] [stderr]     |                                                 ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:147:49
[INFO] [stderr]     |
[INFO] [stderr] 147 |         assert!(vector.write_unsigned_varint_32(3463465).is_ok());
[INFO] [stderr]     |                                                 ^^^^^^^ help: consider: `3_463_465`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:153:20
[INFO] [stderr]     |
[INFO] [stderr] 153 |         assert_eq!(2111111111, vector.read_unsigned_varint_32().unwrap());
[INFO] [stderr]     |                    ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         assert_eq!(3463465, vector.read_unsigned_varint_32().unwrap());
[INFO] [stderr]     |                    ^^^^^^^ help: consider: `3_463_465`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:166:47
[INFO] [stderr]     |
[INFO] [stderr] 166 |         assert!(vector.write_signed_varint_32(2111111111).is_ok());
[INFO] [stderr]     |                                               ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:167:48
[INFO] [stderr]     |
[INFO] [stderr] 167 |         assert!(vector.write_signed_varint_32(-2111111111).is_ok());
[INFO] [stderr]     |                                                ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:168:48
[INFO] [stderr]     |
[INFO] [stderr] 168 |         assert!(vector.write_signed_varint_32(-3463465).is_ok());
[INFO] [stderr]     |                                                ^^^^^^^ help: consider: `3_463_465`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:174:20
[INFO] [stderr]     |
[INFO] [stderr] 174 |         assert_eq!(2111111111, vector.read_signed_varint_32().unwrap());
[INFO] [stderr]     |                    ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:175:21
[INFO] [stderr]     |
[INFO] [stderr] 175 |         assert_eq!(-2111111111, vector.read_signed_varint_32().unwrap());
[INFO] [stderr]     |                     ^^^^^^^^^^ help: consider: `2_111_111_111`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:176:21
[INFO] [stderr]     |
[INFO] [stderr] 176 |         assert_eq!(-3463465, vector.read_signed_varint_32().unwrap());
[INFO] [stderr]     |                     ^^^^^^^ help: consider: `3_463_465`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:188:23
[INFO] [stderr]     |
[INFO] [stderr] 188 |         while index < 123456 {
[INFO] [stderr]     |                       ^^^^^^ help: consider: `123_456`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/rawio.rs:197:23
[INFO] [stderr]     |
[INFO] [stderr] 197 |         while index < 123456 {
[INFO] [stderr]     |                       ^^^^^^ help: consider: `123_456`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `next_byte` is never read
[INFO] [stderr]   --> src/rawio.rs:37:17
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let mut next_byte: u8 = 0;
[INFO] [stderr]    |                 ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/rawio.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |             decoded_value |= ((next_byte & 0b01111111) as u32) << shift_amount;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(next_byte & 0b01111111)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/rawio.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 _value = _value >> 7;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `_value >>= 7`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.57s
[INFO] running `"docker" "inspect" "28e4dd6658d747871d0558304bc62ce45ebcc590398ee61ed048c7f82362134b"`
[INFO] running `"docker" "rm" "-f" "28e4dd6658d747871d0558304bc62ce45ebcc590398ee61ed048c7f82362134b"`
[INFO] [stdout] 28e4dd6658d747871d0558304bc62ce45ebcc590398ee61ed048c7f82362134b