[INFO] crate vapoursynth 0.2.0 is already in cache [INFO] extracting crate vapoursynth 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/vapoursynth/0.2.0 [INFO] extracting crate vapoursynth 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vapoursynth/0.2.0 [INFO] validating manifest of vapoursynth-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vapoursynth-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vapoursynth-0.2.0 [INFO] finished frobbing vapoursynth-0.2.0 [INFO] frobbed toml for vapoursynth-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/vapoursynth/0.2.0/Cargo.toml [INFO] started frobbing vapoursynth-0.2.0 [INFO] finished frobbing vapoursynth-0.2.0 [INFO] frobbed toml for vapoursynth-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/vapoursynth/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vapoursynth-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/vapoursynth/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4066963e752f28b0cc130e9763eb397870887bb5eae65eafe9fc33b0fff7bd4 [INFO] running `"docker" "start" "-a" "e4066963e752f28b0cc130e9763eb397870887bb5eae65eafe9fc33b0fff7bd4"` [INFO] [stderr] Compiling vapoursynth-sys v0.2.2 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking vapoursynth v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/map/errors.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/map/errors.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/map/errors.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/map/errors.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/api.rs:719:48 [INFO] [stderr] | [INFO] [stderr] 719 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/format.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | #[cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node/mod.rs:171:56 [INFO] [stderr] | [INFO] [stderr] 171 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/api.rs:719:48 [INFO] [stderr] | [INFO] [stderr] 719 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | for cause in err.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:128:89 [INFO] [stderr] | [INFO] [stderr] 128 | buf += &format!("Error in Filter::get_frame_initial(): {}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:150:51 [INFO] [stderr] | [INFO] [stderr] 150 | buf += &format!("{}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | err.cause() [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:344:50 [INFO] [stderr] | [INFO] [stderr] 344 | pub(crate) unsafe fn free_frame(self, frame: &ffi::VSFrameRef) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:353:51 [INFO] [stderr] | [INFO] [stderr] 353 | pub(crate) unsafe fn clone_frame(self, frame: &ffi::VSFrameRef) -> *const ffi::VSFrameRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:362:56 [INFO] [stderr] | [INFO] [stderr] 362 | pub(crate) unsafe fn get_frame_format(self, frame: &ffi::VSFrameRef) -> *const ffi::VSFormat { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:371:55 [INFO] [stderr] | [INFO] [stderr] 371 | pub(crate) unsafe fn get_frame_width(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:380:56 [INFO] [stderr] | [INFO] [stderr] 380 | pub(crate) unsafe fn get_frame_height(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:389:56 [INFO] [stderr] | [INFO] [stderr] 389 | pub(crate) unsafe fn get_frame_stride(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | frame: &ffi::VSFrameRef, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:425:58 [INFO] [stderr] | [INFO] [stderr] 425 | pub(crate) unsafe fn get_frame_props_ro(self, frame: &ffi::VSFrameRef) -> *const ffi::VSMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:469:47 [INFO] [stderr] | [INFO] [stderr] 469 | pub(crate) unsafe fn get_error(self, map: &ffi::VSMap) -> *const c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:487:51 [INFO] [stderr] | [INFO] [stderr] 487 | pub(crate) unsafe fn prop_num_keys(self, map: &ffi::VSMap) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:496:50 [INFO] [stderr] | [INFO] [stderr] 496 | pub(crate) unsafe fn prop_get_key(self, map: &ffi::VSMap, index: i32) -> *const c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:514:55 [INFO] [stderr] | [INFO] [stderr] 514 | pub(crate) unsafe fn prop_num_elements(self, map: &ffi::VSMap, key: *const c_char) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:523:51 [INFO] [stderr] | [INFO] [stderr] 523 | pub(crate) unsafe fn prop_get_type(self, map: &ffi::VSMap, key: *const c_char) -> c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:534:14 [INFO] [stderr] | [INFO] [stderr] 534 | map: &ffi::VSMap, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:823:12 [INFO] [stderr] | [INFO] [stderr] 823 | f: &ffi::VSFrameRef, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | pub(crate) fn ptr(&self) -> *mut ffi::VSCore { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:93:23 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn get_format(&self, id: FormatID) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn get_plugin_by_id(&self, id: &str) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_plugin_by_namespace(&self, namespace: &str) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/api.rs:719:48 [INFO] [stderr] | [INFO] [stderr] 719 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/format.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | #[cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `boxed_local` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/node/mod.rs:171:56 [INFO] [stderr] | [INFO] [stderr] 171 | #[cfg_attr(feature = "cargo-clippy", allow(boxed_local))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::boxed_local` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/api.rs:719:48 [INFO] [stderr] | [INFO] [stderr] 719 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/node/mod.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 119 | let mut err_buf = Vec::with_capacity(ERROR_BUF_CAPACITY); [INFO] [stderr] | -------------------------------------- help: consider replace allocation with: `vec![0; ERROR_BUF_CAPACITY]` [INFO] [stderr] 120 | err_buf.resize(ERROR_BUF_CAPACITY, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn functions(&self) -> OwnedMap<'core> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn invoke(&self, name: &str, args: &Map<'core>) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn register_function(&self, filter_function: F) -> Result<(), NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> examples/vspipe.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | write!(writer, " Ip A0:0 XLENGTH={}\n", num_frames)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> examples/vspipe.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | write!(writer, "FRAME\n").context("Couldn't output the frame header")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | for cause in err.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:128:89 [INFO] [stderr] | [INFO] [stderr] 128 | buf += &format!("Error in Filter::get_frame_initial(): {}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:150:51 [INFO] [stderr] | [INFO] [stderr] 150 | buf += &format!("{}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> src/plugins/ffi.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | err.cause() [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:344:50 [INFO] [stderr] | [INFO] [stderr] 344 | pub(crate) unsafe fn free_frame(self, frame: &ffi::VSFrameRef) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:353:51 [INFO] [stderr] | [INFO] [stderr] 353 | pub(crate) unsafe fn clone_frame(self, frame: &ffi::VSFrameRef) -> *const ffi::VSFrameRef { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:362:56 [INFO] [stderr] | [INFO] [stderr] 362 | pub(crate) unsafe fn get_frame_format(self, frame: &ffi::VSFrameRef) -> *const ffi::VSFormat { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:371:55 [INFO] [stderr] | [INFO] [stderr] 371 | pub(crate) unsafe fn get_frame_width(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:380:56 [INFO] [stderr] | [INFO] [stderr] 380 | pub(crate) unsafe fn get_frame_height(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:389:56 [INFO] [stderr] | [INFO] [stderr] 389 | pub(crate) unsafe fn get_frame_stride(self, frame: &ffi::VSFrameRef, plane: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | frame: &ffi::VSFrameRef, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:425:58 [INFO] [stderr] | [INFO] [stderr] 425 | pub(crate) unsafe fn get_frame_props_ro(self, frame: &ffi::VSFrameRef) -> *const ffi::VSMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:469:47 [INFO] [stderr] | [INFO] [stderr] 469 | pub(crate) unsafe fn get_error(self, map: &ffi::VSMap) -> *const c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:487:51 [INFO] [stderr] | [INFO] [stderr] 487 | pub(crate) unsafe fn prop_num_keys(self, map: &ffi::VSMap) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:496:50 [INFO] [stderr] | [INFO] [stderr] 496 | pub(crate) unsafe fn prop_get_key(self, map: &ffi::VSMap, index: i32) -> *const c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:514:55 [INFO] [stderr] | [INFO] [stderr] 514 | pub(crate) unsafe fn prop_num_elements(self, map: &ffi::VSMap, key: *const c_char) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:523:51 [INFO] [stderr] | [INFO] [stderr] 523 | pub(crate) unsafe fn prop_get_type(self, map: &ffi::VSMap, key: *const c_char) -> c_char { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:534:14 [INFO] [stderr] | [INFO] [stderr] 534 | map: &ffi::VSMap, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSMap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api.rs:823:12 [INFO] [stderr] | [INFO] [stderr] 823 | f: &ffi::VSFrameRef, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `ffi::VSFrameRef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | pub(crate) fn ptr(&self) -> *mut ffi::VSCore { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:93:23 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn get_format(&self, id: FormatID) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn get_plugin_by_id(&self, id: &str) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | pub fn get_plugin_by_namespace(&self, namespace: &str) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> examples/vspipe.rs:898:36 [INFO] [stderr] | [INFO] [stderr] 898 | eprintln!("Error: {}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> examples/vspipe.rs:900:26 [INFO] [stderr] | [INFO] [stderr] 900 | for cause in err.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/node/mod.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 119 | let mut err_buf = Vec::with_capacity(ERROR_BUF_CAPACITY); [INFO] [stderr] | -------------------------------------- help: consider replace allocation with: `vec![0; ERROR_BUF_CAPACITY]` [INFO] [stderr] 120 | err_buf.resize(ERROR_BUF_CAPACITY, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn functions(&self) -> OwnedMap<'core> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn invoke(&self, name: &str, args: &Map<'core>) -> Result, NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plugin.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn register_function(&self, filter_function: F) -> Result<(), NulError> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::cause': please use 'as_fail()' method instead [INFO] [stderr] --> examples/vpy-info.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | eprintln!("Error: {}", err.cause()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> examples/vpy-info.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | for cause in err.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.49s [INFO] running `"docker" "inspect" "e4066963e752f28b0cc130e9763eb397870887bb5eae65eafe9fc33b0fff7bd4"` [INFO] running `"docker" "rm" "-f" "e4066963e752f28b0cc130e9763eb397870887bb5eae65eafe9fc33b0fff7bd4"` [INFO] [stdout] e4066963e752f28b0cc130e9763eb397870887bb5eae65eafe9fc33b0fff7bd4