[INFO] crate valor 0.0.0-test is already in cache [INFO] extracting crate valor 0.0.0-test into work/ex/clippy-test-run/sources/stable/reg/valor/0.0.0-test [INFO] extracting crate valor 0.0.0-test into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/valor/0.0.0-test [INFO] validating manifest of valor-0.0.0-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of valor-0.0.0-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing valor-0.0.0-test [INFO] finished frobbing valor-0.0.0-test [INFO] frobbed toml for valor-0.0.0-test written to work/ex/clippy-test-run/sources/stable/reg/valor/0.0.0-test/Cargo.toml [INFO] started frobbing valor-0.0.0-test [INFO] finished frobbing valor-0.0.0-test [INFO] frobbed toml for valor-0.0.0-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/valor/0.0.0-test/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting valor-0.0.0-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/valor/0.0.0-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3c6afb4e1be3d996c440322f6c8eaf27d83844ca49c9f63b952dffa311578f1 [INFO] running `"docker" "start" "-a" "a3c6afb4e1be3d996c440322f6c8eaf27d83844ca49c9f63b952dffa311578f1"` [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Compiling freetype-sys v0.5.0 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking id_tree v1.3.0 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking freetype-rs v0.14.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking gfx_window_glutin v0.17.0 [INFO] [stderr] Checking gfx_text v0.18.0 [INFO] [stderr] Checking valor v0.0.0-test (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/renderer.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | transform [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/renderer.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | let transform = transforms.iter().fold(identity, |acc, t| acc * t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scene.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | child_id [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scene.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | let child_id = self.graph [INFO] [stderr] | ________________________^ [INFO] [stderr] 69 | | .insert(Node::new(node), UnderNode(parent_id)) [INFO] [stderr] 70 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/renderer.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | transform [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/renderer.rs:173:25 [INFO] [stderr] | [INFO] [stderr] 173 | let transform = transforms.iter().fold(identity, |acc, t| acc * t); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scene.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | child_id [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scene.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | let child_id = self.graph [INFO] [stderr] | ________________________^ [INFO] [stderr] 69 | | .insert(Node::new(node), UnderNode(parent_id)) [INFO] [stderr] 70 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(mut renderer: &mut Renderer, vertices: &[Vertex]) -> ModelHandle { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ValorBuilder` [INFO] [stderr] --> src/builder.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | ValorBuilder { [INFO] [stderr] 22 | | title: "Valor", [INFO] [stderr] 23 | | width: 640, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `camera::Camera` [INFO] [stderr] --> src/camera.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | let position = Vector3::new(0.0, 0.0, 0.0); [INFO] [stderr] 17 | | [INFO] [stderr] 18 | | let aspect = 4.0f32 / 3.0f32; [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for camera::Camera { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/renderer.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub(crate) fn new( [INFO] [stderr] 49 | | factory: Factory, [INFO] [stderr] 50 | | device: Device, [INFO] [stderr] 51 | | encoder: Encoder, [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Self { [INFO] [stderr] 50 | | use id_tree::InsertBehavior::*; [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let mut graph: Tree = TreeBuilder::new().build(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | Scene { root_id, graph } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | impl Default for scene::Scene { [INFO] [stderr] 49 | fn default() -> Self { [INFO] [stderr] 50 | Self::new() [INFO] [stderr] 51 | } [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(mut renderer: &mut Renderer, vertices: &[Vertex]) -> ModelHandle { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ValorBuilder` [INFO] [stderr] --> src/builder.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | ValorBuilder { [INFO] [stderr] 22 | | title: "Valor", [INFO] [stderr] 23 | | width: 640, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `camera::Camera` [INFO] [stderr] --> src/camera.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | let position = Vector3::new(0.0, 0.0, 0.0); [INFO] [stderr] 17 | | [INFO] [stderr] 18 | | let aspect = 4.0f32 / 3.0f32; [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for camera::Camera { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/renderer.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub(crate) fn new( [INFO] [stderr] 49 | | factory: Factory, [INFO] [stderr] 50 | | device: Device, [INFO] [stderr] 51 | | encoder: Encoder, [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> Self { [INFO] [stderr] 50 | | use id_tree::InsertBehavior::*; [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let mut graph: Tree = TreeBuilder::new().build(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | Scene { root_id, graph } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | impl Default for scene::Scene { [INFO] [stderr] 49 | fn default() -> Self { [INFO] [stderr] 50 | Self::new() [INFO] [stderr] 51 | } [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "a3c6afb4e1be3d996c440322f6c8eaf27d83844ca49c9f63b952dffa311578f1"` [INFO] running `"docker" "rm" "-f" "a3c6afb4e1be3d996c440322f6c8eaf27d83844ca49c9f63b952dffa311578f1"` [INFO] [stdout] a3c6afb4e1be3d996c440322f6c8eaf27d83844ca49c9f63b952dffa311578f1