[INFO] crate validator-cli 1.0.3 is already in cache [INFO] extracting crate validator-cli 1.0.3 into work/ex/clippy-test-run/sources/stable/reg/validator-cli/1.0.3 [INFO] extracting crate validator-cli 1.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validator-cli/1.0.3 [INFO] validating manifest of validator-cli-1.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of validator-cli-1.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing validator-cli-1.0.3 [INFO] finished frobbing validator-cli-1.0.3 [INFO] frobbed toml for validator-cli-1.0.3 written to work/ex/clippy-test-run/sources/stable/reg/validator-cli/1.0.3/Cargo.toml [INFO] started frobbing validator-cli-1.0.3 [INFO] finished frobbing validator-cli-1.0.3 [INFO] frobbed toml for validator-cli-1.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validator-cli/1.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting validator-cli-1.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/validator-cli/1.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8589300fd60046c8e9bf2dbabadc562f1c532b14fce7a656c6080d49fa942649 [INFO] running `"docker" "start" "-a" "8589300fd60046c8e9bf2dbabadc562f1c532b14fce7a656c6080d49fa942649"` [INFO] [stderr] Checking tap v0.2.1 [INFO] [stderr] Checking yansi v0.3.4 [INFO] [stderr] Compiling time v0.1.42 [INFO] [stderr] Compiling commander v0.1.2 [INFO] [stderr] Checking validator-cli v1.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:81:25 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:81:25 [INFO] [stderr] | [INFO] [stderr] 81 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schemas.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|last_path| last_path.split(".").nth(0)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 57 | | ErrorKind::InvalidInput, [INFO] [stderr] 58 | | "❌ Some required parameters are missing ❌", [INFO] [stderr] 59 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or_else(|| Error::new( [INFO] [stderr] 57 | ErrorKind::InvalidInput, [INFO] [stderr] 58 | "❌ Some required parameters are missing ❌", [INFO] [stderr] 59 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:77:55 [INFO] [stderr] | [INFO] [stderr] 77 | Paint::red(error.dataPath.unwrap_or("".into())).bold(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | error.data.unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | Paint::red(error.message.unwrap_or("".into())).bold() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:82:69 [INFO] [stderr] | [INFO] [stderr] 82 | println!("schemaPath: {}", error.schemaPath.unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | schemas: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Schema]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:10 [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 107 | | ErrorKind::InvalidInput, [INFO] [stderr] 108 | | format!( [INFO] [stderr] 109 | | "Could not find matching schema for '{}'", [INFO] [stderr] 110 | | schema_name [INFO] [stderr] 111 | | ), [INFO] [stderr] 112 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or_else(|| Error::new( [INFO] [stderr] 107 | ErrorKind::InvalidInput, [INFO] [stderr] 108 | format!( [INFO] [stderr] 109 | "Could not find matching schema for '{}'", [INFO] [stderr] 110 | schema_name [INFO] [stderr] 111 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schemas.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|last_path| last_path.split(".").nth(0)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/schemas.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | assert!(Schemas::get().expect("Could not download schema").len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!Schemas::get().expect("Could not download schema").is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 57 | | ErrorKind::InvalidInput, [INFO] [stderr] 58 | | "❌ Some required parameters are missing ❌", [INFO] [stderr] 59 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or_else(|| Error::new( [INFO] [stderr] 57 | ErrorKind::InvalidInput, [INFO] [stderr] 58 | "❌ Some required parameters are missing ❌", [INFO] [stderr] 59 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:77:55 [INFO] [stderr] | [INFO] [stderr] 77 | Paint::red(error.dataPath.unwrap_or("".into())).bold(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | error.data.unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | Paint::red(error.message.unwrap_or("".into())).bold() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:82:69 [INFO] [stderr] | [INFO] [stderr] 82 | println!("schemaPath: {}", error.schemaPath.unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | schemas: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Schema]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:10 [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or(Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 107 | | ErrorKind::InvalidInput, [INFO] [stderr] 108 | | format!( [INFO] [stderr] 109 | | "Could not find matching schema for '{}'", [INFO] [stderr] 110 | | schema_name [INFO] [stderr] 111 | | ), [INFO] [stderr] 112 | | )) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | .ok_or_else(|| Error::new( [INFO] [stderr] 107 | ErrorKind::InvalidInput, [INFO] [stderr] 108 | format!( [INFO] [stderr] 109 | "Could not find matching schema for '{}'", [INFO] [stderr] 110 | schema_name [INFO] [stderr] 111 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.55s [INFO] running `"docker" "inspect" "8589300fd60046c8e9bf2dbabadc562f1c532b14fce7a656c6080d49fa942649"` [INFO] running `"docker" "rm" "-f" "8589300fd60046c8e9bf2dbabadc562f1c532b14fce7a656c6080d49fa942649"` [INFO] [stdout] 8589300fd60046c8e9bf2dbabadc562f1c532b14fce7a656c6080d49fa942649