[INFO] crate validator 0.8.0 is already in cache [INFO] extracting crate validator 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/validator/0.8.0 [INFO] extracting crate validator 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validator/0.8.0 [INFO] validating manifest of validator-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of validator-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing validator-0.8.0 [INFO] finished frobbing validator-0.8.0 [INFO] frobbed toml for validator-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/validator/0.8.0/Cargo.toml [INFO] started frobbing validator-0.8.0 [INFO] finished frobbing validator-0.8.0 [INFO] frobbed toml for validator-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validator/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting validator-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/validator/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88f1b048af5fa120dfea062c37c74ad6173b401d0e05fb891ab7309196962b7a [INFO] running `"docker" "start" "-a" "88f1b048af5fa120dfea062c37c74ad6173b401d0e05fb891ab7309196962b7a"` [INFO] [stderr] Checking validator v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/validation/ip.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / match IpAddr::from_str(val.into().as_ref()) { [INFO] [stderr] 39 | | Ok(_) => true, [INFO] [stderr] 40 | | Err(_) => false, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try this: `IpAddr::from_str(val.into().as_ref()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/validation/urls.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match Url::parse(val.into().as_ref()) { [INFO] [stderr] 10 | | Ok(_) => true, [INFO] [stderr] 11 | | Err(_) => false, [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: try this: `Url::parse(val.into().as_ref()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/validation/ip.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / match IpAddr::from_str(val.into().as_ref()) { [INFO] [stderr] 39 | | Ok(_) => true, [INFO] [stderr] 40 | | Err(_) => false, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ help: try this: `IpAddr::from_str(val.into().as_ref()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/validation/range.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(validate_range(validator, 1 as f64), true); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/validation/range.rs:26:46 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(validate_range(validator, 20 as f64), false); [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/validation/urls.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / match Url::parse(val.into().as_ref()) { [INFO] [stderr] 10 | | Ok(_) => true, [INFO] [stderr] 11 | | Err(_) => false, [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ help: try this: `Url::parse(val.into().as_ref()).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.63s [INFO] running `"docker" "inspect" "88f1b048af5fa120dfea062c37c74ad6173b401d0e05fb891ab7309196962b7a"` [INFO] running `"docker" "rm" "-f" "88f1b048af5fa120dfea062c37c74ad6173b401d0e05fb891ab7309196962b7a"` [INFO] [stdout] 88f1b048af5fa120dfea062c37c74ad6173b401d0e05fb891ab7309196962b7a