[INFO] crate validate 0.6.1 is already in cache [INFO] extracting crate validate 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/validate/0.6.1 [INFO] extracting crate validate 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validate/0.6.1 [INFO] validating manifest of validate-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of validate-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing validate-0.6.1 [INFO] finished frobbing validate-0.6.1 [INFO] frobbed toml for validate-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/validate/0.6.1/Cargo.toml [INFO] started frobbing validate-0.6.1 [INFO] finished frobbing validate-0.6.1 [INFO] frobbed toml for validate-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/validate/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting validate-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/validate/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da2bd949cbdf227c09746c9a40e74d704b4efbe71de84155d18e7177a9507352 [INFO] running `"docker" "start" "-a" "da2bd949cbdf227c09746c9a40e74d704b4efbe71de84155d18e7177a9507352"` [INFO] [stderr] Checking validate v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rule.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn map<'b, F, U>(self, get: F) -> Rule [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rule.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn nest<'b, R, F, U>(get: F, rule: R) -> Self [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/rules.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | match regex.is_match(input) { [INFO] [stderr] | _________^ [INFO] [stderr] 23 | | true => Ok(()), [INFO] [stderr] 24 | | false => Err(format!("must be {}", description).into()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if regex.is_match(input) { Ok(()) } else { Err(format!("must be {}", description).into()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rule.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn map<'b, F, U>(self, get: F) -> Rule [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rule.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn nest<'b, R, F, U>(get: F, rule: R) -> Self [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/rules.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | match regex.is_match(input) { [INFO] [stderr] | _________^ [INFO] [stderr] 23 | | true => Ok(()), [INFO] [stderr] 24 | | false => Err(format!("must be {}", description).into()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if regex.is_match(input) { Ok(()) } else { Err(format!("must be {}", description).into()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.97s [INFO] running `"docker" "inspect" "da2bd949cbdf227c09746c9a40e74d704b4efbe71de84155d18e7177a9507352"` [INFO] running `"docker" "rm" "-f" "da2bd949cbdf227c09746c9a40e74d704b4efbe71de84155d18e7177a9507352"` [INFO] [stdout] da2bd949cbdf227c09746c9a40e74d704b4efbe71de84155d18e7177a9507352