[INFO] crate uvm_core 0.0.1 is already in cache [INFO] extracting crate uvm_core 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/uvm_core/0.0.1 [INFO] extracting crate uvm_core 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uvm_core/0.0.1 [INFO] validating manifest of uvm_core-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uvm_core-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uvm_core-0.0.1 [INFO] finished frobbing uvm_core-0.0.1 [INFO] frobbed toml for uvm_core-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/uvm_core/0.0.1/Cargo.toml [INFO] started frobbing uvm_core-0.0.1 [INFO] finished frobbing uvm_core-0.0.1 [INFO] frobbed toml for uvm_core-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uvm_core/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uvm_core-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uvm_core/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8b19b21f245d1cc205cc5561b5f304ae2c4faf1a5909e4e808205b1c9289bf5 [INFO] running `"docker" "start" "-a" "d8b19b21f245d1cc205cc5561b5f304ae2c4faf1a5909e4e808205b1c9289bf5"` [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking plist v0.3.0 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] Checking uvm_core v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unity/installation.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unity/mod.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | InstalledComponents { installation: installation, components: Component::iterator() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `installation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/unity/current_installation.rs:6:32 [INFO] [stderr] | [INFO] [stderr] 6 | const UNITY_CURRENT_LOCATION: &'static str = "/Applications/Unity"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/unity/mod.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | const UNITY_INSTALL_LOCATION: &'static str = "/Applications"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/brew/cask.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | const BREW_CASKS_LOCATION: &'static str = "/usr/local/Caskroom"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/brew/tap.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const BREW_TAPS_LOCATION: &'static str = "/usr/local/Homebrew/Library/Taps"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/unity/version.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Eq,Debug,Clone,Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/unity/version.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl PartialEq for Version { [INFO] [stderr] 50 | | fn eq(&self, other: &Version) -> bool { [INFO] [stderr] 51 | | (self.release_type == other.release_type) [INFO] [stderr] 52 | | && (self.major == other.major) [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unity/version.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &VersionType::Final => write!(f, "final"), [INFO] [stderr] 88 | | &VersionType::Patch => write!(f, "patch"), [INFO] [stderr] 89 | | &VersionType::Beta => write!(f, "beta"), [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | VersionType::Final => write!(f, "final"), [INFO] [stderr] 88 | VersionType::Patch => write!(f, "patch"), [INFO] [stderr] 89 | VersionType::Beta => write!(f, "beta"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unity/version.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | / match self { [INFO] [stderr] 93 | | &VersionType::Final => write!(f, "f"), [INFO] [stderr] 94 | | &VersionType::Patch => write!(f, "p"), [INFO] [stderr] 95 | | &VersionType::Beta => write!(f, "b"), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *self { [INFO] [stderr] 93 | VersionType::Final => write!(f, "f"), [INFO] [stderr] 94 | VersionType::Patch => write!(f, "p"), [INFO] [stderr] 95 | VersionType::Beta => write!(f, "b"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/unity/component.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | COMPONENTS.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unity/component.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn installpath(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unity/component.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn is_installed(&self, unity_install_location:&Path ) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unity/mod.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | return Some(c.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/brew/tap.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | return l.collect::>().contains(&String::from(tap_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.any(|&x| x == String::from(tap_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/install/installer.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | .and_then(|path| match path.exists() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 121 | | true => Ok(path), [INFO] [stderr] 122 | | false => Err(io::Error::new( [INFO] [stderr] 123 | | io::ErrorKind::Other, [INFO] [stderr] ... | [INFO] [stderr] 127 | | ))) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 120 | .and_then(|path| if path.exists() { Ok(path) } else { Err(io::Error::new( [INFO] [stderr] 121 | io::ErrorKind::Other, [INFO] [stderr] 122 | format!( [INFO] [stderr] 123 | "can't locate Payload directory in extracted installer at {}", [INFO] [stderr] 124 | &dir.display() [INFO] [stderr] 125 | ))) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/install/mod.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &InstallVariant::Android => write!(f, "android"), [INFO] [stderr] 30 | | &InstallVariant::Ios => write!(f, "ios"), [INFO] [stderr] 31 | | &InstallVariant::WebGl => write!(f, "webgl"), [INFO] [stderr] ... | [INFO] [stderr] 35 | | _ => write!(f, "editor"), [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | InstallVariant::Android => write!(f, "android"), [INFO] [stderr] 30 | InstallVariant::Ios => write!(f, "ios"), [INFO] [stderr] 31 | InstallVariant::WebGl => write!(f, "webgl"), [INFO] [stderr] 32 | InstallVariant::Linux => write!(f, "linux"), [INFO] [stderr] 33 | InstallVariant::Windows => write!(f, "windows"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/install/mod.rs:68:44 [INFO] [stderr] | [INFO] [stderr] 68 | fn fetch_download_path_from_output(output: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/install/mod.rs:120:18 [INFO] [stderr] | [INFO] [stderr] 120 | let result = String::from(format!("{}@{}", base_name, version.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}@{}", base_name, version.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or(io::Error::new( [INFO] [stderr] | __________^ [INFO] [stderr] 68 | | io::ErrorKind::NotFound, [INFO] [stderr] 69 | | format!("Unable to find Unity version {}", version), [INFO] [stderr] 70 | | ).into()) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or_else(|| io::Error::new( [INFO] [stderr] 68 | io::ErrorKind::NotFound, [INFO] [stderr] 69 | format!("Unable to find Unity version {}", version), [INFO] [stderr] 70 | ).into()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn activate(ref installation: Installation) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / match project_version.exists() { [INFO] [stderr] 88 | | true => Ok(project_version), [INFO] [stderr] 89 | | false => Err(io::Error::new( [INFO] [stderr] 90 | | io::ErrorKind::NotFound, [INFO] [stderr] ... | [INFO] [stderr] 95 | | )), [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 87 | if project_version.exists() { Ok(project_version) } else { Err(io::Error::new( [INFO] [stderr] 88 | io::ErrorKind::NotFound, [INFO] [stderr] 89 | format!( [INFO] [stderr] 90 | "directory {} is not a Unity project", [INFO] [stderr] 91 | base_dir.as_ref().display() [INFO] [stderr] 92 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `uvm_core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d8b19b21f245d1cc205cc5561b5f304ae2c4faf1a5909e4e808205b1c9289bf5"` [INFO] running `"docker" "rm" "-f" "d8b19b21f245d1cc205cc5561b5f304ae2c4faf1a5909e4e808205b1c9289bf5"` [INFO] [stdout] d8b19b21f245d1cc205cc5561b5f304ae2c4faf1a5909e4e808205b1c9289bf5