[INFO] crate utf-8 0.7.4 is already in cache [INFO] extracting crate utf-8 0.7.4 into work/ex/clippy-test-run/sources/stable/reg/utf-8/0.7.4 [INFO] extracting crate utf-8 0.7.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/utf-8/0.7.4 [INFO] validating manifest of utf-8-0.7.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of utf-8-0.7.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing utf-8-0.7.4 [INFO] finished frobbing utf-8-0.7.4 [INFO] frobbed toml for utf-8-0.7.4 written to work/ex/clippy-test-run/sources/stable/reg/utf-8/0.7.4/Cargo.toml [INFO] started frobbing utf-8-0.7.4 [INFO] finished frobbing utf-8-0.7.4 [INFO] frobbed toml for utf-8-0.7.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/utf-8/0.7.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting utf-8-0.7.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/utf-8/0.7.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdda0819206353c575bd0a7a32a5df7ba07b844d8d273a2e667c48417a4e8dc5 [INFO] running `"docker" "start" "-a" "cdda0819206353c575bd0a7a32a5df7ba07b844d8d273a2e667c48417a4e8dc5"` [INFO] [stderr] Checking utf-8 v0.7.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lossy.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | push_str: push_str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `push_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | pub const REPLACEMENT_CHARACTER: &'static str = "\u{FFFD}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | -> Option<(Result<&str, &[u8]>, &'input [u8])> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: couldn't read benches/../tests/shared/data.rs: No such file or directory (os error 2) [INFO] [stderr] --> benches/from_utf8_lossy.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | mod data; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `utf-8`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/unit.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | Ok(s) => return Ok(s), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/unit.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | pub const DECODED_LOSSY: &'static [(&'static [u8], &'static str)] = &[ [INFO] [stderr] | -^^^^^^^-------------------------------- help: consider removing `'static`: `&[(&'static [u8], &'static str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/unit.rs:98:38 [INFO] [stderr] | [INFO] [stderr] 98 | pub const DECODED_LOSSY: &'static [(&'static [u8], &'static str)] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/unit.rs:98:53 [INFO] [stderr] | [INFO] [stderr] 98 | pub const DECODED_LOSSY: &'static [(&'static [u8], &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> tests/unit.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / fn test_is_utf8() { [INFO] [stderr] 31 | | // Chars of 1, 2, 3, and 4 bytes [INFO] [stderr] 32 | | assert!(str_from_utf8("eé€\u{10000}".as_bytes()).is_ok()); [INFO] [stderr] 33 | | // invalid prefix [INFO] [stderr] ... | [INFO] [stderr] 68 | | assert!(str_from_utf8(&[0xF4, 0x8F, 0xBF, 0xBF]).is_ok()); [INFO] [stderr] 69 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/unit.rs:122:1 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn all_partitions<'a, F>(input: &'a [u8], f: F) [INFO] [stderr] 123 | | where F: Fn(&[&[u8]]) [INFO] [stderr] 124 | | { [INFO] [stderr] 125 | | [INFO] [stderr] ... | [INFO] [stderr] 141 | | assert_eq!(chunks.len(), 0); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/unit.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | for i in 1..(input.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=input.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "cdda0819206353c575bd0a7a32a5df7ba07b844d8d273a2e667c48417a4e8dc5"` [INFO] running `"docker" "rm" "-f" "cdda0819206353c575bd0a7a32a5df7ba07b844d8d273a2e667c48417a4e8dc5"` [INFO] [stdout] cdda0819206353c575bd0a7a32a5df7ba07b844d8d273a2e667c48417a4e8dc5