[INFO] crate utah 0.1.2 is already in cache [INFO] extracting crate utah 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/utah/0.1.2 [INFO] extracting crate utah 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/utah/0.1.2 [INFO] validating manifest of utah-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of utah-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing utah-0.1.2 [INFO] finished frobbing utah-0.1.2 [INFO] frobbed toml for utah-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/utah/0.1.2/Cargo.toml [INFO] started frobbing utah-0.1.2 [INFO] finished frobbing utah-0.1.2 [INFO] frobbed toml for utah-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/utah/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting utah-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/utah/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 807452ad6554155d79f0b46007cd60723f7644c6fb7bf4cd23f3c23af2165dfe [INFO] running `"docker" "start" "-a" "807452ad6554155d79f0b46007cd60723f7644c6fb7bf4cd23f3c23af2165dfe"` [INFO] [stderr] warning: unused manifest key: package.respository [INFO] [stderr] Compiling ndarray v0.7.3 [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Checking ndarray-rand v0.3.1 [INFO] [stderr] Checking utah v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | left_columns: left_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | right_columns: right_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | left_columns: left_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | right_columns: right_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:252:22 [INFO] [stderr] | [INFO] [stderr] 252 | Some(z) => c.extend(z.iter().map(|x| x.to_owned())), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | let d = Array::from_shape_vec(res_dim, c).unwrap().mapv(|x| x.to_owned()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:285:22 [INFO] [stderr] | [INFO] [stderr] 285 | Some(z) => c.extend(z.iter().map(|x| x.to_owned())), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | ind: ind, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | ind: ind, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/aggregate.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | left_columns: left_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | right_columns: right_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | left_columns: left_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/interact.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | right_columns: right_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:252:22 [INFO] [stderr] | [INFO] [stderr] 252 | Some(z) => c.extend(z.iter().map(|x| x.to_owned())), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | let d = Array::from_shape_vec(res_dim, c).unwrap().mapv(|x| x.to_owned()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/combinators/interact.rs:285:22 [INFO] [stderr] | [INFO] [stderr] 285 | Some(z) => c.extend(z.iter().map(|x| x.to_owned())), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/process.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | ind: ind, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | ind: ind, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combinators/transform.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | axis: axis, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:175:1 [INFO] [stderr] | [INFO] [stderr] 175 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:184:1 [INFO] [stderr] | [INFO] [stderr] 184 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Some((_, dat)) => return Some(dat.scalar_sum()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(dat.scalar_sum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:123:31 [INFO] [stderr] | [INFO] [stderr] 123 | Some((_, dat)) => return dat.iter().max().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dat.iter().max().map(|x| x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:164:31 [INFO] [stderr] | [INFO] [stderr] 164 | Some((_, dat)) => return dat.iter().min().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dat.iter().min().map(|x| x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/interact.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | Some(v) => return Some((k, lv, Some(*v))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, lv, Some(*v)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return Some((val, dat)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((val, dat))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | return mean.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mean.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | return x.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | return T::empty(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | return T::empty(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod tests; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:175:1 [INFO] [stderr] | [INFO] [stderr] 175 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:184:1 [INFO] [stderr] | [INFO] [stderr] 184 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | Some((_, dat)) => return Some(dat.scalar_sum()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(dat.scalar_sum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:123:31 [INFO] [stderr] | [INFO] [stderr] 123 | Some((_, dat)) => return dat.iter().max().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dat.iter().max().map(|x| x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/aggregate.rs:164:31 [INFO] [stderr] | [INFO] [stderr] 164 | Some((_, dat)) => return dat.iter().min().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dat.iter().min().map(|x| x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/interact.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | Some(v) => return Some((k, lv, Some(*v))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((k, lv, Some(*v)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return Some((val, dat)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((val, dat))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | None => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | return mean.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mean.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/combinators/process.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | return x.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | return T::empty(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | return T::empty(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `T::empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/implement/impl_constructor_generic.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tests/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod tests; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/combinators/aggregate.rs:123:38 [INFO] [stderr] | [INFO] [stderr] 123 | Some((_, dat)) => return dat.iter().max().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dat.iter().max().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/combinators/aggregate.rs:164:38 [INFO] [stderr] | [INFO] [stderr] 164 | Some((_, dat)) => return dat.iter().min().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dat.iter().min().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:255:20 [INFO] [stderr] | [INFO] [stderr] 255 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:306:20 [INFO] [stderr] | [INFO] [stderr] 306 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:380:20 [INFO] [stderr] | [INFO] [stderr] 380 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/combinators/interact.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new(left_df: I, [INFO] [stderr] 29 | | right_df: I, [INFO] [stderr] 30 | | left_other: Vec, [INFO] [stderr] 31 | | axis: UtahAxis) [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/interact.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:209:20 [INFO] [stderr] | [INFO] [stderr] 209 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:250:20 [INFO] [stderr] | [INFO] [stderr] 250 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:324:20 [INFO] [stderr] | [INFO] [stderr] 324 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:395:20 [INFO] [stderr] | [INFO] [stderr] 395 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:468:20 [INFO] [stderr] | [INFO] [stderr] 468 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:268:20 [INFO] [stderr] | [INFO] [stderr] 268 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:276:20 [INFO] [stderr] | [INFO] [stderr] 276 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:302:20 [INFO] [stderr] | [INFO] [stderr] 302 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:315:20 [INFO] [stderr] | [INFO] [stderr] 315 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:334:20 [INFO] [stderr] | [INFO] [stderr] 334 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:371:20 [INFO] [stderr] | [INFO] [stderr] 371 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:383:20 [INFO] [stderr] | [INFO] [stderr] 383 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:395:20 [INFO] [stderr] | [INFO] [stderr] 395 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:412:20 [INFO] [stderr] | [INFO] [stderr] 412 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:420:20 [INFO] [stderr] | [INFO] [stderr] 420 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:428:20 [INFO] [stderr] | [INFO] [stderr] 428 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:436:20 [INFO] [stderr] | [INFO] [stderr] 436 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:449:20 [INFO] [stderr] | [INFO] [stderr] 449 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:462:20 [INFO] [stderr] | [INFO] [stderr] 462 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:475:20 [INFO] [stderr] | [INFO] [stderr] 475 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:489:20 [INFO] [stderr] | [INFO] [stderr] 489 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:518:20 [INFO] [stderr] | [INFO] [stderr] 518 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:583:20 [INFO] [stderr] | [INFO] [stderr] 583 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:621:20 [INFO] [stderr] | [INFO] [stderr] 621 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:651:20 [INFO] [stderr] | [INFO] [stderr] 651 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:685:20 [INFO] [stderr] | [INFO] [stderr] 685 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:714:20 [INFO] [stderr] | [INFO] [stderr] 714 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/dataframe.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn to_df(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mixedtypes.rs:47:61 [INFO] [stderr] | [INFO] [stderr] 47 | InnerType::Float(y) => InnerType::Float(x as f64 * y), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match self { [INFO] [stderr] 88 | | &InnerType::Float(x) => { [INFO] [stderr] 89 | | match rhs { [INFO] [stderr] 90 | | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *self { [INFO] [stderr] 88 | InnerType::Float(x) => { [INFO] [stderr] 89 | match rhs { [INFO] [stderr] 90 | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | &InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] 92 | _ => panic!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | / match rhs { [INFO] [stderr] 90 | | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | | &InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] 92 | | _ => panic!(), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *rhs { [INFO] [stderr] 90 | InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | / match rhs { [INFO] [stderr] 97 | | &InnerType::Int32(y) => Some(x.cmp(&y)), [INFO] [stderr] 98 | | &InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] 99 | | _ => panic!(), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *rhs { [INFO] [stderr] 97 | InnerType::Int32(y) => Some(x.cmp(&y)), [INFO] [stderr] 98 | InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | / match rhs { [INFO] [stderr] 104 | | &InnerType::Int64(y) => Some(x.cmp(&y)), [INFO] [stderr] 105 | | &InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] 106 | | _ => panic!(), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | match *rhs { [INFO] [stderr] 104 | InnerType::Int64(y) => Some(x.cmp(&y)), [INFO] [stderr] 105 | InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / match rhs { [INFO] [stderr] 111 | | &InnerType::Str(ref y) => Some(x.cmp(&y)), [INFO] [stderr] 112 | | _ => panic!(), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *rhs { [INFO] [stderr] 111 | InnerType::Str(ref y) => Some(x.cmp(&y)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | / match rhs { [INFO] [stderr] 117 | | &InnerType::Float(y) => Some((y as i32).cmp(&(y as i32 - 1))), [INFO] [stderr] 118 | | &InnerType::Int64(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 119 | | &InnerType::Int32(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 120 | | _ => panic!(), [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *rhs { [INFO] [stderr] 117 | InnerType::Float(y) => Some((y as i32).cmp(&(y as i32 - 1))), [INFO] [stderr] 118 | InnerType::Int64(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 119 | InnerType::Int32(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &InnerType::Float(x) => { [INFO] [stderr] 132 | | match rhs { [INFO] [stderr] 133 | | &InnerType::Float(y) => x == y, [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | InnerType::Float(x) => { [INFO] [stderr] 132 | match rhs { [INFO] [stderr] 133 | &InnerType::Float(y) => x == y, [INFO] [stderr] 134 | _ => false, [INFO] [stderr] 135 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | / match rhs { [INFO] [stderr] 133 | | &InnerType::Float(y) => x == y, [INFO] [stderr] 134 | | _ => false, [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | match *rhs { [INFO] [stderr] 133 | InnerType::Float(y) => x == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | / match rhs { [INFO] [stderr] 139 | | &InnerType::Int32(y) => x == y, [INFO] [stderr] 140 | | _ => false, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *rhs { [INFO] [stderr] 139 | InnerType::Int32(y) => x == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | / match rhs { [INFO] [stderr] 145 | | &InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] 146 | | _ => false, [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *rhs { [INFO] [stderr] 145 | InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:145:45 [INFO] [stderr] | [INFO] [stderr] 145 | &InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | / match rhs { [INFO] [stderr] 151 | | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] 152 | | _ => false, [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 150 | match *rhs { [INFO] [stderr] 151 | InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:151:63 [INFO] [stderr] | [INFO] [stderr] 151 | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / match rhs { [INFO] [stderr] 157 | | &InnerType::Empty => true, [INFO] [stderr] 158 | | _ => false, [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *rhs { [INFO] [stderr] 157 | InnerType::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/combinators/aggregate.rs:123:38 [INFO] [stderr] | [INFO] [stderr] 123 | Some((_, dat)) => return dat.iter().max().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dat.iter().max().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/combinators/aggregate.rs:164:38 [INFO] [stderr] | [INFO] [stderr] 164 | Some((_, dat)) => return dat.iter().min().map(|x| x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dat.iter().min().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/mixedtypes.rs:304:36 [INFO] [stderr] | [INFO] [stderr] 304 | InnerType::Float(x) => x == NAN, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cmp_nan)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:228:20 [INFO] [stderr] | [INFO] [stderr] 228 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:255:20 [INFO] [stderr] | [INFO] [stderr] 255 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:306:20 [INFO] [stderr] | [INFO] [stderr] 306 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/aggregate.rs:380:20 [INFO] [stderr] | [INFO] [stderr] 380 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/combinators/interact.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new(left_df: I, [INFO] [stderr] 29 | | right_df: I, [INFO] [stderr] 30 | | left_other: Vec, [INFO] [stderr] 31 | | axis: UtahAxis) [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: Could not compile `utah`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/interact.rs:322:20 [INFO] [stderr] | [INFO] [stderr] 322 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:185:20 [INFO] [stderr] | [INFO] [stderr] 185 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:209:20 [INFO] [stderr] | [INFO] [stderr] 209 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:250:20 [INFO] [stderr] | [INFO] [stderr] 250 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:324:20 [INFO] [stderr] | [INFO] [stderr] 324 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:395:20 [INFO] [stderr] | [INFO] [stderr] 395 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:468:20 [INFO] [stderr] | [INFO] [stderr] 468 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/process.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:192:20 [INFO] [stderr] | [INFO] [stderr] 192 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:268:20 [INFO] [stderr] | [INFO] [stderr] 268 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:276:20 [INFO] [stderr] | [INFO] [stderr] 276 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:302:20 [INFO] [stderr] | [INFO] [stderr] 302 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:315:20 [INFO] [stderr] | [INFO] [stderr] 315 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:334:20 [INFO] [stderr] | [INFO] [stderr] 334 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:358:20 [INFO] [stderr] | [INFO] [stderr] 358 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:371:20 [INFO] [stderr] | [INFO] [stderr] 371 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:383:20 [INFO] [stderr] | [INFO] [stderr] 383 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:395:20 [INFO] [stderr] | [INFO] [stderr] 395 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:412:20 [INFO] [stderr] | [INFO] [stderr] 412 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:420:20 [INFO] [stderr] | [INFO] [stderr] 420 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:428:20 [INFO] [stderr] | [INFO] [stderr] 428 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:436:20 [INFO] [stderr] | [INFO] [stderr] 436 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:449:20 [INFO] [stderr] | [INFO] [stderr] 449 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:462:20 [INFO] [stderr] | [INFO] [stderr] 462 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:475:20 [INFO] [stderr] | [INFO] [stderr] 475 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:489:20 [INFO] [stderr] | [INFO] [stderr] 489 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:518:20 [INFO] [stderr] | [INFO] [stderr] 518 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:553:20 [INFO] [stderr] | [INFO] [stderr] 553 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:583:20 [INFO] [stderr] | [INFO] [stderr] 583 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:621:20 [INFO] [stderr] | [INFO] [stderr] 621 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:651:20 [INFO] [stderr] | [INFO] [stderr] 651 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:685:20 [INFO] [stderr] | [INFO] [stderr] 685 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/combinators/transform.rs:714:20 [INFO] [stderr] | [INFO] [stderr] 714 | let axis = self.axis.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.axis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/dataframe.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn to_df(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mixedtypes.rs:47:61 [INFO] [stderr] | [INFO] [stderr] 47 | InnerType::Float(y) => InnerType::Float(x as f64 * y), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match self { [INFO] [stderr] 88 | | &InnerType::Float(x) => { [INFO] [stderr] 89 | | match rhs { [INFO] [stderr] 90 | | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *self { [INFO] [stderr] 88 | InnerType::Float(x) => { [INFO] [stderr] 89 | match rhs { [INFO] [stderr] 90 | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | &InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] 92 | _ => panic!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | / match rhs { [INFO] [stderr] 90 | | &InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | | &InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] 92 | | _ => panic!(), [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | match *rhs { [INFO] [stderr] 90 | InnerType::Float(y) => Some((x as i32).cmp(&(y as i32))), [INFO] [stderr] 91 | InnerType::Empty => Some((x as i32).cmp(&(x as i32 - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | / match rhs { [INFO] [stderr] 97 | | &InnerType::Int32(y) => Some(x.cmp(&y)), [INFO] [stderr] 98 | | &InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] 99 | | _ => panic!(), [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *rhs { [INFO] [stderr] 97 | InnerType::Int32(y) => Some(x.cmp(&y)), [INFO] [stderr] 98 | InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | / match rhs { [INFO] [stderr] 104 | | &InnerType::Int64(y) => Some(x.cmp(&y)), [INFO] [stderr] 105 | | &InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] 106 | | _ => panic!(), [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 103 | match *rhs { [INFO] [stderr] 104 | InnerType::Int64(y) => Some(x.cmp(&y)), [INFO] [stderr] 105 | InnerType::Empty => Some(x.cmp(&(x - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / match rhs { [INFO] [stderr] 111 | | &InnerType::Str(ref y) => Some(x.cmp(&y)), [INFO] [stderr] 112 | | _ => panic!(), [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *rhs { [INFO] [stderr] 111 | InnerType::Str(ref y) => Some(x.cmp(&y)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | / match rhs { [INFO] [stderr] 117 | | &InnerType::Float(y) => Some((y as i32).cmp(&(y as i32 - 1))), [INFO] [stderr] 118 | | &InnerType::Int64(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 119 | | &InnerType::Int32(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 120 | | _ => panic!(), [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *rhs { [INFO] [stderr] 117 | InnerType::Float(y) => Some((y as i32).cmp(&(y as i32 - 1))), [INFO] [stderr] 118 | InnerType::Int64(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] 119 | InnerType::Int32(y) => Some(y.cmp(&(y - 1))), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &InnerType::Float(x) => { [INFO] [stderr] 132 | | match rhs { [INFO] [stderr] 133 | | &InnerType::Float(y) => x == y, [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | InnerType::Float(x) => { [INFO] [stderr] 132 | match rhs { [INFO] [stderr] 133 | &InnerType::Float(y) => x == y, [INFO] [stderr] 134 | _ => false, [INFO] [stderr] 135 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | / match rhs { [INFO] [stderr] 133 | | &InnerType::Float(y) => x == y, [INFO] [stderr] 134 | | _ => false, [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | match *rhs { [INFO] [stderr] 133 | InnerType::Float(y) => x == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | / match rhs { [INFO] [stderr] 139 | | &InnerType::Int32(y) => x == y, [INFO] [stderr] 140 | | _ => false, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *rhs { [INFO] [stderr] 139 | InnerType::Int32(y) => x == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | / match rhs { [INFO] [stderr] 145 | | &InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] 146 | | _ => false, [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *rhs { [INFO] [stderr] 145 | InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:145:45 [INFO] [stderr] | [INFO] [stderr] 145 | &InnerType::Int64(y) => x.to_owned() == y, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | / match rhs { [INFO] [stderr] 151 | | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] 152 | | _ => false, [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 150 | match *rhs { [INFO] [stderr] 151 | InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:151:47 [INFO] [stderr] | [INFO] [stderr] 151 | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/mixedtypes.rs:151:63 [INFO] [stderr] | [INFO] [stderr] 151 | &InnerType::Str(ref y) => x.to_owned() == y.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mixedtypes.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / match rhs { [INFO] [stderr] 157 | | &InnerType::Empty => true, [INFO] [stderr] 158 | | _ => false, [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *rhs { [INFO] [stderr] 157 | InnerType::Empty => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead [INFO] [stderr] --> src/mixedtypes.rs:304:36 [INFO] [stderr] | [INFO] [stderr] 304 | InnerType::Float(x) => x == NAN, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cmp_nan)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_nan [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests/tests.rs:73:15 [INFO] [stderr] | [INFO] [stderr] 73 | let col = df.data.column(0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `df.data.column(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests/tests.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | let col = df.data.row(0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `df.data.row(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests/tests.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | let col = df.data.column(1).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `df.data.column(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tests/tests.rs:104:15 [INFO] [stderr] | [INFO] [stderr] 104 | let row = df.data.row(1).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `df.data.row(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `utah`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "807452ad6554155d79f0b46007cd60723f7644c6fb7bf4cd23f3c23af2165dfe"` [INFO] running `"docker" "rm" "-f" "807452ad6554155d79f0b46007cd60723f7644c6fb7bf4cd23f3c23af2165dfe"` [INFO] [stdout] 807452ad6554155d79f0b46007cd60723f7644c6fb7bf4cd23f3c23af2165dfe