[INFO] crate usvg 0.3.0 is already in cache [INFO] extracting crate usvg 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/usvg/0.3.0 [INFO] extracting crate usvg 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/usvg/0.3.0 [INFO] validating manifest of usvg-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of usvg-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing usvg-0.3.0 [INFO] finished frobbing usvg-0.3.0 [INFO] frobbed toml for usvg-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/usvg/0.3.0/Cargo.toml [INFO] started frobbing usvg-0.3.0 [INFO] finished frobbing usvg-0.3.0 [INFO] frobbed toml for usvg-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/usvg/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting usvg-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/usvg/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b20102fb2b5cfd9b8748633d63ca168e63e8c99437ee2f334527163cf457060c [INFO] running `"docker" "start" "-a" "b20102fb2b5cfd9b8748633d63ca168e63e8c99437ee2f334527163cf457060c"` [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking xmlparser v0.6.1 [INFO] [stderr] Checking phf_shared v0.7.24 [INFO] [stderr] Checking colored v1.7.0 [INFO] [stderr] Checking rustc_version v0.2.3 [INFO] [stderr] Compiling rustc-test v0.3.0 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Checking assert_cli v0.6.3 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking roxmltree v0.1.0 [INFO] [stderr] Checking svgtypes v0.2.0 [INFO] [stderr] Checking euclid v0.19.5 [INFO] [stderr] Checking svgdom v0.14.0 [INFO] [stderr] Checking lyon_geom v0.12.2 [INFO] [stderr] Checking usvg v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:45 [INFO] [stderr] | [INFO] [stderr] 66 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/gradient.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | let stops = try_opt!(convert_stops(node), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/gradient.rs:44:47 [INFO] [stderr] | [INFO] [stderr] 44 | let stops = try_opt!(convert_stops(node), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/text.rs:23:60 [INFO] [stderr] | [INFO] [stderr] 23 | let chunks = try_opt!(convert_chunks(text_elem, tree), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/mod.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | let defs_elem = try_opt!(svg_doc.defs_element(), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/gradient.rs:19:47 [INFO] [stderr] | [INFO] [stderr] 19 | let stops = try_opt!(convert_stops(node), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/gradient.rs:44:47 [INFO] [stderr] | [INFO] [stderr] 44 | let stops = try_opt!(convert_stops(node), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/text.rs:23:60 [INFO] [stderr] | [INFO] [stderr] 23 | let chunks = try_opt!(convert_chunks(text_elem, tree), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/convert/mod.rs:126:54 [INFO] [stderr] | [INFO] [stderr] 126 | let defs_elem = try_opt!(svg_doc.defs_element(), ()); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/gradient.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/gradient.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/convert/gradient.rs:88:53 [INFO] [stderr] | [INFO] [stderr] 88 | let color = attrs.get_color(AId::StopColor).unwrap_or(svgdom::Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(svgdom::Color::black)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/image.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/mask.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:156:55 [INFO] [stderr] | [INFO] [stderr] 156 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:157:55 [INFO] [stderr] | [INFO] [stderr] 157 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:237:39 [INFO] [stderr] | [INFO] [stderr] 237 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:238:39 [INFO] [stderr] | [INFO] [stderr] 238 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:239:39 [INFO] [stderr] | [INFO] [stderr] 239 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:295:21 [INFO] [stderr] | [INFO] [stderr] 295 | let width = (maxx - minx) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(maxx - minx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:296:22 [INFO] [stderr] | [INFO] [stderr] 296 | let height = (maxy - miny) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(maxy - miny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/pattern.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | if !(width > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | if !(height > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:203:8 [INFO] [stderr] | [INFO] [stderr] 203 | if !(r > 0.0) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:230:8 [INFO] [stderr] | [INFO] [stderr] 230 | if !(rx > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:235:8 [INFO] [stderr] | [INFO] [stderr] 235 | if !(ry > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/stroke.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if !(width > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let ref root_attrs = text_elem.attributes(); [INFO] [stderr] | ----^^^^^^^^^^^^^^-------------------------- help: try: `let root_attrs = &text_elem.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let ref attrs = tspan.attributes(); [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let attrs = &tspan.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let ref attrs = n.attributes(); [INFO] [stderr] | ----^^^^^^^^^------------------ help: try: `let attrs = &n.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/preproc/conv_units.rs:76:75 [INFO] [stderr] | [INFO] [stderr] 76 | } else if aid == AId::Offset && len.unit == Unit::Percent { [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 77 | | // The `offset` % value does not depend on viewBox. [INFO] [stderr] 78 | | len.num / 100.0 [INFO] [stderr] 79 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/preproc/conv_units.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | } else if is_bbox_gradient && len.unit == Unit::Percent { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 74 | | // In paint servers with `objectBoundingBox` 100% is equal to 1.0. [INFO] [stderr] 75 | | len.num / 100.0 [INFO] [stderr] 76 | | } else if aid == AId::Offset && len.unit == Unit::Percent { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/preproc/fix_gradient_stops.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | let offset1 = stops[i + 0].attributes().get_number_or(AId::Offset, 0.0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/gradient.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/gradient.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_use.rs:140:40 [INFO] [stderr] | [INFO] [stderr] 140 | let parent = node.parent().unwrap_or(use_node.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| use_node.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/convert/gradient.rs:88:53 [INFO] [stderr] | [INFO] [stderr] 88 | let color = attrs.get_color(AId::StopColor).unwrap_or(svgdom::Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(svgdom::Color::black)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/image.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/mask.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:155:55 [INFO] [stderr] | [INFO] [stderr] 155 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:156:55 [INFO] [stderr] | [INFO] [stderr] 156 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:157:55 [INFO] [stderr] | [INFO] [stderr] 157 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:237:39 [INFO] [stderr] | [INFO] [stderr] 237 | x1: cubic.ctrl1.x as f64, y1: cubic.ctrl1.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl1.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:238:39 [INFO] [stderr] | [INFO] [stderr] 238 | x2: cubic.ctrl2.x as f64, y2: cubic.ctrl2.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.ctrl2.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:239:39 [INFO] [stderr] | [INFO] [stderr] 239 | x: cubic.to.x as f64, y: cubic.to.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(cubic.to.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:295:21 [INFO] [stderr] | [INFO] [stderr] 295 | let width = (maxx - minx) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(maxx - minx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/convert/path.rs:296:22 [INFO] [stderr] | [INFO] [stderr] 296 | let height = (maxy - miny) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(maxy - miny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/pattern.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let ref attrs = node.attributes(); [INFO] [stderr] | ----^^^^^^^^^--------------------- help: try: `let attrs = &node.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:38:8 [INFO] [stderr] | [INFO] [stderr] 38 | if !(width > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | if !(height > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | .unwrap_or(Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Color::black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:203:8 [INFO] [stderr] | [INFO] [stderr] 203 | if !(r > 0.0) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | .unwrap_or(Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Color::black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:230:8 [INFO] [stderr] | [INFO] [stderr] 230 | if !(rx > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/shapes.rs:235:8 [INFO] [stderr] | [INFO] [stderr] 235 | if !(ry > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match attr.value { [INFO] [stderr] 117 | | AValue::Paint(ref link, _) => { [INFO] [stderr] 118 | | if link == gradient { [INFO] [stderr] 119 | | ids.push(aid); [INFO] [stderr] ... | [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let AValue::Paint(ref link, _) = attr.value { [INFO] [stderr] 117 | if link == gradient { [INFO] [stderr] 118 | ids.push(aid); [INFO] [stderr] 119 | } [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/convert/stroke.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if !(width > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let ref root_attrs = text_elem.attributes(); [INFO] [stderr] | ----^^^^^^^^^^^^^^-------------------------- help: try: `let root_attrs = &text_elem.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let ref attrs = tspan.attributes(); [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let attrs = &tspan.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/convert/text.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let ref attrs = n.attributes(); [INFO] [stderr] | ----^^^^^^^^^------------------ help: try: `let attrs = &n.attributes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/preproc/conv_units.rs:76:75 [INFO] [stderr] | [INFO] [stderr] 76 | } else if aid == AId::Offset && len.unit == Unit::Percent { [INFO] [stderr] | ___________________________________________________________________________^ [INFO] [stderr] 77 | | // The `offset` % value does not depend on viewBox. [INFO] [stderr] 78 | | len.num / 100.0 [INFO] [stderr] 79 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/preproc/conv_units.rs:73:73 [INFO] [stderr] | [INFO] [stderr] 73 | } else if is_bbox_gradient && len.unit == Unit::Percent { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 74 | | // In paint servers with `objectBoundingBox` 100% is equal to 1.0. [INFO] [stderr] 75 | | len.num / 100.0 [INFO] [stderr] 76 | | } else if aid == AId::Offset && len.unit == Unit::Percent { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/traits.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match v { [INFO] [stderr] 122 | | &AValue::String(ref s) => Some(s.as_str()), [INFO] [stderr] 123 | | _ => None, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *v { [INFO] [stderr] 122 | AValue::String(ref s) => Some(s.as_str()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/preproc/fix_gradient_stops.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | let offset1 = stops[i + 0].attributes().get_number_or(AId::Offset, 0.0); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/traits.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | let mut ts = ts.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree/attribute.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn value(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_font_size.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | .unwrap_or(Length::new_number(DEFAULT_FONT_SIZE)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Length::new_number(DEFAULT_FONT_SIZE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/tree/node.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Path(Path), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 23 | Path(Box), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/resolve_use.rs:140:40 [INFO] [stderr] | [INFO] [stderr] 140 | let parent = node.parent().unwrap_or(use_node.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| use_node.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:53:42 [INFO] [stderr] | [INFO] [stderr] 53 | .unwrap_or(Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Color::black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | .unwrap_or(Color::black()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Color::black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/preproc/rm_invalid_gradients.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match attr.value { [INFO] [stderr] 117 | | AValue::Paint(ref link, _) => { [INFO] [stderr] 118 | | if link == gradient { [INFO] [stderr] 119 | | ids.push(aid); [INFO] [stderr] ... | [INFO] [stderr] 122 | | _ => {} [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let AValue::Paint(ref link, _) = attr.value { [INFO] [stderr] 117 | if link == gradient { [INFO] [stderr] 118 | ids.push(aid); [INFO] [stderr] 119 | } [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree/io.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | .map_err(|e| Error::ParsingFailed(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ParsingFailed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/traits.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match v { [INFO] [stderr] 122 | | &AValue::String(ref s) => Some(s.as_str()), [INFO] [stderr] 123 | | _ => None, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *v { [INFO] [stderr] 122 | AValue::String(ref s) => Some(s.as_str()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/traits.rs:244:22 [INFO] [stderr] | [INFO] [stderr] 244 | let mut ts = ts.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree/attribute.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn value(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `usvg`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/tree/node.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Path(Path), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 23 | Path(Box), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree/io.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | .map_err(|e| Error::ParsingFailed(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ParsingFailed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `usvg`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b20102fb2b5cfd9b8748633d63ca168e63e8c99437ee2f334527163cf457060c"` [INFO] running `"docker" "rm" "-f" "b20102fb2b5cfd9b8748633d63ca168e63e8c99437ee2f334527163cf457060c"` [INFO] [stdout] b20102fb2b5cfd9b8748633d63ca168e63e8c99437ee2f334527163cf457060c