[INFO] crate usi-run 0.5.0 is already in cache [INFO] extracting crate usi-run 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/usi-run/0.5.0 [INFO] extracting crate usi-run 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/usi-run/0.5.0 [INFO] validating manifest of usi-run-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of usi-run-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing usi-run-0.5.0 [INFO] finished frobbing usi-run-0.5.0 [INFO] frobbed toml for usi-run-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/usi-run/0.5.0/Cargo.toml [INFO] started frobbing usi-run-0.5.0 [INFO] finished frobbing usi-run-0.5.0 [INFO] frobbed toml for usi-run-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/usi-run/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting usi-run-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/usi-run/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49e0e1c87537c1e9b77788e85449543cb13324736b9f28a455fd9c487e6ef86f [INFO] running `"docker" "start" "-a" "49e0e1c87537c1e9b77788e85449543cb13324736b9f28a455fd9c487e6ef86f"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `usirun`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: `panic` setting is ignored for `test` profile [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Compiling bitintr v0.1.18 [INFO] [stderr] Checking usi v0.1.0 [INFO] [stderr] Checking clicolors-control v1.0.0 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking clicolors-control v0.3.2 [INFO] [stderr] Checking indicatif v0.3.3 [INFO] [stderr] Checking shogi v0.7.0 [INFO] [stderr] Checking csa v0.2.0 [INFO] [stderr] Checking usi-run v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | byoyomi: byoyomi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `byoyomi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/writer.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/engine.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/engine.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | process: process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | byoyomi: byoyomi, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `byoyomi` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/writer.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/engine.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player/engine.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | process: process, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `process` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/environment.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Err(Error::EngineNotResponded); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::EngineNotResponded)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reporter/board.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return BoardReporter { [INFO] [stderr] 23 | | dirty: false, [INFO] [stderr] 24 | | black_score, [INFO] [stderr] 25 | | white_score, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | BoardReporter { [INFO] [stderr] 23 | dirty: false, [INFO] [stderr] 24 | black_score, [INFO] [stderr] 25 | white_score, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/reporter/csa.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | captured: _, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Normal { from, to, moved: pc, promoted, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/player/engine.rs:264:36 [INFO] [stderr] | [INFO] [stderr] 264 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 265 | | if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 266 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 267 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 264 | } else if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 265 | if let Some(ponder_move) = *guard { [INFO] [stderr] 266 | let sfen = game.pos.to_sfen(); [INFO] [stderr] 267 | try!(write(&GuiCommand::Position(format!("{} {}", [INFO] [stderr] 268 | sfen, [INFO] [stderr] 269 | ponder_move)))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | const DEFAULT_SFEN: &'static str = "lnsgkgsnl/1r5b1/ppppppppp/9/9/9/PPPPPPPPP/1B5R1/LNSGKGSNL b - \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/environment.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return Err(Error::EngineNotResponded); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::EngineNotResponded)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/reporter/board.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return BoardReporter { [INFO] [stderr] 23 | | dirty: false, [INFO] [stderr] 24 | | black_score, [INFO] [stderr] 25 | | white_score, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | BoardReporter { [INFO] [stderr] 23 | dirty: false, [INFO] [stderr] 24 | black_score, [INFO] [stderr] 25 | white_score, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/reporter/csa.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | captured: _, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Normal { from, to, moved: pc, promoted, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/player/engine.rs:264:36 [INFO] [stderr] | [INFO] [stderr] 264 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 265 | | if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 266 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 267 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 264 | } else if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 265 | if let Some(ponder_move) = *guard { [INFO] [stderr] 266 | let sfen = game.pos.to_sfen(); [INFO] [stderr] 267 | try!(write(&GuiCommand::Position(format!("{} {}", [INFO] [stderr] 268 | sfen, [INFO] [stderr] 269 | ponder_move)))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | const DEFAULT_SFEN: &'static str = "lnsgkgsnl/1r5b1/ppppppppp/9/9/9/PPPPPPPPP/1B5R1/LNSGKGSNL b - \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if let Some(mut game) = shared_game.write().ok() { [INFO] [stderr] 79 | | game.turn_start_time = Instant::now(); [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | / if let Some(mut game) = shared_game.write().ok() { [INFO] [stderr] 92 | | if c != game.pos.side_to_move() { [INFO] [stderr] 93 | | try!(transmit( [INFO] [stderr] 94 | | &Event::GameOver(Some(c), GameOverReason::IllegalMove), [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/environment.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | / match game.time.consume(c, elapsed) { [INFO] [stderr] 101 | | true => {} [INFO] [stderr] 102 | | false => { [INFO] [stderr] 103 | | try!(transmit( [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 100 | if !game.time.consume(c, elapsed) { [INFO] [stderr] 101 | try!(transmit( [INFO] [stderr] 102 | &Event::GameOver(Some(c.flip()), GameOverReason::OutOfTime), [INFO] [stderr] 103 | )); [INFO] [stderr] 104 | break; [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 136 | | if c != game.pos.side_to_move() { [INFO] [stderr] 137 | | try!(transmit(&Event::GameOver( [INFO] [stderr] 138 | | Some(c.flip()), [INFO] [stderr] ... | [INFO] [stderr] 147 | | break; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 152 | | if game.pos.try_declare_winning(c) { [INFO] [stderr] 153 | | try!(transmit( [INFO] [stderr] 154 | | &Event::GameOver(Some(c), GameOverReason::DeclareWinning), [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/environment.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match action { [INFO] [stderr] 177 | | Action::Ready(c) => { [INFO] [stderr] 178 | | if c == Color::Black { [INFO] [stderr] 179 | | state.0 = true; [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => { /* ignore other events. */ } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | if let Action::Ready(c) = action { [INFO] [stderr] 177 | if c == Color::Black { [INFO] [stderr] 178 | state.0 = true; [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | state.1 = true [INFO] [stderr] 181 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/environment.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | let mut game = Game::new(tc.clone()); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/board.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 94 | | self.on_new_turn(&game, stats).unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | let bar = ProgressBar::new_spinner(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/csa.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 97 | | self.record.black_player = Some(game.black_player.to_string()); [INFO] [stderr] 98 | | self.record.white_player = Some(game.white_player.to_string()); [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/csa.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 109 | | if let Some(last_move) = game.pos.move_history().last() { [INFO] [stderr] 110 | | self.record.moves.push(MoveRecord { [INFO] [stderr] 111 | | action: convert_move_to_action( [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/csa.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | / match self.current_bar { [INFO] [stderr] 120 | | Some(ref bar) => { [INFO] [stderr] 121 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 120 | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/csa.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / match self.current_bar { [INFO] [stderr] 144 | | Some(ref bar) => { [INFO] [stderr] 145 | | bar.finish_and_clear(); [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | None => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 144 | bar.finish_and_clear(); [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let bar = ProgressBar::new_spinner(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/simple.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 34 | | match self.current_bar { [INFO] [stderr] 35 | | Some(ref bar) => { [INFO] [stderr] 36 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/simple.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | / match self.current_bar { [INFO] [stderr] 35 | | Some(ref bar) => { [INFO] [stderr] 36 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | None => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 35 | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:35:34 [INFO] [stderr] | [INFO] [stderr] 35 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/simple.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match self.current_bar { [INFO] [stderr] 44 | | Some(ref bar) => { [INFO] [stderr] 45 | | let result = match winner { [INFO] [stderr] 46 | | Some(c) => { [INFO] [stderr] ... | [INFO] [stderr] 54 | | None => {} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 44 | let result = match winner { [INFO] [stderr] 45 | Some(c) => { [INFO] [stderr] 46 | let name = if c == Color::Black { "Black" } else { "White" }; [INFO] [stderr] 47 | format!("{} won the game. ({:?})", name, reason) [INFO] [stderr] 48 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:44:30 [INFO] [stderr] | [INFO] [stderr] 44 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/player/engine.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | write_hook: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/player/engine.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | read_hook: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player/engine.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | / match value { [INFO] [stderr] 57 | | &OptionKind::Check { default: Some(f) } => { [INFO] [stderr] 58 | | if f { "true" } else { "false" }.to_string() [INFO] [stderr] 59 | | } [INFO] [stderr] ... | [INFO] [stderr] 67 | | _ => String::new(), [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *value { [INFO] [stderr] 57 | OptionKind::Check { default: Some(f) } => { [INFO] [stderr] 58 | if f { "true" } else { "false" }.to_string() [INFO] [stderr] 59 | } [INFO] [stderr] 60 | OptionKind::Spin { default: Some(ref n), .. } => n.to_string(), [INFO] [stderr] 61 | OptionKind::Combo { default: Some(ref s), .. } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | let color = self.color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | let ponder = self.ponder.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ponder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | / if let Some(pending) = pending.lock().ok() { [INFO] [stderr] 144 | | if let Some(_) = *pending { [INFO] [stderr] 145 | | try!(action_out.send(Action::RequestState)); [INFO] [stderr] 146 | | continue; [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(pending)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/player/engine.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(_) = *pending { [INFO] [stderr] | _____________________________________- ^^^^^^^ [INFO] [stderr] 145 | | try!(action_out.send(Action::RequestState)); [INFO] [stderr] 146 | | continue; [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if *pending.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:151:37 [INFO] [stderr] | [INFO] [stderr] 151 | / if let Some(mut guard) = pondering.lock().ok() { [INFO] [stderr] 152 | | if let Some(ref ponder_move) = *ponder_move { [INFO] [stderr] 153 | | if let Some(ponder_move) = Move::from_sfen(ponder_move) { [INFO] [stderr] 154 | | *guard = Some(ponder_move); [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player/engine.rs:174:58 [INFO] [stderr] | [INFO] [stderr] 174 | v.iter().find(|item| match *item { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 175 | | &InfoParams::Score(_, _) => true, [INFO] [stderr] 176 | | _ => false, [INFO] [stderr] 177 | | }) { [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | v.iter().find(|item| match *(*item) { [INFO] [stderr] 175 | InfoParams::Score(_, _) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/player/engine.rs:178:37 [INFO] [stderr] | [INFO] [stderr] 178 | / match *score_entry { [INFO] [stderr] 179 | | InfoParams::Score(val, ScoreKind::CpExact) => { [INFO] [stderr] 180 | | score.store(val as isize, Ordering::Relaxed) [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | _ => {} [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let InfoParams::Score(val, ScoreKind::CpExact) = *score_entry { [INFO] [stderr] 179 | score.store(val as isize, Ordering::Relaxed) [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let color = self.color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 240 | | if game.pos.side_to_move() == color { [INFO] [stderr] 241 | | if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 242 | | if let Some(ponder_move) = *guard { [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | / if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 242 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 243 | | if let Some(last) = game.pos.move_history().last() { [INFO] [stderr] 244 | | if *last == ponder_move { [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:250:49 [INFO] [stderr] | [INFO] [stderr] 250 | / if let Some(mut guard2) = pending.lock() [INFO] [stderr] 251 | | .ok() { [INFO] [stderr] 252 | | *guard2 = Some(()); [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut guard2)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:265:33 [INFO] [stderr] | [INFO] [stderr] 265 | / if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 266 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 267 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] 268 | | try!(write(&GuiCommand::Position(format!("{} {}", [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 280 | | if game.pos.side_to_move() == color { [INFO] [stderr] 281 | | if let Some(mut data) = pending.lock().ok() { [INFO] [stderr] 282 | | *data = None; [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:281:33 [INFO] [stderr] | [INFO] [stderr] 281 | / if let Some(mut data) = pending.lock().ok() { [INFO] [stderr] 282 | | *data = None; [INFO] [stderr] 283 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] 284 | | try!(write(&GuiCommand::Position(sfen.to_string()))); [INFO] [stderr] 285 | | try!(write(&GuiCommand::Go(build_think_params(&game.time)))); [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut data)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | .expect(&format!("failed to open the config file at {}", config_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open the config file at {}", config_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / if let Some(mut game) = shared_game.write().ok() { [INFO] [stderr] 79 | | game.turn_start_time = Instant::now(); [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:34 [INFO] [stderr] | [INFO] [stderr] 106 | let mut game = Game::new(config.time.to_time_control().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.time.to_time_control()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | / if let Some(mut game) = shared_game.write().ok() { [INFO] [stderr] 92 | | if c != game.pos.side_to_move() { [INFO] [stderr] 93 | | try!(transmit( [INFO] [stderr] 94 | | &Event::GameOver(Some(c), GameOverReason::IllegalMove), [INFO] [stderr] ... | [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/environment.rs:100:25 [INFO] [stderr] | [INFO] [stderr] 100 | / match game.time.consume(c, elapsed) { [INFO] [stderr] 101 | | true => {} [INFO] [stderr] 102 | | false => { [INFO] [stderr] 103 | | try!(transmit( [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 100 | if !game.time.consume(c, elapsed) { [INFO] [stderr] 101 | try!(transmit( [INFO] [stderr] 102 | &Event::GameOver(Some(c.flip()), GameOverReason::OutOfTime), [INFO] [stderr] 103 | )); [INFO] [stderr] 104 | break; [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 136 | | if c != game.pos.side_to_move() { [INFO] [stderr] 137 | | try!(transmit(&Event::GameOver( [INFO] [stderr] 138 | | Some(c.flip()), [INFO] [stderr] ... | [INFO] [stderr] 147 | | break; [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / match event { [INFO] [stderr] 140 | | Event::GameOver(winner, _) => { [INFO] [stderr] 141 | | results.record_game(winner); [INFO] [stderr] 142 | | if num_games == results.finished_games() { [INFO] [stderr] ... | [INFO] [stderr] 146 | | _ => {} [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | if let Event::GameOver(winner, _) = event { [INFO] [stderr] 140 | results.record_game(winner); [INFO] [stderr] 141 | if num_games == results.finished_games() { [INFO] [stderr] 142 | break; [INFO] [stderr] 143 | } [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/environment.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 152 | | if game.pos.try_declare_winning(c) { [INFO] [stderr] 153 | | try!(transmit( [INFO] [stderr] 154 | | &Event::GameOver(Some(c), GameOverReason::DeclareWinning), [INFO] [stderr] ... | [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/environment.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match action { [INFO] [stderr] 177 | | Action::Ready(c) => { [INFO] [stderr] 178 | | if c == Color::Black { [INFO] [stderr] 179 | | state.0 = true; [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => { /* ignore other events. */ } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | if let Action::Ready(c) = action { [INFO] [stderr] 177 | if c == Color::Black { [INFO] [stderr] 178 | state.0 = true; [INFO] [stderr] 179 | } else { [INFO] [stderr] 180 | state.1 = true [INFO] [stderr] 181 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/environment.rs:259:34 [INFO] [stderr] | [INFO] [stderr] 259 | let mut game = Game::new(tc.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/board.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 94 | | self.on_new_turn(&game, stats).unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | let bar = ProgressBar::new_spinner(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/csa.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 97 | | self.record.black_player = Some(game.black_player.to_string()); [INFO] [stderr] 98 | | self.record.white_player = Some(game.white_player.to_string()); [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/csa.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 109 | | if let Some(last_move) = game.pos.move_history().last() { [INFO] [stderr] 110 | | self.record.moves.push(MoveRecord { [INFO] [stderr] 111 | | action: convert_move_to_action( [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/csa.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | / match self.current_bar { [INFO] [stderr] 120 | | Some(ref bar) => { [INFO] [stderr] 121 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 120 | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:120:34 [INFO] [stderr] | [INFO] [stderr] 120 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/csa.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | / match self.current_bar { [INFO] [stderr] 144 | | Some(ref bar) => { [INFO] [stderr] 145 | | bar.finish_and_clear(); [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | None => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 143 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 144 | bar.finish_and_clear(); [INFO] [stderr] 145 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/csa.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let bar = ProgressBar::new_spinner(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/reporter/simple.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / if let Some(game) = game.read().ok() { [INFO] [stderr] 34 | | match self.current_bar { [INFO] [stderr] 35 | | Some(ref bar) => { [INFO] [stderr] 36 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/simple.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | / match self.current_bar { [INFO] [stderr] 35 | | Some(ref bar) => { [INFO] [stderr] 36 | | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | None => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 35 | bar.set_message(&format!("Move #{}", game.pos.ply())); [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:35:34 [INFO] [stderr] | [INFO] [stderr] 35 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reporter/simple.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match self.current_bar { [INFO] [stderr] 44 | | Some(ref bar) => { [INFO] [stderr] 45 | | let result = match winner { [INFO] [stderr] 46 | | Some(c) => { [INFO] [stderr] ... | [INFO] [stderr] 54 | | None => {} [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(ref bar) = self.current_bar { [INFO] [stderr] 44 | let result = match winner { [INFO] [stderr] 45 | Some(c) => { [INFO] [stderr] 46 | let name = if c == Color::Black { "Black" } else { "White" }; [INFO] [stderr] 47 | format!("{} won the game. ({:?})", name, reason) [INFO] [stderr] 48 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/reporter/simple.rs:44:30 [INFO] [stderr] | [INFO] [stderr] 44 | Some(ref bar) => { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/player/engine.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | write_hook: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/player/engine.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | read_hook: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player/engine.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | / match value { [INFO] [stderr] 57 | | &OptionKind::Check { default: Some(f) } => { [INFO] [stderr] 58 | | if f { "true" } else { "false" }.to_string() [INFO] [stderr] 59 | | } [INFO] [stderr] ... | [INFO] [stderr] 67 | | _ => String::new(), [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *value { [INFO] [stderr] 57 | OptionKind::Check { default: Some(f) } => { [INFO] [stderr] 58 | if f { "true" } else { "false" }.to_string() [INFO] [stderr] 59 | } [INFO] [stderr] 60 | OptionKind::Spin { default: Some(ref n), .. } => n.to_string(), [INFO] [stderr] 61 | OptionKind::Combo { default: Some(ref s), .. } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | let color = self.color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | let ponder = self.ponder.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.ponder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:143:33 [INFO] [stderr] | [INFO] [stderr] 143 | / if let Some(pending) = pending.lock().ok() { [INFO] [stderr] 144 | | if let Some(_) = *pending { [INFO] [stderr] 145 | | try!(action_out.send(Action::RequestState)); [INFO] [stderr] 146 | | continue; [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(pending)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/player/engine.rs:144:44 [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(_) = *pending { [INFO] [stderr] | _____________________________________- ^^^^^^^ [INFO] [stderr] 145 | | try!(action_out.send(Action::RequestState)); [INFO] [stderr] 146 | | continue; [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________________________________- help: try this: `if *pending.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:151:37 [INFO] [stderr] | [INFO] [stderr] 151 | / if let Some(mut guard) = pondering.lock().ok() { [INFO] [stderr] 152 | | if let Some(ref ponder_move) = *ponder_move { [INFO] [stderr] 153 | | if let Some(ponder_move) = Move::from_sfen(ponder_move) { [INFO] [stderr] 154 | | *guard = Some(ponder_move); [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player/engine.rs:174:58 [INFO] [stderr] | [INFO] [stderr] 174 | v.iter().find(|item| match *item { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 175 | | &InfoParams::Score(_, _) => true, [INFO] [stderr] 176 | | _ => false, [INFO] [stderr] 177 | | }) { [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | v.iter().find(|item| match *(*item) { [INFO] [stderr] 175 | InfoParams::Score(_, _) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/player/engine.rs:178:37 [INFO] [stderr] | [INFO] [stderr] 178 | / match *score_entry { [INFO] [stderr] 179 | | InfoParams::Score(val, ScoreKind::CpExact) => { [INFO] [stderr] 180 | | score.store(val as isize, Ordering::Relaxed) [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | _ => {} [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let InfoParams::Score(val, ScoreKind::CpExact) = *score_entry { [INFO] [stderr] 179 | score.store(val as isize, Ordering::Relaxed) [INFO] [stderr] 180 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/player/engine.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | let color = self.color.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 240 | | if game.pos.side_to_move() == color { [INFO] [stderr] 241 | | if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 242 | | if let Some(ponder_move) = *guard { [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:241:33 [INFO] [stderr] | [INFO] [stderr] 241 | / if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 242 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 243 | | if let Some(last) = game.pos.move_history().last() { [INFO] [stderr] 244 | | if *last == ponder_move { [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:250:49 [INFO] [stderr] | [INFO] [stderr] 250 | / if let Some(mut guard2) = pending.lock() [INFO] [stderr] 251 | | .ok() { [INFO] [stderr] 252 | | *guard2 = Some(()); [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut guard2)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:265:33 [INFO] [stderr] | [INFO] [stderr] 265 | / if let Some(guard) = pondering.lock().ok() { [INFO] [stderr] 266 | | if let Some(ponder_move) = *guard { [INFO] [stderr] 267 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] 268 | | try!(write(&GuiCommand::Position(format!("{} {}", [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(guard)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | / if let Some(game) = shared_game.read().ok() { [INFO] [stderr] 280 | | if game.pos.side_to_move() == color { [INFO] [stderr] 281 | | if let Some(mut data) = pending.lock().ok() { [INFO] [stderr] 282 | | *data = None; [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(game)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/player/engine.rs:281:33 [INFO] [stderr] | [INFO] [stderr] 281 | / if let Some(mut data) = pending.lock().ok() { [INFO] [stderr] 282 | | *data = None; [INFO] [stderr] 283 | | let sfen = game.pos.to_sfen(); [INFO] [stderr] 284 | | try!(write(&GuiCommand::Position(sfen.to_string()))); [INFO] [stderr] 285 | | try!(write(&GuiCommand::Go(build_think_params(&game.time)))); [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut data)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:59:14 [INFO] [stderr] | [INFO] [stderr] 59 | .expect(&format!("failed to open the config file at {}", config_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open the config file at {}", config_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:34 [INFO] [stderr] | [INFO] [stderr] 106 | let mut game = Game::new(config.time.to_time_control().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.time.to_time_control()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | / match event { [INFO] [stderr] 140 | | Event::GameOver(winner, _) => { [INFO] [stderr] 141 | | results.record_game(winner); [INFO] [stderr] 142 | | if num_games == results.finished_games() { [INFO] [stderr] ... | [INFO] [stderr] 146 | | _ => {} [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | if let Event::GameOver(winner, _) = event { [INFO] [stderr] 140 | results.record_game(winner); [INFO] [stderr] 141 | if num_games == results.finished_games() { [INFO] [stderr] 142 | break; [INFO] [stderr] 143 | } [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.43s [INFO] running `"docker" "inspect" "49e0e1c87537c1e9b77788e85449543cb13324736b9f28a455fd9c487e6ef86f"` [INFO] running `"docker" "rm" "-f" "49e0e1c87537c1e9b77788e85449543cb13324736b9f28a455fd9c487e6ef86f"` [INFO] [stdout] 49e0e1c87537c1e9b77788e85449543cb13324736b9f28a455fd9c487e6ef86f