[INFO] crate users 0.8.1 is already in cache [INFO] extracting crate users 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/users/0.8.1 [INFO] extracting crate users 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/users/0.8.1 [INFO] validating manifest of users-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of users-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing users-0.8.1 [INFO] finished frobbing users-0.8.1 [INFO] frobbed toml for users-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/users/0.8.1/Cargo.toml [INFO] started frobbing users-0.8.1 [INFO] finished frobbing users-0.8.1 [INFO] frobbed toml for users-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/users/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting users-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/users/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5ade04b27f2337d5b572e15c6fec5f27dfd6cbceee8dc588d0a659f2664e1bd [INFO] running `"docker" "start" "-a" "f5ade04b27f2337d5b572e15c6fec5f27dfd6cbceee8dc588d0a659f2664e1bd"` [INFO] [stderr] Checking users v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: trivial numeric cast: `u32` as `u32` [INFO] [stderr] --> src/base.rs:390:46 [INFO] [stderr] | [INFO] [stderr] 390 | .filter_map(|i| get_group_by_gid(i as gid_t)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | #![warn(trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: cast can be replaced by coercion; this might require a temporary variable [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base.rs:355:50 [INFO] [stderr] | [INFO] [stderr] 355 | .filter_map(|i| get_group_by_gid(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_group_by_gid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: trivial numeric cast: `u32` as `u32` [INFO] [stderr] --> src/base.rs:390:46 [INFO] [stderr] | [INFO] [stderr] 390 | .filter_map(|i| get_group_by_gid(i as gid_t)) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | #![warn(trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: cast can be replaced by coercion; this might require a temporary variable [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base.rs:355:50 [INFO] [stderr] | [INFO] [stderr] 355 | .filter_map(|i| get_group_by_gid(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_group_by_gid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/base.rs:795:17 [INFO] [stderr] | [INFO] [stderr] 795 | assert!(groups.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!groups.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.25s [INFO] running `"docker" "inspect" "f5ade04b27f2337d5b572e15c6fec5f27dfd6cbceee8dc588d0a659f2664e1bd"` [INFO] running `"docker" "rm" "-f" "f5ade04b27f2337d5b572e15c6fec5f27dfd6cbceee8dc588d0a659f2664e1bd"` [INFO] [stdout] f5ade04b27f2337d5b572e15c6fec5f27dfd6cbceee8dc588d0a659f2664e1bd