[INFO] crate urls2disk 0.1.1 is already in cache
[INFO] extracting crate urls2disk 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/urls2disk/0.1.1
[INFO] extracting crate urls2disk 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urls2disk/0.1.1
[INFO] validating manifest of urls2disk-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of urls2disk-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing urls2disk-0.1.1
[INFO] finished frobbing urls2disk-0.1.1
[INFO] frobbed toml for urls2disk-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/urls2disk/0.1.1/Cargo.toml
[INFO] started frobbing urls2disk-0.1.1
[INFO] finished frobbing urls2disk-0.1.1
[INFO] frobbed toml for urls2disk-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urls2disk/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting urls2disk-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/urls2disk/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 714673f2d7a14f7bf145a3f941b33605be514da16227523336164ae679dcf2ff
[INFO] running `"docker" "start" "-a" "714673f2d7a14f7bf145a3f941b33605be514da16227523336164ae679dcf2ff"`
[INFO] [stderr]     Checking urls2disk v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]  --> src/utils.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     millis
[INFO] [stderr]   |     ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]  --> src/utils.rs:6:18
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let millis = (seconds * 1_000) + (nanos / 1_000_000);
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]  --> src/utils.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 |     millis
[INFO] [stderr]   |     ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]  --> src/utils.rs:6:18
[INFO] [stderr]   |
[INFO] [stderr] 6 |     let millis = (seconds * 1_000) + (nanos / 1_000_000);
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     requests: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     threads_cpu: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     threads_io: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:26:23
[INFO] [stderr]    |
[INFO] [stderr] 26 |             requests: Mutex::new(0),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:28:26
[INFO] [stderr]    |
[INFO] [stderr] 28 |             threads_cpu: Mutex::new(0),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |             threads_io: Mutex::new(0),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut requests = self.requests.lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:54:28
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let mut requests = self.requests.lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:62:31
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let mut threads_cpu = self.threads_cpu.lock().unwrap();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:70:31
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let mut threads_cpu = self.threads_cpu.lock().unwrap();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:75:30
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut threads_io = self.threads_io.lock().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:83:30
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let mut threads_io = self.threads_io.lock().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/utils.rs:5:17
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let nanos = duration.subsec_nanos() as u64;
[INFO] [stderr]   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `test_duration_to_millis`
[INFO] [stderr]   --> src/utils.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     fn test_duration_to_millis() {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     requests: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     threads_cpu: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     threads_io: Mutex<usize>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:26:23
[INFO] [stderr]    |
[INFO] [stderr] 26 |             requests: Mutex::new(0),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:28:26
[INFO] [stderr]    |
[INFO] [stderr] 28 |             threads_cpu: Mutex::new(0),
[INFO] [stderr]    |                          ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |             threads_io: Mutex::new(0),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut requests = self.requests.lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:54:28
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let mut requests = self.requests.lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:62:31
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let mut threads_cpu = self.threads_cpu.lock().unwrap();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:70:31
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let mut threads_cpu = self.threads_cpu.lock().unwrap();
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:75:30
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let mut threads_io = self.threads_io.lock().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/semaphore.rs:83:30
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let mut threads_io = self.threads_io.lock().unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/utils.rs:5:17
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let nanos = duration.subsec_nanos() as u64;
[INFO] [stderr]   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.11s
[INFO] running `"docker" "inspect" "714673f2d7a14f7bf145a3f941b33605be514da16227523336164ae679dcf2ff"`
[INFO] running `"docker" "rm" "-f" "714673f2d7a14f7bf145a3f941b33605be514da16227523336164ae679dcf2ff"`
[INFO] [stdout] 714673f2d7a14f7bf145a3f941b33605be514da16227523336164ae679dcf2ff