[INFO] crate urlencoded 0.6.0 is already in cache [INFO] extracting crate urlencoded 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/urlencoded/0.6.0 [INFO] extracting crate urlencoded 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urlencoded/0.6.0 [INFO] validating manifest of urlencoded-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of urlencoded-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing urlencoded-0.6.0 [INFO] finished frobbing urlencoded-0.6.0 [INFO] frobbed toml for urlencoded-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/urlencoded/0.6.0/Cargo.toml [INFO] started frobbing urlencoded-0.6.0 [INFO] finished frobbing urlencoded-0.6.0 [INFO] frobbed toml for urlencoded-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urlencoded/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting urlencoded-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/urlencoded/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd24118846b794416288385ae247a0db4e7dad9cd6a036bfd42271f9743afe9b [INFO] running `"docker" "start" "-a" "fd24118846b794416288385ae247a0db4e7dad9cd6a036bfd42271f9743afe9b"` [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking persistent v0.4.0 [INFO] [stderr] Checking bodyparser v0.8.0 [INFO] [stderr] Checking urlencoded v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | .map_err(|e| UrlDecodingError::BodyError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UrlDecodingError::BodyError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|x| x.unwrap_or("".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | .map_err(|e| UrlDecodingError::BodyError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UrlDecodingError::BodyError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:97:24 [INFO] [stderr] | [INFO] [stderr] 97 | .map(|x| x.unwrap_or("".to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.57s [INFO] running `"docker" "inspect" "fd24118846b794416288385ae247a0db4e7dad9cd6a036bfd42271f9743afe9b"` [INFO] running `"docker" "rm" "-f" "fd24118846b794416288385ae247a0db4e7dad9cd6a036bfd42271f9743afe9b"` [INFO] [stdout] fd24118846b794416288385ae247a0db4e7dad9cd6a036bfd42271f9743afe9b