[INFO] crate uri_parser 0.2.0 is already in cache [INFO] extracting crate uri_parser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/uri_parser/0.2.0 [INFO] extracting crate uri_parser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uri_parser/0.2.0 [INFO] validating manifest of uri_parser-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uri_parser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uri_parser-0.2.0 [INFO] finished frobbing uri_parser-0.2.0 [INFO] frobbed toml for uri_parser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/uri_parser/0.2.0/Cargo.toml [INFO] started frobbing uri_parser-0.2.0 [INFO] finished frobbing uri_parser-0.2.0 [INFO] frobbed toml for uri_parser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uri_parser/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uri_parser-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uri_parser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc57148819aa8cf5cf976f4926b607985f9c53f375c5b18322e25531420dba8a [INFO] running `"docker" "start" "-a" "bc57148819aa8cf5cf976f4926b607985f9c53f375c5b18322e25531420dba8a"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking uri_parser v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/parser.rs:125:36 [INFO] [stderr] | [INFO] [stderr] 125 | fn tst(u: &[u8], res: URI) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:110:54 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(user(u.as_bytes()), IResult::Done("".as_bytes(), User{name:"ivan", password:None })); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(user(u.as_bytes()), IResult::Done("".as_bytes(), User{name:"ivan", password:Some("heslo") })); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(parse_path(b"/"), IResult::Done("".as_bytes(), Path::new("/"))); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser.rs:152:45 [INFO] [stderr] | [INFO] [stderr] 152 | assert_eq!(scheme(s), IResult::Done(":".as_bytes(), "http")); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b":"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.06s [INFO] running `"docker" "inspect" "bc57148819aa8cf5cf976f4926b607985f9c53f375c5b18322e25531420dba8a"` [INFO] running `"docker" "rm" "-f" "bc57148819aa8cf5cf976f4926b607985f9c53f375c5b18322e25531420dba8a"` [INFO] [stdout] bc57148819aa8cf5cf976f4926b607985f9c53f375c5b18322e25531420dba8a