[INFO] crate urdict 0.3.4 is already in cache [INFO] extracting crate urdict 0.3.4 into work/ex/clippy-test-run/sources/stable/reg/urdict/0.3.4 [INFO] extracting crate urdict 0.3.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urdict/0.3.4 [INFO] validating manifest of urdict-0.3.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of urdict-0.3.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing urdict-0.3.4 [INFO] finished frobbing urdict-0.3.4 [INFO] frobbed toml for urdict-0.3.4 written to work/ex/clippy-test-run/sources/stable/reg/urdict/0.3.4/Cargo.toml [INFO] started frobbing urdict-0.3.4 [INFO] finished frobbing urdict-0.3.4 [INFO] frobbed toml for urdict-0.3.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urdict/0.3.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting urdict-0.3.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/urdict/0.3.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 27c75e68202da2822bfa44e232ebeb023061befb8d6db395f0417b2dbffc76bb [INFO] running `"docker" "start" "-a" "27c75e68202da2822bfa44e232ebeb023061befb8d6db395f0417b2dbffc76bb"` [INFO] [stderr] Checking utf-8 v0.7.5 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking urdict v0.3.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | example: example, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | sounds: sounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | similars: similars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `similars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | example: example, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `example` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | sounds: sounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/page.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | similars: similars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `similars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | if let Some(sounds) = def.sounds { [INFO] [stderr] 78 | | let mut rng = thread_rng(); [INFO] [stderr] 79 | | let sample: Vec<&String> = sample_iter(&mut rng, sounds.iter(), 1).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(sounds) = def.sounds { [INFO] [stderr] 77 | let mut rng = thread_rng(); [INFO] [stderr] 78 | let sample: Vec<&String> = sample_iter(&mut rng, sounds.iter(), 1).unwrap(); [INFO] [stderr] 79 | println!("{}", sample[0]); [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | exit(128); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | stream.write("220 urdict 0.1.0\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dictd.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | let pieces: Vec<&str> = line.trim().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | / stream [INFO] [stderr] 26 | | .write(format!("150 {} definitions retrieved\r\n", 1).as_bytes()) [INFO] [stderr] 27 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | / stream [INFO] [stderr] 30 | | .write(format!("151 \"{}\" urdict", def.word).as_bytes()) [INFO] [stderr] 31 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | / stream [INFO] [stderr] 33 | | .write( [INFO] [stderr] 34 | | format!( [INFO] [stderr] 35 | | " \"Urban Dictionary {} {}\"\r\n", [INFO] [stderr] ... | [INFO] [stderr] 38 | | ) [INFO] [stderr] 39 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | / stream [INFO] [stderr] 41 | | .write(format!("{}\r\n.\r\n", def.def).as_bytes()) [INFO] [stderr] 42 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | / stream [INFO] [stderr] 45 | | .write(format!("150 0 definitions retrieved\r\n").as_bytes()) [INFO] [stderr] 46 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/dictd.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | .write(format!("150 0 definitions retrieved\r\n").as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"150 0 definitions retrieved\r\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | / stream [INFO] [stderr] 55 | | .write( [INFO] [stderr] 56 | | format!("152 {} matches found\r\n", similars.len()).as_bytes(), [INFO] [stderr] 57 | | ) [INFO] [stderr] 58 | | .unwrap(); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | / stream [INFO] [stderr] 61 | | .write(format!("urdict \"{}\"\r\n", s).as_bytes()) [INFO] [stderr] 62 | | .unwrap(); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | stream.write(".\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | stream.write("152 0 matches found\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | stream.write("152 0 matches found\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | stream.write("221 bye\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | / stream [INFO] [stderr] 84 | | .write("110 1 database present\r\n".as_bytes()) [INFO] [stderr] 85 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | / stream [INFO] [stderr] 87 | | .write("urdict \"Urban Dictionary\"\r\n".as_bytes()) [INFO] [stderr] 88 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | stream.write(".\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 19 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `urdict`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 77 | | if let Some(sounds) = def.sounds { [INFO] [stderr] 78 | | let mut rng = thread_rng(); [INFO] [stderr] 79 | | let sample: Vec<&String> = sample_iter(&mut rng, sounds.iter(), 1).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | } else if let Some(sounds) = def.sounds { [INFO] [stderr] 77 | let mut rng = thread_rng(); [INFO] [stderr] 78 | let sample: Vec<&String> = sample_iter(&mut rng, sounds.iter(), 1).unwrap(); [INFO] [stderr] 79 | println!("{}", sample[0]); [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | exit(128); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/page.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | stream.write("220 urdict 0.1.0\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dictd.rs:19:55 [INFO] [stderr] | [INFO] [stderr] 19 | let pieces: Vec<&str> = line.trim().split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | / stream [INFO] [stderr] 26 | | .write(format!("150 {} definitions retrieved\r\n", 1).as_bytes()) [INFO] [stderr] 27 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | / stream [INFO] [stderr] 30 | | .write(format!("151 \"{}\" urdict", def.word).as_bytes()) [INFO] [stderr] 31 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | / stream [INFO] [stderr] 33 | | .write( [INFO] [stderr] 34 | | format!( [INFO] [stderr] 35 | | " \"Urban Dictionary {} {}\"\r\n", [INFO] [stderr] ... | [INFO] [stderr] 38 | | ) [INFO] [stderr] 39 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | / stream [INFO] [stderr] 41 | | .write(format!("{}\r\n.\r\n", def.def).as_bytes()) [INFO] [stderr] 42 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | / stream [INFO] [stderr] 45 | | .write(format!("150 0 definitions retrieved\r\n").as_bytes()) [INFO] [stderr] 46 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/dictd.rs:45:36 [INFO] [stderr] | [INFO] [stderr] 45 | .write(format!("150 0 definitions retrieved\r\n").as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"150 0 definitions retrieved\r\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | / stream [INFO] [stderr] 55 | | .write( [INFO] [stderr] 56 | | format!("152 {} matches found\r\n", similars.len()).as_bytes(), [INFO] [stderr] 57 | | ) [INFO] [stderr] 58 | | .unwrap(); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | / stream [INFO] [stderr] 61 | | .write(format!("urdict \"{}\"\r\n", s).as_bytes()) [INFO] [stderr] 62 | | .unwrap(); [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | stream.write(".\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | stream.write("152 0 matches found\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | stream.write("152 0 matches found\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | stream.write("221 bye\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | / stream [INFO] [stderr] 84 | | .write("110 1 database present\r\n".as_bytes()) [INFO] [stderr] 85 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | / stream [INFO] [stderr] 87 | | .write("urdict \"Urban Dictionary\"\r\n".as_bytes()) [INFO] [stderr] 88 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | stream.write(".\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/dictd.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | stream.write("250 ok\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 19 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `urdict`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "27c75e68202da2822bfa44e232ebeb023061befb8d6db395f0417b2dbffc76bb"` [INFO] running `"docker" "rm" "-f" "27c75e68202da2822bfa44e232ebeb023061befb8d6db395f0417b2dbffc76bb"` [INFO] [stdout] 27c75e68202da2822bfa44e232ebeb023061befb8d6db395f0417b2dbffc76bb