[INFO] crate urban-lookup 1.1.0 is already in cache [INFO] extracting crate urban-lookup 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/urban-lookup/1.1.0 [INFO] extracting crate urban-lookup 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urban-lookup/1.1.0 [INFO] validating manifest of urban-lookup-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of urban-lookup-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing urban-lookup-1.1.0 [INFO] finished frobbing urban-lookup-1.1.0 [INFO] frobbed toml for urban-lookup-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/urban-lookup/1.1.0/Cargo.toml [INFO] started frobbing urban-lookup-1.1.0 [INFO] finished frobbing urban-lookup-1.1.0 [INFO] frobbed toml for urban-lookup-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/urban-lookup/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting urban-lookup-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/urban-lookup/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fb4f65ef7889fec5a8fd78a6c7da1d545a151ec2c77cff3a5ca922089f95948 [INFO] running `"docker" "start" "-a" "2fb4f65ef7889fec5a8fd78a6c7da1d545a151ec2c77cff3a5ca922089f95948"` [INFO] [stderr] Checking urban-lookup v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:48:84 [INFO] [stderr] | [INFO] [stderr] 48 | print_with_readability( Explanation { word: String::from(word) , expl: String::from(expl) } ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `expl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | let headline = format!(" {} ", String::from(word).to_ascii_uppercase()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | line.push_str(&format!("{}", xmlesc(&word))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `xmlesc(&word).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | let error_rx = Regex::new(r"Sorry, we couldn't find").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | if let Some(_) = error_rx.captures(&response) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 156 | | // word does not exist [INFO] [stderr] 157 | | return None; [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____- help: try this: `if error_rx.captures(&response).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:48:84 [INFO] [stderr] | [INFO] [stderr] 48 | print_with_readability( Explanation { word: String::from(word) , expl: String::from(expl) } ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `expl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:74:40 [INFO] [stderr] | [INFO] [stderr] 74 | let headline = format!(" {} ", String::from(word).to_ascii_uppercase()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | line.push_str(&format!("{}", xmlesc(&word))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `xmlesc(&word).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:151:31 [INFO] [stderr] | [INFO] [stderr] 151 | let error_rx = Regex::new(r"Sorry, we couldn't find").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | if let Some(_) = error_rx.captures(&response) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 156 | | // word does not exist [INFO] [stderr] 157 | | return None; [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____- help: try this: `if error_rx.captures(&response).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.00s [INFO] running `"docker" "inspect" "2fb4f65ef7889fec5a8fd78a6c7da1d545a151ec2c77cff3a5ca922089f95948"` [INFO] running `"docker" "rm" "-f" "2fb4f65ef7889fec5a8fd78a6c7da1d545a151ec2c77cff3a5ca922089f95948"` [INFO] [stdout] 2fb4f65ef7889fec5a8fd78a6c7da1d545a151ec2c77cff3a5ca922089f95948