[INFO] crate ur20-modbus 0.2.0 is already in cache [INFO] extracting crate ur20-modbus 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/ur20-modbus/0.2.0 [INFO] extracting crate ur20-modbus 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ur20-modbus/0.2.0 [INFO] validating manifest of ur20-modbus-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ur20-modbus-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ur20-modbus-0.2.0 [INFO] finished frobbing ur20-modbus-0.2.0 [INFO] frobbed toml for ur20-modbus-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/ur20-modbus/0.2.0/Cargo.toml [INFO] started frobbing ur20-modbus-0.2.0 [INFO] finished frobbing ur20-modbus-0.2.0 [INFO] frobbed toml for ur20-modbus-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ur20-modbus/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ur20-modbus-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ur20-modbus/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf920fb92fd21fa6e3b4810d2f40478b4dccc59ffc9a9b85c4f94ed36491997b [INFO] running `"docker" "start" "-a" "bf920fb92fd21fa6e3b4810d2f40478b4dccc59ffc9a9b85c4f94ed36491997b"` [INFO] [stderr] Checking ur20 v0.5.0 [INFO] [stderr] Checking tokio-modbus v0.2.3 [INFO] [stderr] Checking ur20-modbus v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | coupler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | let coupler = Client::connect_tcp(&addr, &handle) [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | .and_then(|client| { [INFO] [stderr] 57 | | let coupler_id = read_coupler_id(&client); [INFO] [stderr] 58 | | let cnt = read_module_count(&client); [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | coupler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | let coupler = Client::connect_tcp(&addr, &handle) [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | .and_then(|client| { [INFO] [stderr] 57 | | let coupler_id = read_coupler_id(&client); [INFO] [stderr] 58 | | let cnt = read_module_count(&client); [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.25s [INFO] running `"docker" "inspect" "bf920fb92fd21fa6e3b4810d2f40478b4dccc59ffc9a9b85c4f94ed36491997b"` [INFO] running `"docker" "rm" "-f" "bf920fb92fd21fa6e3b4810d2f40478b4dccc59ffc9a9b85c4f94ed36491997b"` [INFO] [stdout] bf920fb92fd21fa6e3b4810d2f40478b4dccc59ffc9a9b85c4f94ed36491997b