[INFO] crate uq 0.1.2 is already in cache [INFO] extracting crate uq 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/uq/0.1.2 [INFO] extracting crate uq 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uq/0.1.2 [INFO] validating manifest of uq-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uq-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uq-0.1.2 [INFO] finished frobbing uq-0.1.2 [INFO] frobbed toml for uq-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/uq/0.1.2/Cargo.toml [INFO] started frobbing uq-0.1.2 [INFO] finished frobbing uq-0.1.2 [INFO] frobbed toml for uq-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uq/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uq-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uq/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db9937c0036e5f7ec7143624d51d6f9fe5ce6d86e46bd136e24769ecca6c479b [INFO] running `"docker" "start" "-a" "db9937c0036e5f7ec7143624d51d6f9fe5ce6d86e46bd136e24769ecca6c479b"` [INFO] [stderr] Checking uq v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return Box::new(move |line| lines.insert(line.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(move |line| lines.insert(line.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return Box::new(move |line| { [INFO] [stderr] 36 | | if lines.insert(line.clone()) { [INFO] [stderr] 37 | | if lines.len() > capacity { [INFO] [stderr] 38 | | panic!("Cache capacity exceeded!"); [INFO] [stderr] ... | [INFO] [stderr] 42 | | return false; [INFO] [stderr] 43 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Box::new(move |line| { [INFO] [stderr] 36 | if lines.insert(line.clone()) { [INFO] [stderr] 37 | if lines.len() > capacity { [INFO] [stderr] 38 | panic!("Cache capacity exceeded!"); [INFO] [stderr] 39 | } [INFO] [stderr] 40 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return Box::new(move |line| { [INFO] [stderr] 51 | | if set.insert(line.clone()) { [INFO] [stderr] 52 | | if set.len() > capacity { [INFO] [stderr] 53 | | set.remove(&queue.pop_front().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 59 | | return false; [INFO] [stderr] 60 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | Box::new(move |line| { [INFO] [stderr] 51 | if set.insert(line.clone()) { [INFO] [stderr] 52 | if set.len() > capacity { [INFO] [stderr] 53 | set.remove(&queue.pop_front().unwrap()); [INFO] [stderr] 54 | } [INFO] [stderr] 55 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return Box::new(move |line| lines.insert(line.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(move |line| lines.insert(line.clone()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return Box::new(move |line| { [INFO] [stderr] 36 | | if lines.insert(line.clone()) { [INFO] [stderr] 37 | | if lines.len() > capacity { [INFO] [stderr] 38 | | panic!("Cache capacity exceeded!"); [INFO] [stderr] ... | [INFO] [stderr] 42 | | return false; [INFO] [stderr] 43 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | Box::new(move |line| { [INFO] [stderr] 36 | if lines.insert(line.clone()) { [INFO] [stderr] 37 | if lines.len() > capacity { [INFO] [stderr] 38 | panic!("Cache capacity exceeded!"); [INFO] [stderr] 39 | } [INFO] [stderr] 40 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / return Box::new(move |line| { [INFO] [stderr] 51 | | if set.insert(line.clone()) { [INFO] [stderr] 52 | | if set.len() > capacity { [INFO] [stderr] 53 | | set.remove(&queue.pop_front().unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 59 | | return false; [INFO] [stderr] 60 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | Box::new(move |line| { [INFO] [stderr] 51 | if set.insert(line.clone()) { [INFO] [stderr] 52 | if set.len() > capacity { [INFO] [stderr] 53 | set.remove(&queue.pop_front().unwrap()); [INFO] [stderr] 54 | } [INFO] [stderr] 55 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "db9937c0036e5f7ec7143624d51d6f9fe5ce6d86e46bd136e24769ecca6c479b"` [INFO] running `"docker" "rm" "-f" "db9937c0036e5f7ec7143624d51d6f9fe5ce6d86e46bd136e24769ecca6c479b"` [INFO] [stdout] db9937c0036e5f7ec7143624d51d6f9fe5ce6d86e46bd136e24769ecca6c479b