[INFO] crate unsafe-unicorn 0.0.1 is already in cache [INFO] extracting crate unsafe-unicorn 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/unsafe-unicorn/0.0.1 [INFO] extracting crate unsafe-unicorn 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unsafe-unicorn/0.0.1 [INFO] validating manifest of unsafe-unicorn-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unsafe-unicorn-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unsafe-unicorn-0.0.1 [INFO] removed 3 missing examples [INFO] finished frobbing unsafe-unicorn-0.0.1 [INFO] frobbed toml for unsafe-unicorn-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/unsafe-unicorn/0.0.1/Cargo.toml [INFO] started frobbing unsafe-unicorn-0.0.1 [INFO] removed 3 missing examples [INFO] finished frobbing unsafe-unicorn-0.0.1 [INFO] frobbed toml for unsafe-unicorn-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unsafe-unicorn/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unsafe-unicorn-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unsafe-unicorn/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 119c50927380ab453fbf87be1c240b776bbe41ca380c1e554dde12c9d532349f [INFO] running `"docker" "start" "-a" "119c50927380ab453fbf87be1c240b776bbe41ca380c1e554dde12c9d532349f"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/stylo.rs [INFO] [stderr] * /opt/crater/workdir/examples/cloc.rs [INFO] [stderr] * /opt/crater/workdir/examples/cloc_git.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling curl-sys v0.4.16 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking unsafe-unicorn v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:112:24 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 113 | | if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 114 | | match self.verbose { [INFO] [stderr] 115 | | ClocVerbosity::File => { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 113 | match self.verbose { [INFO] [stderr] 114 | ClocVerbosity::File => { [INFO] [stderr] 115 | let path = p.path(); [INFO] [stderr] 116 | let c = ClocStats::from_file(path.to_str().unwrap()).unwrap(); [INFO] [stderr] 117 | self.add_stats(c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 290 | | if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 291 | | c.cloc_file(&mut File::open(p.path()).expect("Couldn't open file")); [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | } else if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 290 | c.cloc_file(&mut File::open(p.path()).expect("Couldn't open file")); [INFO] [stderr] 291 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | r"```", // block comment [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | r"panic", //panic [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: item `Cloc` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / impl Cloc { [INFO] [stderr] 59 | | pub fn new() -> Cloc { [INFO] [stderr] 60 | | Cloc { [INFO] [stderr] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cloc` [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Cloc { [INFO] [stderr] 60 | | Cloc { [INFO] [stderr] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stderr] 62 | | stats: vec!(), [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for Cloc { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | !(self.total_fns > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.total_fns <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:331:16 [INFO] [stderr] | [INFO] [stderr] 331 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:112:24 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 113 | | if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 114 | | match self.verbose { [INFO] [stderr] 115 | | ClocVerbosity::File => { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 113 | match self.verbose { [INFO] [stderr] 114 | ClocVerbosity::File => { [INFO] [stderr] 115 | let path = p.path(); [INFO] [stderr] 116 | let c = ClocStats::from_file(path.to_str().unwrap()).unwrap(); [INFO] [stderr] 117 | self.add_stats(c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:289:24 [INFO] [stderr] | [INFO] [stderr] 289 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 290 | | if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 291 | | c.cloc_file(&mut File::open(p.path()).expect("Couldn't open file")); [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 289 | } else if p.path().extension().unwrap_or_default() == "rs" { [INFO] [stderr] 290 | c.cloc_file(&mut File::open(p.path()).expect("Couldn't open file")); [INFO] [stderr] 291 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | r"```", // block comment [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | r"panic", //panic [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: item `Cloc` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / impl Cloc { [INFO] [stderr] 59 | | pub fn new() -> Cloc { [INFO] [stderr] 60 | | Cloc { [INFO] [stderr] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stderr] ... | [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cloc` [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Cloc { [INFO] [stderr] 60 | | Cloc { [INFO] [stderr] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stderr] 62 | | stats: vec!(), [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for Cloc { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | !(self.total_fns > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.total_fns <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:331:16 [INFO] [stderr] | [INFO] [stderr] 331 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.45s [INFO] running `"docker" "inspect" "119c50927380ab453fbf87be1c240b776bbe41ca380c1e554dde12c9d532349f"` [INFO] running `"docker" "rm" "-f" "119c50927380ab453fbf87be1c240b776bbe41ca380c1e554dde12c9d532349f"` [INFO] [stdout] 119c50927380ab453fbf87be1c240b776bbe41ca380c1e554dde12c9d532349f