[INFO] crate unreliable-message 0.1.0 is already in cache [INFO] extracting crate unreliable-message 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/unreliable-message/0.1.0 [INFO] extracting crate unreliable-message 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unreliable-message/0.1.0 [INFO] validating manifest of unreliable-message-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unreliable-message-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unreliable-message-0.1.0 [INFO] finished frobbing unreliable-message-0.1.0 [INFO] frobbed toml for unreliable-message-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/unreliable-message/0.1.0/Cargo.toml [INFO] started frobbing unreliable-message-0.1.0 [INFO] finished frobbing unreliable-message-0.1.0 [INFO] frobbed toml for unreliable-message-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unreliable-message/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unreliable-message-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unreliable-message/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd83ee6e945cdde5577e4e68beded849151cd3593854d6e02a2fdb9ac5b2180d [INFO] running `"docker" "start" "-a" "fd83ee6e945cdde5577e4e68beded849151cd3593854d6e02a2fdb9ac5b2180d"` [INFO] [stderr] Checking unreliable-message v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msgqueue.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | datagram_length: datagram_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datagram_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | max_connection_size: max_connection_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_connection_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | datagram_length: datagram_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datagram_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | replication: replication [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `replication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/msgqueue.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | datagram_length: datagram_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datagram_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | max_connection_size: max_connection_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_connection_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | filter: filter, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | datagram_length: datagram_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `datagram_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/network.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | replication: replication [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `replication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | return Some(stage.merge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(stage.merge())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | return Some(stage.merge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(stage.merge())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/msgqueue.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/msgqueue.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / if self.stages.contains_key(&id) { [INFO] [stderr] 99 | | let ready = { [INFO] [stderr] 100 | | let stage = self.stages.get_mut(&id).unwrap(); [INFO] [stderr] 101 | | self.cur_size += stage.add_chunk(chunk); [INFO] [stderr] ... | [INFO] [stderr] 117 | | return None; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: consider using: `self.stages.entry(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/network.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &ReceiverFilter::Whitelist(ref set) => set.contains(addr), [INFO] [stderr] 47 | | &ReceiverFilter::Blacklist(ref set) => !set.contains(addr) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | ReceiverFilter::Whitelist(ref set) => set.contains(addr), [INFO] [stderr] 47 | ReceiverFilter::Blacklist(ref set) => !set.contains(addr) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/network.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | let slice: Vec<_> = self.v[..].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let max_size = self.max_connection_size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_connection_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | let q = self.queue.entry(from.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `chunk_count` is used as a loop counter. Consider using `for (chunk_count, item) in message[..].chunks((self.datagram_length - MSG_PADDING) as usize).enumerate()` or similar iterators [INFO] [stderr] --> src/network.rs:139:26 [INFO] [stderr] | [INFO] [stderr] 139 | for chunk in message[..].chunks((self.datagram_length - MSG_PADDING) as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/network.rs:161:49 [INFO] [stderr] | [INFO] [stderr] 161 | let bound = bincode::SizeLimit::Bounded(self.datagram_length as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.datagram_length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/msgqueue.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / if self.stages.contains_key(&id) { [INFO] [stderr] 99 | | let ready = { [INFO] [stderr] 100 | | let stage = self.stages.get_mut(&id).unwrap(); [INFO] [stderr] 101 | | self.cur_size += stage.add_chunk(chunk); [INFO] [stderr] ... | [INFO] [stderr] 117 | | return None; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ help: consider using: `self.stages.entry(id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/network.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &ReceiverFilter::Whitelist(ref set) => set.contains(addr), [INFO] [stderr] 47 | | &ReceiverFilter::Blacklist(ref set) => !set.contains(addr) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | ReceiverFilter::Whitelist(ref set) => set.contains(addr), [INFO] [stderr] 47 | ReceiverFilter::Blacklist(ref set) => !set.contains(addr) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/network.rs:64:29 [INFO] [stderr] | [INFO] [stderr] 64 | let slice: Vec<_> = self.v[..].iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let max_size = self.max_connection_size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_connection_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | let q = self.queue.entry(from.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `chunk_count` is used as a loop counter. Consider using `for (chunk_count, item) in message[..].chunks((self.datagram_length - MSG_PADDING) as usize).enumerate()` or similar iterators [INFO] [stderr] --> src/network.rs:139:26 [INFO] [stderr] | [INFO] [stderr] 139 | for chunk in message[..].chunks((self.datagram_length - MSG_PADDING) as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/network.rs:161:49 [INFO] [stderr] | [INFO] [stderr] 161 | let bound = bincode::SizeLimit::Bounded(self.datagram_length as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.datagram_length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/transfer.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | const LOCALHOST: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/transfer.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | let port_1: u16 = args.next().expect("Expected port number") [INFO] [stderr] | _______________________^ [INFO] [stderr] 11 | | .parse().ok().expect("Expected port number to be a number"); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/transfer.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | let port_2: u16 = args.next().expect("Expected port number") [INFO] [stderr] | _______________________^ [INFO] [stderr] 13 | | .parse().ok().expect("Expected port number to be a number"); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/transfer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / match std::io::stdin().read_line(&mut buf) { [INFO] [stderr] 35 | | Ok(_) => { [INFO] [stderr] 36 | | sender.enqueue(buf.into_bytes(), &theirs[..]).unwrap(); [INFO] [stderr] 37 | | buf = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | Err(_) => {} [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Ok(_) = std::io::stdin().read_line(&mut buf) { [INFO] [stderr] 35 | sender.enqueue(buf.into_bytes(), &theirs[..]).unwrap(); [INFO] [stderr] 36 | buf = String::new(); [INFO] [stderr] 37 | sender.send_all().unwrap(); [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.76s [INFO] running `"docker" "inspect" "fd83ee6e945cdde5577e4e68beded849151cd3593854d6e02a2fdb9ac5b2180d"` [INFO] running `"docker" "rm" "-f" "fd83ee6e945cdde5577e4e68beded849151cd3593854d6e02a2fdb9ac5b2180d"` [INFO] [stdout] fd83ee6e945cdde5577e4e68beded849151cd3593854d6e02a2fdb9ac5b2180d