[INFO] crate unjson 0.0.5 is already in cache [INFO] extracting crate unjson 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/unjson/0.0.5 [INFO] extracting crate unjson 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unjson/0.0.5 [INFO] validating manifest of unjson-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unjson-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unjson-0.0.5 [INFO] finished frobbing unjson-0.0.5 [INFO] frobbed toml for unjson-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/unjson/0.0.5/Cargo.toml [INFO] started frobbing unjson-0.0.5 [INFO] finished frobbing unjson-0.0.5 [INFO] frobbed toml for unjson-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unjson/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unjson-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unjson/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a29770ecb8ef5c24c33108b5e374ba66f3f91b0ffb9dba197512556c26b7781 [INFO] running `"docker" "start" "-a" "8a29770ecb8ef5c24c33108b5e374ba66f3f91b0ffb9dba197512556c26b7781"` [INFO] [stderr] Checking serde_json v0.7.4 [INFO] [stderr] Checking unjson v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | _ => { return type_error("array", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("array", self.ty())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:141:20 [INFO] [stderr] | [INFO] [stderr] 141 | _ => { return type_error("array or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("array or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | _ => { return type_error("string", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("string", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:156:20 [INFO] [stderr] | [INFO] [stderr] 156 | _ => { return type_error("string or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("string or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | _ => { return type_error("object", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("object", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | _ => { return type_error("object or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("object or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | _ => { return type_error("boolean", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("boolean", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | _ => { return type_error("boolean", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("boolean", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:193:20 [INFO] [stderr] | [INFO] [stderr] 193 | _ => { return type_error("i64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("i64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | _ => { return type_error("i64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("i64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | _ => { return type_error("u64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("u64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:216:20 [INFO] [stderr] | [INFO] [stderr] 216 | _ => { return type_error("u64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("u64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | _ => { return type_error("f64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("f64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | _ => { return type_error("f64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("f64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:240:20 [INFO] [stderr] | [INFO] [stderr] 240 | _ => { return type_error("number", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("number", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:250:20 [INFO] [stderr] | [INFO] [stderr] 250 | _ => { return type_error("number", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("number", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | _ => { return type_error("array", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("array", self.ty())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:141:20 [INFO] [stderr] | [INFO] [stderr] 141 | _ => { return type_error("array or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("array or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | _ => { return type_error("string", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("string", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:156:20 [INFO] [stderr] | [INFO] [stderr] 156 | _ => { return type_error("string or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("string or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | _ => { return type_error("object", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("object", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | _ => { return type_error("object or null", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("object or null", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | _ => { return type_error("boolean", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("boolean", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | _ => { return type_error("boolean", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("boolean", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:193:20 [INFO] [stderr] | [INFO] [stderr] 193 | _ => { return type_error("i64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("i64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:201:20 [INFO] [stderr] | [INFO] [stderr] 201 | _ => { return type_error("i64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("i64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | _ => { return type_error("u64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("u64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:216:20 [INFO] [stderr] | [INFO] [stderr] 216 | _ => { return type_error("u64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("u64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:223:20 [INFO] [stderr] | [INFO] [stderr] 223 | _ => { return type_error("f64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("f64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:231:20 [INFO] [stderr] | [INFO] [stderr] 231 | _ => { return type_error("f64", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("f64", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:240:20 [INFO] [stderr] | [INFO] [stderr] 240 | _ => { return type_error("number", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("number", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unjson.rs:250:20 [INFO] [stderr] | [INFO] [stderr] 250 | _ => { return type_error("number", self.ty()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("number", self.ty())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 35 | | &Value::I64(ref v) => *v as f64, [INFO] [stderr] 36 | | &Value::U64(ref v) => *v as f64, [INFO] [stderr] 37 | | &Value::F64(ref v) => *v, [INFO] [stderr] 38 | | _ => { return type_error("number", self.ty()); } [INFO] [stderr] 39 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | Ok(match *self { [INFO] [stderr] 35 | Value::I64(ref v) => *v as f64, [INFO] [stderr] 36 | Value::U64(ref v) => *v as f64, [INFO] [stderr] 37 | Value::F64(ref v) => *v, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 44 | | &Value::Null => None, [INFO] [stderr] 45 | | &Value::String(ref s) => Some(&s[..]), [INFO] [stderr] 46 | | _ => { return type_error("string or null", self.ty()); } [INFO] [stderr] 47 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | Ok(match *self { [INFO] [stderr] 44 | Value::Null => None, [INFO] [stderr] 45 | Value::String(ref s) => Some(&s[..]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 52 | | &Value::Null => None, [INFO] [stderr] 53 | | &Value::Array(ref a) => Some(a), [INFO] [stderr] 54 | | _ => { return type_error("array or null", self.ty()); } [INFO] [stderr] 55 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | Ok(match *self { [INFO] [stderr] 52 | Value::Null => None, [INFO] [stderr] 53 | Value::Array(ref a) => Some(a), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 60 | | &Value::Null => None, [INFO] [stderr] 61 | | &Value::Object(ref o) => Some(o), [INFO] [stderr] 62 | | _ => { return type_error("object or null", self.ty()); } [INFO] [stderr] 63 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | Ok(match *self { [INFO] [stderr] 60 | Value::Null => None, [INFO] [stderr] 61 | Value::Object(ref o) => Some(o), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 68 | | &Value::Null => None, [INFO] [stderr] 69 | | &Value::Bool(ref b) => Some(*b), [INFO] [stderr] 70 | | _ => { return type_error("boolean or null", self.ty()); } [INFO] [stderr] 71 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | Ok(match *self { [INFO] [stderr] 68 | Value::Null => None, [INFO] [stderr] 69 | Value::Bool(ref b) => Some(*b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 76 | | &Value::Null => None, [INFO] [stderr] 77 | | &Value::I64(ref v) => Some(*v), [INFO] [stderr] 78 | | _ => { return type_error("i64 or null", self.ty()); } [INFO] [stderr] 79 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | Ok(match *self { [INFO] [stderr] 76 | Value::Null => None, [INFO] [stderr] 77 | Value::I64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | &Value::Null => None, [INFO] [stderr] 85 | | &Value::U64(ref v) => Some(*v), [INFO] [stderr] 86 | | _ => { return type_error("u64 or null", self.ty()); } [INFO] [stderr] 87 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | Ok(match *self { [INFO] [stderr] 84 | Value::Null => None, [INFO] [stderr] 85 | Value::U64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 92 | | &Value::Null => None, [INFO] [stderr] 93 | | &Value::F64(ref v) => Some(*v), [INFO] [stderr] 94 | | _ => { return type_error("f64 or null", self.ty()); } [INFO] [stderr] 95 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | Ok(match *self { [INFO] [stderr] 92 | Value::Null => None, [INFO] [stderr] 93 | Value::F64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 100 | | &Value::Null => None, [INFO] [stderr] 101 | | &Value::I64(ref v) => Some(*v as f64), [INFO] [stderr] 102 | | &Value::U64(ref v) => Some(*v as f64), [INFO] [stderr] 103 | | &Value::F64(ref v) => Some(*v), [INFO] [stderr] 104 | | _ => { return type_error("number or null", self.ty()); } [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | Ok(match *self { [INFO] [stderr] 100 | Value::Null => None, [INFO] [stderr] 101 | Value::I64(ref v) => Some(*v as f64), [INFO] [stderr] 102 | Value::U64(ref v) => Some(*v as f64), [INFO] [stderr] 103 | Value::F64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &Error::TypeMismatch(ref expected, ref ty) => { [INFO] [stderr] 19 | | fmt.write_fmt(format_args!("expected {}, got {}", expected, ty)) [INFO] [stderr] 20 | | } [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | Error::TypeMismatch(ref expected, ref ty) => { [INFO] [stderr] 19 | fmt.write_fmt(format_args!("expected {}, got {}", expected, ty)) [INFO] [stderr] 20 | } [INFO] [stderr] 21 | Error::MissingField(ref name) => { [INFO] [stderr] 22 | fmt.write_fmt(format_args!("missing object field '{}'", name)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 35 | | &Value::I64(ref v) => *v as f64, [INFO] [stderr] 36 | | &Value::U64(ref v) => *v as f64, [INFO] [stderr] 37 | | &Value::F64(ref v) => *v, [INFO] [stderr] 38 | | _ => { return type_error("number", self.ty()); } [INFO] [stderr] 39 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | Ok(match *self { [INFO] [stderr] 35 | Value::I64(ref v) => *v as f64, [INFO] [stderr] 36 | Value::U64(ref v) => *v as f64, [INFO] [stderr] 37 | Value::F64(ref v) => *v, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 44 | | &Value::Null => None, [INFO] [stderr] 45 | | &Value::String(ref s) => Some(&s[..]), [INFO] [stderr] 46 | | _ => { return type_error("string or null", self.ty()); } [INFO] [stderr] 47 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | Ok(match *self { [INFO] [stderr] 44 | Value::Null => None, [INFO] [stderr] 45 | Value::String(ref s) => Some(&s[..]), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 52 | | &Value::Null => None, [INFO] [stderr] 53 | | &Value::Array(ref a) => Some(a), [INFO] [stderr] 54 | | _ => { return type_error("array or null", self.ty()); } [INFO] [stderr] 55 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | Ok(match *self { [INFO] [stderr] 52 | Value::Null => None, [INFO] [stderr] 53 | Value::Array(ref a) => Some(a), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 60 | | &Value::Null => None, [INFO] [stderr] 61 | | &Value::Object(ref o) => Some(o), [INFO] [stderr] 62 | | _ => { return type_error("object or null", self.ty()); } [INFO] [stderr] 63 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | Ok(match *self { [INFO] [stderr] 60 | Value::Null => None, [INFO] [stderr] 61 | Value::Object(ref o) => Some(o), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:67:12 [INFO] [stderr] | [INFO] [stderr] 67 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 68 | | &Value::Null => None, [INFO] [stderr] 69 | | &Value::Bool(ref b) => Some(*b), [INFO] [stderr] 70 | | _ => { return type_error("boolean or null", self.ty()); } [INFO] [stderr] 71 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | Ok(match *self { [INFO] [stderr] 68 | Value::Null => None, [INFO] [stderr] 69 | Value::Bool(ref b) => Some(*b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 76 | | &Value::Null => None, [INFO] [stderr] 77 | | &Value::I64(ref v) => Some(*v), [INFO] [stderr] 78 | | _ => { return type_error("i64 or null", self.ty()); } [INFO] [stderr] 79 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | Ok(match *self { [INFO] [stderr] 76 | Value::Null => None, [INFO] [stderr] 77 | Value::I64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | &Value::Null => None, [INFO] [stderr] 85 | | &Value::U64(ref v) => Some(*v), [INFO] [stderr] 86 | | _ => { return type_error("u64 or null", self.ty()); } [INFO] [stderr] 87 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | Ok(match *self { [INFO] [stderr] 84 | Value::Null => None, [INFO] [stderr] 85 | Value::U64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 92 | | &Value::Null => None, [INFO] [stderr] 93 | | &Value::F64(ref v) => Some(*v), [INFO] [stderr] 94 | | _ => { return type_error("f64 or null", self.ty()); } [INFO] [stderr] 95 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | Ok(match *self { [INFO] [stderr] 92 | Value::Null => None, [INFO] [stderr] 93 | Value::F64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unjson.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(match self { [INFO] [stderr] | ____________^ [INFO] [stderr] 100 | | &Value::Null => None, [INFO] [stderr] 101 | | &Value::I64(ref v) => Some(*v as f64), [INFO] [stderr] 102 | | &Value::U64(ref v) => Some(*v as f64), [INFO] [stderr] 103 | | &Value::F64(ref v) => Some(*v), [INFO] [stderr] 104 | | _ => { return type_error("number or null", self.ty()); } [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | Ok(match *self { [INFO] [stderr] 100 | Value::Null => None, [INFO] [stderr] 101 | Value::I64(ref v) => Some(*v as f64), [INFO] [stderr] 102 | Value::U64(ref v) => Some(*v as f64), [INFO] [stderr] 103 | Value::F64(ref v) => Some(*v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &Error::TypeMismatch(ref expected, ref ty) => { [INFO] [stderr] 19 | | fmt.write_fmt(format_args!("expected {}, got {}", expected, ty)) [INFO] [stderr] 20 | | } [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | Error::TypeMismatch(ref expected, ref ty) => { [INFO] [stderr] 19 | fmt.write_fmt(format_args!("expected {}, got {}", expected, ty)) [INFO] [stderr] 20 | } [INFO] [stderr] 21 | Error::MissingField(ref name) => { [INFO] [stderr] 22 | fmt.write_fmt(format_args!("missing object field '{}'", name)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "8a29770ecb8ef5c24c33108b5e374ba66f3f91b0ffb9dba197512556c26b7781"` [INFO] running `"docker" "rm" "-f" "8a29770ecb8ef5c24c33108b5e374ba66f3f91b0ffb9dba197512556c26b7781"` [INFO] [stdout] 8a29770ecb8ef5c24c33108b5e374ba66f3f91b0ffb9dba197512556c26b7781