[INFO] crate unix_socket 0.5.0 is already in cache [INFO] extracting crate unix_socket 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/unix_socket/0.5.0 [INFO] extracting crate unix_socket 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unix_socket/0.5.0 [INFO] validating manifest of unix_socket-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unix_socket-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unix_socket-0.5.0 [INFO] finished frobbing unix_socket-0.5.0 [INFO] frobbed toml for unix_socket-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/unix_socket/0.5.0/Cargo.toml [INFO] started frobbing unix_socket-0.5.0 [INFO] finished frobbing unix_socket-0.5.0 [INFO] frobbed toml for unix_socket-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unix_socket/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unix_socket-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unix_socket/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bfc7ef42221fabbebdf72f7be2009d53ca5394ea36d779fce25965ade29f3c1 [INFO] running `"docker" "start" "-a" "7bfc7ef42221fabbebdf72f7be2009d53ca5394ea36d779fce25965ade29f3c1"` [INFO] [stderr] Checking unix_socket v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:371:33 [INFO] [stderr] | [INFO] [stderr] 371 | Ok(UnixStream { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:31 [INFO] [stderr] | [INFO] [stderr] 572 | Ok(UnixListener { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:721:31 [INFO] [stderr] | [INFO] [stderr] 721 | Ok(UnixDatagram { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:728:27 [INFO] [stderr] | [INFO] [stderr] 728 | Ok(UnixDatagram { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:371:33 [INFO] [stderr] | [INFO] [stderr] 371 | Ok(UnixStream { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:572:31 [INFO] [stderr] | [INFO] [stderr] 572 | Ok(UnixListener { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:721:31 [INFO] [stderr] | [INFO] [stderr] 721 | Ok(UnixDatagram { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:728:27 [INFO] [stderr] | [INFO] [stderr] 728 | Ok(UnixDatagram { inner: inner }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | (dur.subsec_nanos() / 1000) as libc::suseconds_t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | (dur.subsec_nanos() / 1000) as libc::suseconds_t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / fn address<'a>(&'a self) -> AddressKind<'a> { [INFO] [stderr] 260 | | let len = self.len as usize - sun_path_offset(); [INFO] [stderr] 261 | | let path = unsafe { mem::transmute::<&[libc::c_char], &[u8]>(&self.addr.sun_path) }; [INFO] [stderr] 262 | | [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:261:29 [INFO] [stderr] | [INFO] [stderr] 261 | let path = unsafe { mem::transmute::<&[libc::c_char], &[u8]>(&self.addr.sun_path) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.addr.sun_path as *const [i8; 108] as *const [u8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:621:5 [INFO] [stderr] | [INFO] [stderr] 621 | / pub fn incoming<'a>(&'a self) -> Incoming<'a> { [INFO] [stderr] 622 | | Incoming { listener: self } [INFO] [stderr] 623 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/lib.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | (dur.subsec_nanos() / 1000) as libc::suseconds_t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dur.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/lib.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | (dur.subsec_nanos() / 1000) as libc::suseconds_t) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dur.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / fn address<'a>(&'a self) -> AddressKind<'a> { [INFO] [stderr] 260 | | let len = self.len as usize - sun_path_offset(); [INFO] [stderr] 261 | | let path = unsafe { mem::transmute::<&[libc::c_char], &[u8]>(&self.addr.sun_path) }; [INFO] [stderr] 262 | | [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:261:29 [INFO] [stderr] | [INFO] [stderr] 261 | let path = unsafe { mem::transmute::<&[libc::c_char], &[u8]>(&self.addr.sun_path) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.addr.sun_path as *const [i8; 108] as *const [u8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:621:5 [INFO] [stderr] | [INFO] [stderr] 621 | / pub fn incoming<'a>(&'a self) -> Incoming<'a> { [INFO] [stderr] 622 | | Incoming { listener: self } [INFO] [stderr] 623 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 938 | or_panic!(stream.read(&mut buf)); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 964 | or_panic!(s1.read(&mut buf)); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 991 | or_panic!(stream.read(&mut buf)); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1026 | or_panic!(stream.read(&mut buf)); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1028 | or_panic!(stream2.read(&mut buf)); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1044 | or_panic!(stream.read(&mut buf)); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:920:13 [INFO] [stderr] | [INFO] [stderr] 920 | / match $e { [INFO] [stderr] 921 | | Ok(e) => e, [INFO] [stderr] 922 | | Err(e) => panic!("{}", e), [INFO] [stderr] 923 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 1137 | or_panic!(stream.read(&mut buf)); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `unix_socket`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7bfc7ef42221fabbebdf72f7be2009d53ca5394ea36d779fce25965ade29f3c1"` [INFO] running `"docker" "rm" "-f" "7bfc7ef42221fabbebdf72f7be2009d53ca5394ea36d779fce25965ade29f3c1"` [INFO] [stdout] 7bfc7ef42221fabbebdf72f7be2009d53ca5394ea36d779fce25965ade29f3c1