[INFO] crate unix-named-pipe 0.2.0 is already in cache [INFO] extracting crate unix-named-pipe 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/unix-named-pipe/0.2.0 [INFO] extracting crate unix-named-pipe 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unix-named-pipe/0.2.0 [INFO] validating manifest of unix-named-pipe-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unix-named-pipe-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unix-named-pipe-0.2.0 [INFO] finished frobbing unix-named-pipe-0.2.0 [INFO] frobbed toml for unix-named-pipe-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/unix-named-pipe/0.2.0/Cargo.toml [INFO] started frobbing unix-named-pipe-0.2.0 [INFO] finished frobbing unix-named-pipe-0.2.0 [INFO] frobbed toml for unix-named-pipe-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unix-named-pipe/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unix-named-pipe-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unix-named-pipe/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4034c16ae277ccd4724b7cb5c281d7146d2bb603af9234f36be020f2837dd7c9 [INFO] running `"docker" "start" "-a" "4034c16ae277ccd4724b7cb5c281d7146d2bb603af9234f36be020f2837dd7c9"` [INFO] [stderr] Checking errno v0.2.4 [INFO] [stderr] Checking unix-named-pipe v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / return Err(io::Error::new( [INFO] [stderr] 53 | | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Err(io::Error::new( [INFO] [stderr] 53 | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / return Err(io::Error::new( [INFO] [stderr] 59 | | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Err(io::Error::new( [INFO] [stderr] 59 | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return Err(io::Error::new( [INFO] [stderr] 65 | | io::ErrorKind::NotFound, [INFO] [stderr] 66 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Err(io::Error::new( [INFO] [stderr] 65 | io::ErrorKind::NotFound, [INFO] [stderr] 66 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / return Err(io::Error::new( [INFO] [stderr] 71 | | io::ErrorKind::Other, [INFO] [stderr] 72 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 70 | Err(io::Error::new( [INFO] [stderr] 71 | io::ErrorKind::Other, [INFO] [stderr] 72 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / return Err(io::Error::new( [INFO] [stderr] 53 | | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Err(io::Error::new( [INFO] [stderr] 53 | io::ErrorKind::PermissionDenied, [INFO] [stderr] 54 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 55 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / return Err(io::Error::new( [INFO] [stderr] 59 | | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Err(io::Error::new( [INFO] [stderr] 59 | io::ErrorKind::AlreadyExists, [INFO] [stderr] 60 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 61 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / return Err(io::Error::new( [INFO] [stderr] 65 | | io::ErrorKind::NotFound, [INFO] [stderr] 66 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | Err(io::Error::new( [INFO] [stderr] 65 | io::ErrorKind::NotFound, [INFO] [stderr] 66 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 67 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / return Err(io::Error::new( [INFO] [stderr] 71 | | io::ErrorKind::Other, [INFO] [stderr] 72 | | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 70 | Err(io::Error::new( [INFO] [stderr] 71 | io::ErrorKind::Other, [INFO] [stderr] 72 | format!("could not open {:?}: {}", path, error), [INFO] [stderr] 73 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let result: i32 = result.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let result: i32 = result.into(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let _ = create(filename, None).expect("could not create pipe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | let _ = create(filename, None).expect("could not make test pipe"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | / write_file [INFO] [stderr] 198 | | .write(&contents) [INFO] [stderr] 199 | | .expect("could not write test data to pipe"); [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `unix-named-pipe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4034c16ae277ccd4724b7cb5c281d7146d2bb603af9234f36be020f2837dd7c9"` [INFO] running `"docker" "rm" "-f" "4034c16ae277ccd4724b7cb5c281d7146d2bb603af9234f36be020f2837dd7c9"` [INFO] [stdout] 4034c16ae277ccd4724b7cb5c281d7146d2bb603af9234f36be020f2837dd7c9