[INFO] crate unison 0.3.2 is already in cache [INFO] extracting crate unison 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/unison/0.3.2 [INFO] extracting crate unison 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unison/0.3.2 [INFO] validating manifest of unison-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unison-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unison-0.3.2 [INFO] finished frobbing unison-0.3.2 [INFO] frobbed toml for unison-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/unison/0.3.2/Cargo.toml [INFO] started frobbing unison-0.3.2 [INFO] finished frobbing unison-0.3.2 [INFO] frobbed toml for unison-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unison/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unison-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unison/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1d8e569e50f9397c56d8576e9db1748bcbc8e6d47cb2513392e40bcd05185b1 [INFO] running `"docker" "start" "-a" "c1d8e569e50f9397c56d8576e9db1748bcbc8e6d47cb2513392e40bcd05185b1"` [INFO] [stderr] Compiling memsec v0.3.4 [INFO] [stderr] Checking seckey v0.6.1 [INFO] [stderr] Checking unison v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod config; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/evaluation.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 94 | | if in_escape { [INFO] [stderr] 95 | | // Note: This is likely a good place for an invalid escape error [INFO] [stderr] 96 | | in_escape = false; [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | } else if in_escape { [INFO] [stderr] 94 | // Note: This is likely a good place for an invalid escape error [INFO] [stderr] 95 | in_escape = false; [INFO] [stderr] 96 | } else if start_var { [INFO] [stderr] 97 | string.push('$'); [INFO] [stderr] 98 | string.push(c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/value/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod value; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod config; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/inner.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::{current_dir, home_dir}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/inner.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(home_path) = home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/evaluation.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 94 | | if in_escape { [INFO] [stderr] 95 | | // Note: This is likely a good place for an invalid escape error [INFO] [stderr] 96 | | in_escape = false; [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 93 | } else if in_escape { [INFO] [stderr] 94 | // Note: This is likely a good place for an invalid escape error [INFO] [stderr] 95 | in_escape = false; [INFO] [stderr] 96 | } else if start_var { [INFO] [stderr] 97 | string.push('$'); [INFO] [stderr] 98 | string.push(c); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/value/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | mod value; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/inner.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::{current_dir, home_dir}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/inner.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | if let Some(home_path) = home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config/inner.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | let config_data = Value::from_path(&path).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config/inner.rs:80:61 [INFO] [stderr] | [INFO] [stderr] 80 | let config_data = Value::from_path(&path).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config/inner.rs:80:57 [INFO] [stderr] | [INFO] [stderr] 80 | let config_data = Value::from_path(&path).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config/inner.rs:80:61 [INFO] [stderr] | [INFO] [stderr] 80 | let config_data = Value::from_path(&path).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/inner.rs:115:50 [INFO] [stderr] | [INFO] [stderr] 115 | .filter(|a| &a[0..2] == "--" && a.contains("=")) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/inner.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | let split_index = a.find("=").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/inner.rs:115:50 [INFO] [stderr] | [INFO] [stderr] 115 | .filter(|a| &a[0..2] == "--" && a.contains("=")) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/inner.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | let split_index = a.find("=").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/evaluation.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | if !expression.contains("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/evaluation.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / match env::var(&env_var) { [INFO] [stderr] 53 | | Ok(s) => string += &s, [INFO] [stderr] 54 | | Err(_) => (), [INFO] [stderr] 55 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Ok(s) = env::var(&env_var) { string += &s }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/evaluation.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | if !expression.contains("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/evaluation.rs:67:15 [INFO] [stderr] | [INFO] [stderr] 67 | / match OpenOptions::new().read(true).open(path) { [INFO] [stderr] 68 | | Ok(mut f) => { [INFO] [stderr] 69 | | let _ = f.read_to_string(&mut string); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | Err(_) => (), [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | if let Ok(mut f) = OpenOptions::new().read(true).open(path) { [INFO] [stderr] 68 | let _ = f.read_to_string(&mut string); [INFO] [stderr] 69 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/evaluation.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / match env::var(&env_var) { [INFO] [stderr] 53 | | Ok(s) => string += &s, [INFO] [stderr] 54 | | Err(_) => (), [INFO] [stderr] 55 | | }; [INFO] [stderr] | |_____________^ help: try this: `if let Ok(s) = env::var(&env_var) { string += &s }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/evaluation.rs:67:15 [INFO] [stderr] | [INFO] [stderr] 67 | / match OpenOptions::new().read(true).open(path) { [INFO] [stderr] 68 | | Ok(mut f) => { [INFO] [stderr] 69 | | let _ = f.read_to_string(&mut string); [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | Err(_) => (), [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | if let Ok(mut f) = OpenOptions::new().read(true).open(path) { [INFO] [stderr] 68 | let _ = f.read_to_string(&mut string); [INFO] [stderr] 69 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/from_src.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | let is_json = src_sample.starts_with("{"); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/from_src.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | let is_toml = src_sample.starts_with("["); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/from_src.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | let is_json = src_sample.starts_with("{"); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/from_src.rs:48:42 [INFO] [stderr] | [INFO] [stderr] 48 | let is_toml = src_sample.starts_with("["); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/value/from_src.rs:69:59 [INFO] [stderr] | [INFO] [stderr] 69 | let toml_value: TomlValue = from_str(&string).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/value/from_src.rs:69:59 [INFO] [stderr] | [INFO] [stderr] 69 | let toml_value: TomlValue = from_str(&string).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/value/from_src.rs:79:61 [INFO] [stderr] | [INFO] [stderr] 79 | let json_value: JsonValue = from_reader(reader).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/traversal.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | let path_chunks = path.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/value/from_src.rs:79:61 [INFO] [stderr] | [INFO] [stderr] 79 | let json_value: JsonValue = from_reader(reader).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/traversal.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | let mut chunks: Vec<_> = path.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/traversal.rs:30:8 [INFO] [stderr] | [INFO] [stderr] 30 | if chunks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/traversal.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if chunks.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/traversal.rs:6:34 [INFO] [stderr] | [INFO] [stderr] 6 | let path_chunks = path.split("."); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/traversal.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match *self { [INFO] [stderr] 64 | | Value::HashMap(ref mut h) => { [INFO] [stderr] 65 | | h.insert(key.to_string(), value); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | _ => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Value::HashMap(ref mut h) = *self { [INFO] [stderr] 64 | h.insert(key.to_string(), value); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/value/traversal.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | let mut chunks: Vec<_> = path.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/traversal.rs:30:8 [INFO] [stderr] | [INFO] [stderr] 30 | if chunks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/traversal.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | if chunks.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value/traversal.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / match *self { [INFO] [stderr] 64 | | Value::HashMap(ref mut h) => { [INFO] [stderr] 65 | | h.insert(key.to_string(), value); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | _ => (), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | if let Value::HashMap(ref mut h) = *self { [INFO] [stderr] 64 | h.insert(key.to_string(), value); [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 101 | as_n!(self, u8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 104 | as_n!(self, u16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | Value::U64(v) => if v < <$n>::max_value() as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 107 | as_n!(self, u32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 113 | as_n!(self, i8) [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 116 | as_n!(self, i16) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/value/value.rs:182:10 [INFO] [stderr] | [INFO] [stderr] 182 | .expect(&format!("Invalid int tag {}", string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid int tag {}", string))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:30:63 [INFO] [stderr] | [INFO] [stderr] 30 | Value::I64(v) => if v > <$n>::min_value() as i64 && v < <$n>::max_value() as i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:31 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::min_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/value.rs:35:63 [INFO] [stderr] | [INFO] [stderr] 35 | Value::F64(v) => if v > <$n>::min_value() as f64 && v < <$n>::max_value() as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(<$n>::max_value())` [INFO] [stderr] ... [INFO] [stderr] 119 | as_n!(self, i32) [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/value/value.rs:189:10 [INFO] [stderr] | [INFO] [stderr] 189 | .expect(&format!("Invalid float tag {}", string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid float tag {}", string))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/value/value.rs:182:10 [INFO] [stderr] | [INFO] [stderr] 182 | .expect(&format!("Invalid int tag {}", string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid int tag {}", string))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/value/value.rs:189:10 [INFO] [stderr] | [INFO] [stderr] 189 | .expect(&format!("Invalid float tag {}", string)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Invalid float tag {}", string))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.63s [INFO] running `"docker" "inspect" "c1d8e569e50f9397c56d8576e9db1748bcbc8e6d47cb2513392e40bcd05185b1"` [INFO] running `"docker" "rm" "-f" "c1d8e569e50f9397c56d8576e9db1748bcbc8e6d47cb2513392e40bcd05185b1"` [INFO] [stdout] c1d8e569e50f9397c56d8576e9db1748bcbc8e6d47cb2513392e40bcd05185b1