[INFO] crate unique-type-id-derive 0.2.0 is already in cache [INFO] extracting crate unique-type-id-derive 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/unique-type-id-derive/0.2.0 [INFO] extracting crate unique-type-id-derive 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unique-type-id-derive/0.2.0 [INFO] validating manifest of unique-type-id-derive-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unique-type-id-derive-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unique-type-id-derive-0.2.0 [INFO] finished frobbing unique-type-id-derive-0.2.0 [INFO] frobbed toml for unique-type-id-derive-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/unique-type-id-derive/0.2.0/Cargo.toml [INFO] started frobbing unique-type-id-derive-0.2.0 [INFO] finished frobbing unique-type-id-derive-0.2.0 [INFO] frobbed toml for unique-type-id-derive-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unique-type-id-derive/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unique-type-id-derive-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unique-type-id-derive/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 220af641575131a187e328d67eb0f8ea962dfccf9b1cf773d302652fb7e921f5 [INFO] running `"docker" "start" "-a" "220af641575131a187e328d67eb0f8ea962dfccf9b1cf773d302652fb7e921f5"` [INFO] [stderr] Checking unique-type-id v0.2.0 [INFO] [stderr] Checking unique-type-id-derive v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | if !pairs_map.values().find(|id| &new_id == *id).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pairs_map.values().find(|id| &new_id == *id).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | if !pairs_map.values().find(|id| &new_id == *id).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|id| &new_id == *id).is_some()` with `any(|id| &new_id == *id)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | let name = attrs.iter().filter(|a| a.value.name() == "UniqueTypeIdFile").next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|a| a.value.name() == "UniqueTypeIdFile").next()` with `find(|a| a.value.name() == "UniqueTypeIdFile")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / match value { [INFO] [stderr] 110 | | &syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] 111 | | _ => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &syn::Lit::Str(ref value, _) = value { return value.to_owned() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / match value { [INFO] [stderr] 110 | | &syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] 111 | | _ => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *value { [INFO] [stderr] 110 | syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | if !pairs_map.values().find(|id| &new_id == *id).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pairs_map.values().find(|id| &new_id == *id).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | if !pairs_map.values().find(|id| &new_id == *id).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|id| &new_id == *id).is_some()` with `any(|id| &new_id == *id)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | let name = attrs.iter().filter(|a| a.value.name() == "UniqueTypeIdFile").next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|a| a.value.name() == "UniqueTypeIdFile").next()` with `find(|a| a.value.name() == "UniqueTypeIdFile")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / match value { [INFO] [stderr] 110 | | &syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] 111 | | _ => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ help: try this: `if let &syn::Lit::Str(ref value, _) = value { return value.to_owned() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / match value { [INFO] [stderr] 110 | | &syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] 111 | | _ => {}, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *value { [INFO] [stderr] 110 | syn::Lit::Str(ref value, _) => return value.to_owned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `"docker" "inspect" "220af641575131a187e328d67eb0f8ea962dfccf9b1cf773d302652fb7e921f5"` [INFO] running `"docker" "rm" "-f" "220af641575131a187e328d67eb0f8ea962dfccf9b1cf773d302652fb7e921f5"` [INFO] [stdout] 220af641575131a187e328d67eb0f8ea962dfccf9b1cf773d302652fb7e921f5