[INFO] crate unidecode 0.3.0 is already in cache [INFO] extracting crate unidecode 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/unidecode/0.3.0 [INFO] extracting crate unidecode 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unidecode/0.3.0 [INFO] validating manifest of unidecode-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unidecode-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unidecode-0.3.0 [INFO] finished frobbing unidecode-0.3.0 [INFO] frobbed toml for unidecode-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/unidecode/0.3.0/Cargo.toml [INFO] started frobbing unidecode-0.3.0 [INFO] finished frobbing unidecode-0.3.0 [INFO] frobbed toml for unidecode-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unidecode/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unidecode-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unidecode/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63b72c7aabe6580fdcaee9eaf438faa5742cd0ec4b8df5d229f4473f0bc49533 [INFO] running `"docker" "start" "-a" "63b72c7aabe6580fdcaee9eaf438faa5742cd0ec4b8df5d229f4473f0bc49533"` [INFO] [stderr] Checking unidecode v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | s.chars().map(|ch| unidecode_char(ch)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `unidecode_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | MAPPING.get(ch as usize).map(|&s| s).unwrap_or("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `MAPPING.get(ch as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | s.chars().map(|ch| unidecode_char(ch)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `unidecode_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | MAPPING.get(ch as usize).map(|&s| s).unwrap_or("") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `MAPPING.get(ch as usize).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unidecode.rs:10:58 [INFO] [stderr] | [INFO] [stderr] 10 | let valid_unicode = (0x0..0xD7FF + 1).chain(0x0E000..0x10FFFF + 1); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/unidecode.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | let valid_unicode = (0x0..0xD7FF + 1).chain(0x0E000..0x10FFFF + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(0x0..=0xD7FF)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/unidecode.rs:10:49 [INFO] [stderr] | [INFO] [stderr] 10 | let valid_unicode = (0x0..0xD7FF + 1).chain(0x0E000..0x10FFFF + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0x0E000..=0x10FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `"docker" "inspect" "63b72c7aabe6580fdcaee9eaf438faa5742cd0ec4b8df5d229f4473f0bc49533"` [INFO] running `"docker" "rm" "-f" "63b72c7aabe6580fdcaee9eaf438faa5742cd0ec4b8df5d229f4473f0bc49533"` [INFO] [stdout] 63b72c7aabe6580fdcaee9eaf438faa5742cd0ec4b8df5d229f4473f0bc49533