[INFO] crate unicode-casefold 0.2.0 is already in cache [INFO] extracting crate unicode-casefold 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/unicode-casefold/0.2.0 [INFO] extracting crate unicode-casefold 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicode-casefold/0.2.0 [INFO] validating manifest of unicode-casefold-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unicode-casefold-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unicode-casefold-0.2.0 [INFO] finished frobbing unicode-casefold-0.2.0 [INFO] frobbed toml for unicode-casefold-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/unicode-casefold/0.2.0/Cargo.toml [INFO] started frobbing unicode-casefold-0.2.0 [INFO] finished frobbing unicode-casefold-0.2.0 [INFO] frobbed toml for unicode-casefold-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicode-casefold/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unicode-casefold-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unicode-casefold/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed50d2a7988bcd3df94391b1562ed67a05c87941ac39fc197d48a59ad6a27104 [INFO] running `"docker" "start" "-a" "ed50d2a7988bcd3df94391b1562ed67a05c87941ac39fc197d48a59ad6a27104"` [INFO] [stderr] Checking unicode-casefold v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | locale: locale, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if let Ok(i) = COMMON_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 53 | | COMMON_TABLE[i].1 [INFO] [stderr] 54 | | } else if self.variant == Variant::Full { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if let Ok(i) = COMMON_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 52 | COMMON_TABLE[i].1 [INFO] [stderr] 53 | } else if self.variant == Variant::Full { [INFO] [stderr] 54 | if let Ok(i) = FULL_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 55 | let (r, b) = FULL_TABLE[i].1; [INFO] [stderr] 56 | self.buffer = b; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | if let Ok(i) = SIMPLE_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 62 | | SIMPLE_TABLE[i].1 [INFO] [stderr] 63 | | } else { c } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if let Ok(i) = SIMPLE_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 61 | SIMPLE_TABLE[i].1 [INFO] [stderr] 62 | } else { c } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if let Ok(i) = COMMON_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 53 | | COMMON_TABLE[i].1 [INFO] [stderr] 54 | | } else if self.variant == Variant::Full { [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if let Ok(i) = COMMON_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 52 | COMMON_TABLE[i].1 [INFO] [stderr] 53 | } else if self.variant == Variant::Full { [INFO] [stderr] 54 | if let Ok(i) = FULL_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 55 | let (r, b) = FULL_TABLE[i].1; [INFO] [stderr] 56 | self.buffer = b; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 61 | | if let Ok(i) = SIMPLE_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 62 | | SIMPLE_TABLE[i].1 [INFO] [stderr] 63 | | } else { c } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if let Ok(i) = SIMPLE_TABLE.binary_search_by_key(&c, |x| x.0) { [INFO] [stderr] 61 | SIMPLE_TABLE[i].1 [INFO] [stderr] 62 | } else { c } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "ed50d2a7988bcd3df94391b1562ed67a05c87941ac39fc197d48a59ad6a27104"` [INFO] running `"docker" "rm" "-f" "ed50d2a7988bcd3df94391b1562ed67a05c87941ac39fc197d48a59ad6a27104"` [INFO] [stdout] ed50d2a7988bcd3df94391b1562ed67a05c87941ac39fc197d48a59ad6a27104